From patchwork Tue Apr 18 14:53:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 84911 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2922524vqo; Tue, 18 Apr 2023 08:07:13 -0700 (PDT) X-Google-Smtp-Source: AKy350a3i1aUoxz4pz+Shh1J63hBHncoPdwBRCmIxJXbEsK8zMIrvzR6s2YgAuTZ/QVx0lFuJ34N X-Received: by 2002:a05:6a20:8411:b0:ec:d7cf:bcf7 with SMTP id c17-20020a056a20841100b000ecd7cfbcf7mr105539pzd.17.1681830433173; Tue, 18 Apr 2023 08:07:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681830433; cv=none; d=google.com; s=arc-20160816; b=H7eXu2UTbWBiEyP24+dS7Nycvz0oczkZbopyl6VJW9JI/0JZasoEQlTSt2haytPeDa VjRBXPmIcerqTnzsWnTAM322Ka5y8wqyB9EvZwMsQtXSaAMO/3lVEKkEon/5nRq695f0 9EM6JRcM8zUzM09JthrOv6Fv2orvC++NlT0qjk1UCfu8UD5nk6eJjjesBJeEKWiIqIqF R/FxZgG7WHIzfHdgrQuEe2ebFS4mw36UfTTaSbJ5RP8ptPpKokp49SWjnbuwFeV+1PZ7 BAJ1lCt4DOriZ/VhBWP8NVDTcN/R3cCN6nQGlviLpimLTWNVm9fFjA6Rs+PBIT401HQE s7wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=yhnur3/FfFvvoWBfWqpAV9Qz7hLwFbxsVzxcnah7ISY=; b=Bh7Fwrcl3UuL3ljNuxILkPVXvjzP1kHMRgn29EsgRuQBLyKEZXB1/UbWq4pudiAr4X +nOmj5OxCObpULzXO1yZcjxw2199ICUJBIbZ4maWjRwciKTQbXeOw/Dt1Z31MimBmqhb TbGtSBG91CFdDefQfSVp8qP4nDLyEIUQrSk1shUrtMolyyMgjhNYPuHGfJ37p8YWaM6H /qRzcwhm33gCmphDza/JzJymnmVtcZ2QX4AAa/cwi8ZuzD+TAMP/P8CsSStwKcWDgaZx yBRinh7Ctr8yZTYiML/GPe6BsPUFqCICvAo3C2enoQEUiSoBhKXSaS9S8a95wAoeGJQA /ZHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=ODq4r6wy; dkim=neutral (no key) header.i=@linutronix.de header.b=DL2kebB5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r21-20020a63d915000000b00518c878b1dbsi13866159pgg.356.2023.04.18.08.06.55; Tue, 18 Apr 2023 08:07:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=ODq4r6wy; dkim=neutral (no key) header.i=@linutronix.de header.b=DL2kebB5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231654AbjDROxk (ORCPT + 99 others); Tue, 18 Apr 2023 10:53:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230479AbjDROxd (ORCPT ); Tue, 18 Apr 2023 10:53:33 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7FF29EC9; Tue, 18 Apr 2023 07:53:30 -0700 (PDT) Date: Tue, 18 Apr 2023 14:53:28 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1681829609; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yhnur3/FfFvvoWBfWqpAV9Qz7hLwFbxsVzxcnah7ISY=; b=ODq4r6wythEElHoWY4Bqwr8DsFTthFCrHCCX/VULNbBDCgdV2ymP0dkmf0Rxrl2Ve3Uc2h OGYP6gOi9SjQV51S3ymtkaYXr3oylxNC/uxAJghVxs9tp/gxVuVv+jTmU0Rd+yRqOFd1vn MyQ6R2lejuMdUI1wn998JG0ZMbbytddfGK24T2NQFY21Taoe7h+j3gwwJWQ9bSCLX30Nw+ O/uPfM3LgZB3UWJbuQ9OZ9/+oG3BE31pvTPqWfKfYTSa4kYw9uSTMr1ouqeH9P0jaJBNs6 uVyOkvr5bbvHZIK65tdnvWIHQgJZ3hV/pWPtKTUAS7MXpil2iaURn6X5J/+Onw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1681829609; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yhnur3/FfFvvoWBfWqpAV9Qz7hLwFbxsVzxcnah7ISY=; b=DL2kebB57CFBtZhPT4XOWqa8r4OhntC0S9dBEKXf9NIo7G6qFB2IxEpLC3QWoiJVzvkIBe +udr8wDxm8Tp70Bg== From: "tip-bot2 for Frederic Weisbecker" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: timers/core] timers/nohz: Remove middle-function __tick_nohz_idle_stop_tick() Cc: Frederic Weisbecker , Thomas Gleixner , "Peter Zijlstra (Intel)" , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230222144649.624380-6-frederic@kernel.org> References: <20230222144649.624380-6-frederic@kernel.org> MIME-Version: 1.0 Message-ID: <168182960880.404.17395403193683319943.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758543378351152817?= X-GMAIL-MSGID: =?utf-8?q?1763527028298118586?= The following commit has been merged into the timers/core branch of tip: Commit-ID: 289dafed3851a7693a47896f5d09420bf6046ef2 Gitweb: https://git.kernel.org/tip/289dafed3851a7693a47896f5d09420bf6046ef2 Author: Frederic Weisbecker AuthorDate: Wed, 22 Feb 2023 15:46:46 +01:00 Committer: Thomas Gleixner CommitterDate: Tue, 18 Apr 2023 16:35:12 +02:00 timers/nohz: Remove middle-function __tick_nohz_idle_stop_tick() There is no need for the __tick_nohz_idle_stop_tick() function between tick_nohz_idle_stop_tick() and its implementation. Remove that unnecessary step. Signed-off-by: Frederic Weisbecker Signed-off-by: Thomas Gleixner Acked-by: Peter Zijlstra (Intel) Link: https://lore.kernel.org/r/20230222144649.624380-6-frederic@kernel.org --- kernel/time/tick-sched.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index edd6e9f..3b53b89 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -1079,10 +1079,16 @@ static bool can_stop_idle_tick(int cpu, struct tick_sched *ts) return true; } -static void __tick_nohz_idle_stop_tick(struct tick_sched *ts) +/** + * tick_nohz_idle_stop_tick - stop the idle tick from the idle task + * + * When the next event is more than a tick into the future, stop the idle tick + */ +void tick_nohz_idle_stop_tick(void) { - ktime_t expires; + struct tick_sched *ts = this_cpu_ptr(&tick_cpu_sched); int cpu = smp_processor_id(); + ktime_t expires; /* * If tick_nohz_get_sleep_length() ran tick_nohz_next_event(), the @@ -1114,16 +1120,6 @@ static void __tick_nohz_idle_stop_tick(struct tick_sched *ts) } } -/** - * tick_nohz_idle_stop_tick - stop the idle tick from the idle task - * - * When the next event is more than a tick into the future, stop the idle tick - */ -void tick_nohz_idle_stop_tick(void) -{ - __tick_nohz_idle_stop_tick(this_cpu_ptr(&tick_cpu_sched)); -} - void tick_nohz_idle_retain_tick(void) { tick_nohz_retain_tick(this_cpu_ptr(&tick_cpu_sched));