diff mbox series

[1/2] dt-bindings: display: mediatek: dp: Add compatible for MediaTek MT8188

Message ID 1681358785-6930-2-git-send-email-xinlei.lee@mediatek.com
State New
Headers
Series Add compatible to increase MT8188 audio control |

Commit Message

Xinlei Lee (李昕磊) April 13, 2023, 4:06 a.m. UTC 
  From: Xinlei Lee <xinlei.lee@mediatek.com>

Add dt-binding documentation of dp-tx for MediaTek MT8188 SoC.

Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
---
 .../devicetree/bindings/display/mediatek/mediatek,dp.yaml        | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski April 13, 2023, 7:55 a.m. UTC | #1 
On 13/04/2023 06:06, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
> 
> Add dt-binding documentation of dp-tx for MediaTek MT8188 SoC.
> 
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> ---

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
AngeloGioacchino Del Regno April 17, 2023, 11:28 a.m. UTC | #2 
Il 13/04/23 06:06, xinlei.lee@mediatek.com ha scritto:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
> 
> Add dt-binding documentation of dp-tx for MediaTek MT8188 SoC.
> 
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Are you sure that there's no eDP support planned for this SoC?
...because in that case you should also add a mediatek,mt8188-edp-tx compatible.
AngeloGioacchino Del Regno April 17, 2023, 11:29 a.m. UTC | #3 
Il 13/04/23 06:06, xinlei.lee@mediatek.com ha scritto:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
> 
> Add dt-binding documentation of dp-tx for MediaTek MT8188 SoC.
> 
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Are you sure that there's no eDP support planned for this SoC?
...because in that case you should also add a mediatek,mt8188-edp-tx compatible.


P.S.: Resent because the first one went out from the wrong email address. Sorry.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml
index ff781f2174a0..d1b8259b79a8 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dp.yaml
@@ -21,6 +21,7 @@  description: |
 properties:
   compatible:
     enum:
+      - mediatek,mt8188-dp-tx
       - mediatek,mt8195-dp-tx
       - mediatek,mt8195-edp-tx