Message ID | 1681192532-15460-2-git-send-email-ssengar@linux.microsoft.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2355061vqo; Mon, 10 Apr 2023 23:03:13 -0700 (PDT) X-Google-Smtp-Source: AKy350ZoqQzIbeb9sJbYnJM6cKiTGNBtPbl7MgQozp3UoIWU8tM0djcMFmawRIX3mdbe+JX0XGms X-Received: by 2002:a17:906:90d4:b0:94a:7696:4188 with SMTP id v20-20020a17090690d400b0094a76964188mr1204315ejw.74.1681192993136; Mon, 10 Apr 2023 23:03:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681192993; cv=none; d=google.com; s=arc-20160816; b=QVSApaOQ8RDj2F0VsGDVZ/xZQXypooGHMkHtDLEoJil257h0+1mFjlrvUhkcuKwgjl TULzqaZdv4MMK879vbwsKmsD0CFrPl2PcAlKDDBnzDng/j+rZcr8cuJHk0qZjCt4MN8V 7UpZsTB+Fz1uH7fRLlTYrmf+/xS5zoeN44JCzRMjYklCGebuPi+Ep7Kgn+0++NH0DrSc WdxvDOWHptSSO1DyjUBet83e9Kbu1ZdG7mpfp09pmxjEi0WgSicNafmm9gXbkyRk/KR3 2oh7dG7Si8EtPhRsiTGJfc1gvKh3kZLzg9unqidEn3DzTse+6eQLc+JUz+TjGi9qTB50 qRcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :to:from:dkim-signature:dkim-filter; bh=sYN20W6hPtwdUe2Zl//cBVNvF4+/oIZeshaAhbV6svU=; b=Hc6330OtPgc6t5UG29j0lFSToIPjPeybcMq5XU9kBO5II8errnj4z8ow3Fk3ZorHtw SjA1E2r0Z+jx4ZWyWjV5FcRUvvCTBO9GVN0cKoGbZrQ0KPoEY4uXn+UAdKU1h+pgCVt0 AtqyWgsvMmbHBL0+IILajXkk22pSdrQA9N5GIR7DfgTgOiEYhHgh42FdqH0yWpfIyU5e mbcVdJtWJDyBcxiMS3ZZxIXIF4J6p5O7JAI7LKwEJ4ekmeRJWlZ6v2hnHVuwtsy3kCCP GAqbjmVYMQbEApuWV8ctWXsBBbuH8MaVpsWqh68ggy7CqsggFXhp8Ulij/sNEQEYinhJ /s+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=idzwUv6G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id tx27-20020a1709078e9b00b0094a6cf63d3dsi1663923ejc.517.2023.04.10.23.02.48; Mon, 10 Apr 2023 23:03:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=idzwUv6G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230099AbjDKFzo (ORCPT <rfc822;yuanzuo1009@gmail.com> + 99 others); Tue, 11 Apr 2023 01:55:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229745AbjDKFzi (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 11 Apr 2023 01:55:38 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E32B3E6A; Mon, 10 Apr 2023 22:55:37 -0700 (PDT) Received: from linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net (linux.microsoft.com [13.77.154.182]) by linux.microsoft.com (Postfix) with ESMTPSA id 11C622174E4C; Mon, 10 Apr 2023 22:55:36 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 11C622174E4C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1681192536; bh=sYN20W6hPtwdUe2Zl//cBVNvF4+/oIZeshaAhbV6svU=; h=From:To:Subject:Date:In-Reply-To:References:From; b=idzwUv6Gsdkg0wnyQqpq5lQkOeM6LIXE5fuooJdMtIHc+LywW6HD5zD3UO4eknCiq v+/jYfSZQZb34Coj6puOwdMHmRyFkhm35IT4ASF9xJbKdsdd2d82VeJG95k1REsFpW ropd9J62LPnJs9RMsXECXs+SZJGiOqm+E+25n7MU= From: Saurabh Sengar <ssengar@linux.microsoft.com> To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, arnd@arndb.de, tiala@microsoft.com, mikelley@microsoft.com, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-arch@vger.kernel.org, jgross@suse.com, mat.jonczyk@o2.pl Subject: [PATCH v5 1/5] x86/init: Make get/set_rtc_noop() public Date: Mon, 10 Apr 2023 22:55:28 -0700 Message-Id: <1681192532-15460-2-git-send-email-ssengar@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1681192532-15460-1-git-send-email-ssengar@linux.microsoft.com> References: <1681192532-15460-1-git-send-email-ssengar@linux.microsoft.com> X-Spam-Status: No, score=-17.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_PASS,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762858624077243788?= X-GMAIL-MSGID: =?utf-8?q?1762858624077243788?= |
Series | Hyper-V VTL support | |
Commit Message
Saurabh Singh Sengar
April 11, 2023, 5:55 a.m. UTC
Make get/set_rtc_noop() to be public so that they can be used in other modules as well. Co-developed-by: Tianyu Lan <tiala@microsoft.com> Signed-off-by: Tianyu Lan <tiala@microsoft.com> Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com> Reviewed-by: Wei Liu <wei.liu@kernel.org> Reviewed-by: Michael Kelley <mikelley@microsoft.com> --- arch/x86/include/asm/x86_init.h | 2 ++ arch/x86/kernel/x86_init.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-)
Comments
On Mon, Apr 10, 2023 at 10:55:28PM -0700, Saurabh Sengar wrote: > Make get/set_rtc_noop() to be public so that they can be used > in other modules as well. > > Co-developed-by: Tianyu Lan <tiala@microsoft.com> > Signed-off-by: Tianyu Lan <tiala@microsoft.com> > Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com> > Reviewed-by: Wei Liu <wei.liu@kernel.org> > Reviewed-by: Michael Kelley <mikelley@microsoft.com> x86 maintainers, can you please ack or nack this patch? This looks trivially correct, but I don't want to apply this patch without an ack since this is under arch/x86. Thanks, Wei. > --- > arch/x86/include/asm/x86_init.h | 2 ++ > arch/x86/kernel/x86_init.c | 4 ++-- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h > index acc20ae4079d..88085f369ff6 100644 > --- a/arch/x86/include/asm/x86_init.h > +++ b/arch/x86/include/asm/x86_init.h > @@ -330,5 +330,7 @@ extern void x86_init_uint_noop(unsigned int unused); > extern bool bool_x86_init_noop(void); > extern void x86_op_int_noop(int cpu); > extern bool x86_pnpbios_disabled(void); > +extern int set_rtc_noop(const struct timespec64 *now); > +extern void get_rtc_noop(struct timespec64 *now); > > #endif > diff --git a/arch/x86/kernel/x86_init.c b/arch/x86/kernel/x86_init.c > index 95be3831df73..d82f4fa2f1bf 100644 > --- a/arch/x86/kernel/x86_init.c > +++ b/arch/x86/kernel/x86_init.c > @@ -33,8 +33,8 @@ static int __init iommu_init_noop(void) { return 0; } > static void iommu_shutdown_noop(void) { } > bool __init bool_x86_init_noop(void) { return false; } > void x86_op_int_noop(int cpu) { } > -static __init int set_rtc_noop(const struct timespec64 *now) { return -EINVAL; } > -static __init void get_rtc_noop(struct timespec64 *now) { } > +int set_rtc_noop(const struct timespec64 *now) { return -EINVAL; } > +void get_rtc_noop(struct timespec64 *now) { } > > static __initconst const struct of_device_id of_cmos_match[] = { > { .compatible = "motorola,mc146818" }, > -- > 2.34.1 >
On Thu, Apr 13, 2023 at 01:16:07AM +0000, Wei Liu wrote: > On Mon, Apr 10, 2023 at 10:55:28PM -0700, Saurabh Sengar wrote: > > Make get/set_rtc_noop() to be public so that they can be used > > in other modules as well. > > > > Co-developed-by: Tianyu Lan <tiala@microsoft.com> > > Signed-off-by: Tianyu Lan <tiala@microsoft.com> > > Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com> > > Reviewed-by: Wei Liu <wei.liu@kernel.org> > > Reviewed-by: Michael Kelley <mikelley@microsoft.com> > > x86 maintainers, can you please ack or nack this patch? Acked-by: Borislav Petkov (AMD) <bp@alien8.de>
On Thu, Apr 13, 2023 at 11:19:42AM +0200, Borislav Petkov wrote: > On Thu, Apr 13, 2023 at 01:16:07AM +0000, Wei Liu wrote: > > On Mon, Apr 10, 2023 at 10:55:28PM -0700, Saurabh Sengar wrote: > > > Make get/set_rtc_noop() to be public so that they can be used > > > in other modules as well. > > > > > > Co-developed-by: Tianyu Lan <tiala@microsoft.com> > > > Signed-off-by: Tianyu Lan <tiala@microsoft.com> > > > Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com> > > > Reviewed-by: Wei Liu <wei.liu@kernel.org> > > > Reviewed-by: Michael Kelley <mikelley@microsoft.com> > > > > x86 maintainers, can you please ack or nack this patch? > > Acked-by: Borislav Petkov (AMD) <bp@alien8.de> Thank you very much!
On Thu, Apr 13, 2023 at 03:34:33PM +0000, Wei Liu wrote: > On Thu, Apr 13, 2023 at 11:19:42AM +0200, Borislav Petkov wrote: > > On Thu, Apr 13, 2023 at 01:16:07AM +0000, Wei Liu wrote: > > > On Mon, Apr 10, 2023 at 10:55:28PM -0700, Saurabh Sengar wrote: > > > > Make get/set_rtc_noop() to be public so that they can be used > > > > in other modules as well. > > > > > > > > Co-developed-by: Tianyu Lan <tiala@microsoft.com> > > > > Signed-off-by: Tianyu Lan <tiala@microsoft.com> > > > > Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com> > > > > Reviewed-by: Wei Liu <wei.liu@kernel.org> > > > > Reviewed-by: Michael Kelley <mikelley@microsoft.com> > > > > > > x86 maintainers, can you please ack or nack this patch? > > > > Acked-by: Borislav Petkov (AMD) <bp@alien8.de> > > Thank you very much! Just a heads up: https://git.kernel.org/tip/775d3c514c5b2763a50ab7839026d7561795924d and that one is a fix so it'll go to Linus now. Which means, you'll have to use Linus' tree with that fix as a base and queue everything ontop.
On Thu, Apr 13, 2023 at 05:37:53PM +0200, Borislav Petkov wrote: > On Thu, Apr 13, 2023 at 03:34:33PM +0000, Wei Liu wrote: > > On Thu, Apr 13, 2023 at 11:19:42AM +0200, Borislav Petkov wrote: > > > On Thu, Apr 13, 2023 at 01:16:07AM +0000, Wei Liu wrote: > > > > On Mon, Apr 10, 2023 at 10:55:28PM -0700, Saurabh Sengar wrote: > > > > > Make get/set_rtc_noop() to be public so that they can be used > > > > > in other modules as well. > > > > > > > > > > Co-developed-by: Tianyu Lan <tiala@microsoft.com> > > > > > Signed-off-by: Tianyu Lan <tiala@microsoft.com> > > > > > Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com> > > > > > Reviewed-by: Wei Liu <wei.liu@kernel.org> > > > > > Reviewed-by: Michael Kelley <mikelley@microsoft.com> > > > > > > > > x86 maintainers, can you please ack or nack this patch? > > > > > > Acked-by: Borislav Petkov (AMD) <bp@alien8.de> > > > > Thank you very much! > > Just a heads up: > > https://git.kernel.org/tip/775d3c514c5b2763a50ab7839026d7561795924d > > and that one is a fix so it'll go to Linus now. > > Which means, you'll have to use Linus' tree with that fix as a base and > queue everything ontop. Okay, understood. Thanks. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette
diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h index acc20ae4079d..88085f369ff6 100644 --- a/arch/x86/include/asm/x86_init.h +++ b/arch/x86/include/asm/x86_init.h @@ -330,5 +330,7 @@ extern void x86_init_uint_noop(unsigned int unused); extern bool bool_x86_init_noop(void); extern void x86_op_int_noop(int cpu); extern bool x86_pnpbios_disabled(void); +extern int set_rtc_noop(const struct timespec64 *now); +extern void get_rtc_noop(struct timespec64 *now); #endif diff --git a/arch/x86/kernel/x86_init.c b/arch/x86/kernel/x86_init.c index 95be3831df73..d82f4fa2f1bf 100644 --- a/arch/x86/kernel/x86_init.c +++ b/arch/x86/kernel/x86_init.c @@ -33,8 +33,8 @@ static int __init iommu_init_noop(void) { return 0; } static void iommu_shutdown_noop(void) { } bool __init bool_x86_init_noop(void) { return false; } void x86_op_int_noop(int cpu) { } -static __init int set_rtc_noop(const struct timespec64 *now) { return -EINVAL; } -static __init void get_rtc_noop(struct timespec64 *now) { } +int set_rtc_noop(const struct timespec64 *now) { return -EINVAL; } +void get_rtc_noop(struct timespec64 *now) { } static __initconst const struct of_device_id of_cmos_match[] = { { .compatible = "motorola,mc146818" },