[irqchip:,irq/irqchip-next] irqchip/loongson-eiointc: Fix returned value on parsing MADT
Message ID | 168095071596.404.15580990145239593807.tip-bot2@tip-bot2 |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp801483vqo; Sat, 8 Apr 2023 03:54:58 -0700 (PDT) X-Google-Smtp-Source: AKy350YXKaZlyxNGzvRUxQmw28MG4cG8m44z2CGVt6Ez/N0p1Enhg6zlpfeML4DOEKpWS/1Gi2uL X-Received: by 2002:a17:906:9241:b0:947:c8d5:fb2a with SMTP id c1-20020a170906924100b00947c8d5fb2amr1911211ejx.48.1680951298038; Sat, 08 Apr 2023 03:54:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680951298; cv=none; d=google.com; s=arc-20160816; b=l918UDtUlNhcMbB7WV581Zlq64EpA/rjtJ1mrm2Yey0Z432utYu19I/M4ueQ3QGotk 01wpTZaUASJ2RAFAWSZa9LC53Hx5Y7twrTJpU2yfgn4kAuxvnKpDKDMkxO3kMW2T1Wik B7IQ4XaFvsWPMGeVokVx5lbXsBJS0QyKapJqV3uDPR+Pvrz7shDYe69wPMeaYxoSAg56 1y2/3IOwZOGiz2XTggnnDUD6Y3iwxbZ5Mche+hGKpqzLZTrtm9VcZoHUhPqzfbSsEh2F tt5cleDr7+t4LEetHQ839Kz5Q8kb23Ne/Nt1I/nxwFHgDDJveFG7WsZ928xvSRqlXXw0 /dOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=2aWNdqWCH6ooG7ZKCY8CAmB8Wk506YvYsyDSFqRjWL0=; b=fW1H9fS4aQB14EYyweo/KTqid7uXLMiKe45sINxxAG2aVXuJh0ksh+avjS8l+ZM5zK A7UJXPD0DPbqiC0QmB46xvVpTsTvCu/MQKUK6ihsTHv2+IQsCBMXLuR3J5bJVEtAUajv JhjkVDoytyFs9xQQdGJvsBvHZK1I5meAPH7Kzgc/CZ6TJBDJ1l6GCTEpUDLFkFszbnK/ Rv2vW87rcRRbTkoQVSzHW8nbi8qjMb1TU13lMUXa7TCJx5LwfLuaM//Sxb8b2kkK3L+M Bfy0WatslpDPePIkzidGbEwowRDjBf5cxlY3a0ljneiW3oDirtv5L0hrfSC7+e8i2aQT mVhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=2uf8x+Al; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t24-20020a05640203d800b005021cf614cesi616533edw.7.2023.04.08.03.54.34; Sat, 08 Apr 2023 03:54:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=2uf8x+Al; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230024AbjDHKrO (ORCPT <rfc822;a1648639935@gmail.com> + 99 others); Sat, 8 Apr 2023 06:47:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229924AbjDHKrF (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 8 Apr 2023 06:47:05 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C33B4C17; Sat, 8 Apr 2023 03:46:27 -0700 (PDT) Date: Sat, 08 Apr 2023 10:45:15 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1680950716; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2aWNdqWCH6ooG7ZKCY8CAmB8Wk506YvYsyDSFqRjWL0=; b=2uf8x+Al4PhQgvInEDLMteVLg2UdgF1YLfOJ7GL3LYqyRTg1DP/IxYIu5A+goI7Qmv9fXV 1TOlVSTkZys69TIEbVeWATSf8qSWtUxDZzfOK+d9bTMWR1En5NF0f/en4tl6bf3oQuVbKC dSewnGyyoLGjbNS1EcyR+x5WnMQe9anfWtnhaZYpajMVW5kQ4iFaF23Hhawy64q09KjL7w cxh9x6JLnYvINTixi9tgAuThPsu0w9FsmKWYhcOnNx6r388KZTUUwk6PSkvmar5a3NQH/+ 7Nr3clHpzlKwn1ymt72MwzlxUgcQsN0mV0nt5/0a6/efZJ4EgjXp5HWesS+oqQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1680950716; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2aWNdqWCH6ooG7ZKCY8CAmB8Wk506YvYsyDSFqRjWL0=; b=XywPNYzKt5qoF8plW89y4YstY9GNgyqI4/cmdMr7sorJbjiD42e689Cn6evI3hfiYaCG+1 lShr76qa4+jZGjDw== From: "irqchip-bot for Jianmin Lv" <tip-bot2@linutronix.de> Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-kernel@vger.kernel.org Subject: [irqchip: irq/irqchip-next] irqchip/loongson-eiointc: Fix returned value on parsing MADT Cc: stable@vger.kernel.org, Jianmin Lv <lvjianmin@loongson.cn>, Marc Zyngier <maz@kernel.org>, tglx@linutronix.de In-Reply-To: <20230407083453.6305-2-lvjianmin@loongson.cn> References: <20230407083453.6305-2-lvjianmin@loongson.cn> MIME-Version: 1.0 Message-ID: <168095071596.404.15580990145239593807.tip-bot2@tip-bot2> Robot-ID: <tip-bot2@linutronix.de> Robot-Unsubscribe: Contact <mailto:tglx@linutronix.de> to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762506394849431774?= X-GMAIL-MSGID: =?utf-8?q?1762605187925208784?= |
Series |
[irqchip:,irq/irqchip-next] irqchip/loongson-eiointc: Fix returned value on parsing MADT
|
|
Commit Message
tip-bot2 for Thomas Gleixner
April 8, 2023, 10:45 a.m. UTC
The following commit has been merged into the irq/irqchip-next branch of irqchip: Commit-ID: 112eaa8fec5ea75f1be003ec55760b09a86799f8 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/112eaa8fec5ea75f1be003ec55760b09a86799f8 Author: Jianmin Lv <lvjianmin@loongson.cn> AuthorDate: Fri, 07 Apr 2023 16:34:49 +08:00 Committer: Marc Zyngier <maz@kernel.org> CommitterDate: Sat, 08 Apr 2023 11:29:18 +01:00 irqchip/loongson-eiointc: Fix returned value on parsing MADT In pch_pic_parse_madt(), a NULL parent pointer will be returned from acpi_get_vec_parent() for second pch-pic domain related to second bridge while calling eiointc_acpi_init() at first time, where the parent of it has not been initialized yet, and will be initialized during second time calling eiointc_acpi_init(). So, it's reasonable to return zero so that failure of acpi_table_parse_madt() will be avoided, or else acpi_cascade_irqdomain_init() will return and initialization of followed pch_msi domain will be skipped. Although it does not matter when pch_msi_parse_madt() returns -EINVAL if no invalid parent is found, it's also reasonable to return zero for that. Cc: stable@vger.kernel.org Signed-off-by: Jianmin Lv <lvjianmin@loongson.cn> Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20230407083453.6305-2-lvjianmin@loongson.cn --- drivers/irqchip/irq-loongson-eiointc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-loongson-eiointc.c b/drivers/irqchip/irq-loongson-eiointc.c index d15fd38..62a632d 100644 --- a/drivers/irqchip/irq-loongson-eiointc.c +++ b/drivers/irqchip/irq-loongson-eiointc.c @@ -343,7 +343,7 @@ static int __init pch_pic_parse_madt(union acpi_subtable_headers *header, if (parent) return pch_pic_acpi_init(parent, pchpic_entry); - return -EINVAL; + return 0; } static int __init pch_msi_parse_madt(union acpi_subtable_headers *header, @@ -355,7 +355,7 @@ static int __init pch_msi_parse_madt(union acpi_subtable_headers *header, if (parent) return pch_msi_acpi_init(parent, pchmsi_entry); - return -EINVAL; + return 0; } static int __init acpi_cascade_irqdomain_init(void)