| Message ID | 1680631400-28865-2-git-send-email-quic_vnivarth@quicinc.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp76521vqo;
Tue, 4 Apr 2023 11:21:41 -0700 (PDT)
X-Google-Smtp-Source:
AKy350aP0TsX+lihEhJVPPeHrCw4aklTbGF6BBN3ql7I3k+JSnE/OdNpxCICkw0/gMWUfOtom1Nv
X-Received: by 2002:a17:90b:1d0b:b0:23f:582d:f45f with SMTP id
on11-20020a17090b1d0b00b0023f582df45fmr3969393pjb.1.1680632501503;
Tue, 04 Apr 2023 11:21:41 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1680632501; cv=none;
d=google.com; s=arc-20160816;
b=PhevtTXDQGPi9sZYFjtG6raDjL0HxYIf4jRFqOchjA1DdL4Nvo5hZZZt5NeiS6mbQz
JY/z4L5kj1wqwi6AfE+IlOY2B/gfA9cfWxxbGozvrI2mILx6BMq4LMyk75wP3Gziycxx
Y8DjRY8qltju/sejS2E1//UmmLLnqHEOV5iVhx0hRj8TjHO9a4DR7ood1bNv5SMiZQnm
h4xG7x6VAkrBuXxqDpg3N4yZvOHLt1cWhQ1k1F+hm6/uZUYi3JEzfP3j3U2VD6hdlir+
KkDzquqn3KarjwBC2gILI3FTjch7Px6F7EgpwlhRN1pYQfg9AUqje2XdJac7IoqNRpOu
1eUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:references:in-reply-to:message-id:date:subject
:cc:to:from:dkim-signature;
bh=4DYnLHn7XZTxnFdJEwXl5uWBD1OnCocCujGR7VPtX0w=;
b=lbJa6J2et6Xz4B9XF0sukKmGLtZonhKq51oDPpremdPHZ6CPl+zeTCPiwk4F4NOxZO
IOmVbnonoYhL84zpKU5+RO8XItXo0cZKK7H04bXJ0IuNTIEASd/22s7Iljgrp9Nw751B
H3pp+s8QmKztyrPwQ/n6xL1gmRMyUhoaRm0nniU4Uh8b69j+Qzb4FEIOF84AAMQ4L2kK
1nbld3yURNyduRRUAGvPiqNgIgmZ4uyu25MY15+JwJw4VNMLbRPNrKE1pIts6EvxOxRG
KkClLeJLOSVDbEl+B0h11KzwjGDbEqnJtwr+B6jMZJwrUP7SLZJtr87mZBJRjS44h0Mf
/yDQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=YiMdEV28;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
l3-20020a63ba43000000b00502ea80c38esi4946266pgu.269.2023.04.04.11.21.28;
Tue, 04 Apr 2023 11:21:41 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=YiMdEV28;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S236035AbjDDSDk (ORCPT <rfc822;a1648639935@gmail.com>
+ 99 others); Tue, 4 Apr 2023 14:03:40 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47672 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S234983AbjDDSDh (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 4 Apr 2023 14:03:37 -0400
Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com
[205.220.168.131])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C31C54219;
Tue, 4 Apr 2023 11:03:34 -0700 (PDT)
Received: from pps.filterd (m0279863.ppops.net [127.0.0.1])
by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
334FMxA6013506;
Tue, 4 Apr 2023 18:03:31 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com;
h=from : to : cc :
subject : date : message-id : in-reply-to : references; s=qcppdkim1;
bh=4DYnLHn7XZTxnFdJEwXl5uWBD1OnCocCujGR7VPtX0w=;
b=YiMdEV28ZoC0ObibNziJb122HSpL5CEpv/JasqTnr6fshV4yEv1pjNp9RLj1kV1KB/xQ
RDCjmQtSnViE4MhAtJh9HF8Ri84VbffLwk17NrXsxdMwl9CDvJCbSN554VlFREOQ7hrG
3yaAL6fB2g8YA4bZOLvtLhLru6v/TjpUhzxG8H3Mrn7ypSfvfHb+ZgHuY1hvoSAMSf36
3THYUYV25Y5YHm1iyQgkEi5afSbSCeBznatlnuLa4troBX17QqVnH5y57AXrxoD0ov1C
NNOSBHPxrhtO6kHwzDybdAmBao1OzixC+H687AvoltWUzDXffDeykR02RboKd568AHB/ Gw==
Received: from apblrppmta02.qualcomm.com
(blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19])
by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3prpg20dah-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Tue, 04 Apr 2023 18:03:30 +0000
Received: from pps.filterd (APBLRPPMTA02.qualcomm.com [127.0.0.1])
by APBLRPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id
334I3QjO021657;
Tue, 4 Apr 2023 18:03:26 GMT
Received: from pps.reinject (localhost [127.0.0.1])
by APBLRPPMTA02.qualcomm.com (PPS) with ESMTP id 3ppdpkvtrb-1;
Tue, 04 Apr 2023 18:03:26 +0000
Received: from APBLRPPMTA02.qualcomm.com (APBLRPPMTA02.qualcomm.com
[127.0.0.1])
by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 334I3QRF021651;
Tue, 4 Apr 2023 18:03:26 GMT
Received: from hu-sgudaval-hyd.qualcomm.com (hu-vnivarth-hyd.qualcomm.com
[10.213.111.166])
by APBLRPPMTA02.qualcomm.com (PPS) with ESMTP id 334I3Qtr021649;
Tue, 04 Apr 2023 18:03:26 +0000
Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 3994820)
id EA5B63B69; Tue, 4 Apr 2023 23:33:25 +0530 (+0530)
From: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
broonie@kernel.org, vkoul@kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Cc: quic_msavaliy@quicinc.com, dianders@chromium.org, mka@chromium.org,
swboyd@chromium.org, quic_vtanuku@quicinc.com,
Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
Subject: [PATCH 1/2] arm64: dts: qcom: sc7280: Add stream-id of qspi to iommus
Date: Tue, 4 Apr 2023 23:33:19 +0530
Message-Id: <1680631400-28865-2-git-send-email-quic_vnivarth@quicinc.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1680631400-28865-1-git-send-email-quic_vnivarth@quicinc.com>
References: <1680631400-28865-1-git-send-email-quic_vnivarth@quicinc.com>
X-QCInternal: smtphost
X-QCInternal: smtphost
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800
signatures=585085
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800
signatures=585085
X-Proofpoint-GUID: k5wF3LRYBvenUvKxRn8O9PiurOiAqIwq
X-Proofpoint-ORIG-GUID: k5wF3LRYBvenUvKxRn8O9PiurOiAqIwq
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
definitions=2023-04-04_09,2023-04-04_05,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
adultscore=0 phishscore=0
bulkscore=0 suspectscore=0 mlxscore=0 spamscore=0 mlxlogscore=724
lowpriorityscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx
scancount=1 engine=8.12.0-2303200000 definitions=main-2304040165
X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,
SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1762270906012166712?=
X-GMAIL-MSGID: =?utf-8?q?1762270906012166712?=
|
| Series |
spi: Add DMA mode support to spi-qcom-qspi
|
|
Commit Message
Vijaya Krishna Nivarthi
April 4, 2023, 6:03 p.m. UTC
This is done as part of adding DMA support to qspi driver.
Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 1 +
1 file changed, 1 insertion(+)
Comments
On 04/04/2023 20:03, Vijaya Krishna Nivarthi wrote: > This is done as part of adding DMA support to qspi driver. > > Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 5e6f9f4..9e05285 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -3434,6 +3434,7 @@ > qspi: spi@88dc000 { > compatible = "qcom,sc7280-qspi", "qcom,qspi-v1"; > reg = <0 0x088dc000 0 0x1000>; > + iommus = <&apps_smmu 0x20 0x0> Does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof
Thank you very much for the review... On 4/4/2023 11:49 PM, Krzysztof Kozlowski wrote: > On 04/04/2023 20:03, Vijaya Krishna Nivarthi wrote: >> This is done as part of adding DMA support to qspi driver. >> >> Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/sc7280.dtsi | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> index 5e6f9f4..9e05285 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> @@ -3434,6 +3434,7 @@ >> qspi: spi@88dc000 { >> compatible = "qcom,sc7280-qspi", "qcom,qspi-v1"; >> reg = <0 0x088dc000 0 0x1000>; >> + iommus = <&apps_smmu 0x20 0x0> > Does not look like you tested the DTS against bindings. Please run `make > dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst > for instructions). Added changes to yaml file, ran the check and ensured it builds fine. > Best regards, > Krzysztof >
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 5e6f9f4..9e05285 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -3434,6 +3434,7 @@ qspi: spi@88dc000 { compatible = "qcom,sc7280-qspi", "qcom,qspi-v1"; reg = <0 0x088dc000 0 0x1000>; + iommus = <&apps_smmu 0x20 0x0>; #address-cells = <1>; #size-cells = <0>; interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;