From patchwork Fri Mar 10 20:54:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 67726 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1113569wrd; Fri, 10 Mar 2023 13:44:57 -0800 (PST) X-Google-Smtp-Source: AK7set9ExNrjVqi4xRFoHER4wGdwI8aDvwB67RxeRT/vEy7UOS/8P+amzuwpPy4rNAhVALHxHT7/ X-Received: by 2002:a05:6a20:29a9:b0:c7:6c26:48b7 with SMTP id f41-20020a056a2029a900b000c76c2648b7mr21435289pzh.15.1678484697244; Fri, 10 Mar 2023 13:44:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678484697; cv=none; d=google.com; s=arc-20160816; b=GHrzmzXwa9IraS+25nh8Co0RtihcZhgFl4TLCJvSDV+eUXDGBWJ/4N4G5ObRbbmH0P XL1FI1NUjCY8EbcghcgD8whaE28IACDgYOmy6l8awmDkubCn7XEg2u9uP8He854z0YP/ 4oRDzYvfl336RrbzmTbCyTU9Hx7GlspP/jjbyoGIgh345vKN/JtbdlvVEc7tnqKhCtxM nf/dcr304ud/xw7I5ZD/hDNq1/Fp2MggJ8Ymvu/NiGW8jaN2fPKnW+4BiEJNyNTYWETl zKb/Xwq05EEXH1ps6hQICvvQSdf/rHFJlraw7phFELhaOr8MqRpvJO7BC9mkxLCc7rpu Jxtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=SymeUDKa3DSF68b1pHrLhL33sIy61tisuwLPE9bkyzM=; b=dAWeAs0U2Ba4SseW5H45dzHDs9OZOO83uex5BxrHcPXhVossMafuPjJTt6pe6FHleE Mz35pEVPcCE3On4ypV6VfJ+SXu9GhWsl6DSB1yw0VU1SF4SKF1CkwTR3Sw062fG8Xafj JNpEMZ9jIt7G+0kxkLSpAawY2rEA7yXTnmO4RZ8PAOiMcYFkgDs4GCI4HvEk6ZSWv/EN ukYo9FvB+L/jj+/gQAfGLzrtec15jVcoFFSJYW6cHMGcEp/EbIvwSf09BqSnI23jzTUB QUFeWB9jeffIPZpe42zJPU7S9RWK2lw4zHqw+gAtVVy6LqPHnjEfsHxNAMvJouc5qrKe Saxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=pHHQ3qI0; dkim=neutral (no key) header.i=@linutronix.de header.b=j2XS2wRi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q6-20020aa78426000000b0056cb8f6f027si564018pfn.357.2023.03.10.13.44.42; Fri, 10 Mar 2023 13:44:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=pHHQ3qI0; dkim=neutral (no key) header.i=@linutronix.de header.b=j2XS2wRi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231666AbjCJU4T (ORCPT + 99 others); Fri, 10 Mar 2023 15:56:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231591AbjCJUy5 (ORCPT ); Fri, 10 Mar 2023 15:54:57 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E04413553A; Fri, 10 Mar 2023 12:54:56 -0800 (PST) Date: Fri, 10 Mar 2023 20:54:54 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1678481695; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SymeUDKa3DSF68b1pHrLhL33sIy61tisuwLPE9bkyzM=; b=pHHQ3qI0VVvB4B/QmFgYuI5CtIu7qokWeuSzdPuNQSunaaqqRTaKzE7GpC9T6h6sgG9R05 dssNHH/M3kP+UpvpExCa2iaKYnC2kS+CkDUZCmY6BLAoWBfg6mITqexjhrbbH4WDKsHvz5 eEJ/nVbaaSWL8jwohB8ykX99am5K04CnO1kBLOw5D7q8FugxVfZqHnPUy2bz7NVcOB/jnK nxbBX8XWIr1wh/Gxbo2LIAsp9LO0ZWDXSRpvVs4XMEw9uYU4ERONWf7rA6aIQASqPdop2A 4owizD3vBXop6NLppWoWZpGdN9gEwQPB3U+Xi9HcQyS7i1xrOYhp9vdR0dRxPw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1678481695; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SymeUDKa3DSF68b1pHrLhL33sIy61tisuwLPE9bkyzM=; b=j2XS2wRiOueYJJD0uftlMVJqpiBsDnAeDwHisvXQO9LNZ44A/cSlq+/fg9lvH87OOYmuZk 8pU1nsdEKXi9UMBg== From: "tip-bot2 for Josh Poimboeuf" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: objtool/core] csky/cpu: Make sure arch_cpu_idle_dead() doesn't return Cc: Guo Ren , Josh Poimboeuf , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <1e9ecc3d248e82973e80bc336fc9f97e3ba2708d.1676358308.git.jpoimboe@kernel.org> References: <1e9ecc3d248e82973e80bc336fc9f97e3ba2708d.1676358308.git.jpoimboe@kernel.org> MIME-Version: 1.0 Message-ID: <167848169468.5837.15267243328787227151.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757789371142145902?= X-GMAIL-MSGID: =?utf-8?q?1760018770251419651?= The following commit has been merged into the objtool/core branch of tip: Commit-ID: 1b2442a835a0acc7d76ae2f48ca7a94f962b29c8 Gitweb: https://git.kernel.org/tip/1b2442a835a0acc7d76ae2f48ca7a94f962b29c8 Author: Josh Poimboeuf AuthorDate: Mon, 13 Feb 2023 23:05:39 -08:00 Committer: Josh Poimboeuf CommitterDate: Mon, 06 Mar 2023 15:34:05 -08:00 csky/cpu: Make sure arch_cpu_idle_dead() doesn't return arch_cpu_idle_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be next. Acked-by: Guo Ren Link: https://lore.kernel.org/r/1e9ecc3d248e82973e80bc336fc9f97e3ba2708d.1676358308.git.jpoimboe@kernel.org Signed-off-by: Josh Poimboeuf --- arch/csky/kernel/smp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/csky/kernel/smp.c b/arch/csky/kernel/smp.c index b45d107..0ec20ef 100644 --- a/arch/csky/kernel/smp.c +++ b/arch/csky/kernel/smp.c @@ -317,5 +317,7 @@ void arch_cpu_idle_dead(void) "jmpi csky_start_secondary" : : "r" (secondary_stack)); + + BUG(); } #endif