From patchwork Fri Mar 10 20:54:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 67687 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1095861wrd; Fri, 10 Mar 2023 12:58:53 -0800 (PST) X-Google-Smtp-Source: AK7set+FRlAReJD+RBfCT+DU4Ioy8I9V8A/WbfPhN8Byqg5/OitoF7lAiFxkrH3MpoKZhmSF7SVx X-Received: by 2002:a17:902:c40d:b0:19e:6955:36af with SMTP id k13-20020a170902c40d00b0019e695536afmr33191903plk.26.1678481933699; Fri, 10 Mar 2023 12:58:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678481933; cv=none; d=google.com; s=arc-20160816; b=eQUk8e2trWwiY1N23fty9zwi2MlzoTsox4t/DQpFQS13j7MfB2dq1aJpwFEFM1iqiC Z8nbEMrdAV1zV12tE7+MXaHGyutIBsS+uLbOHBXIJnneSDeJIpqOBiW+OC28KMkBsNVR lYMKECQ+j8ySSBZpTBX50kxkB1vB32d67NqW8aqRo8CEi2Wqam4wIhLetDoD7z6MJLw4 /s546lbfscbikXUz0ieVMSe+GYEluDUD42aLPqtsWKoeffvH1Bd7kzavqZGKhJAVzLOW YD4D3XZvesjpXc1941Us8KavhK19yqVN8D9q2q1Cuqo2GXN6OLn6kAKO2LVLsY11Lx24 vokg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=h0dR0inVz8gR/sb4C4cDn6wf5TOCd2gsXb1skIBfTaE=; b=IfhSuNtteh+rkM4kWgUXWnF7iEA0Ws6fJjtlcwoCgTbVvsW5TiLI1LXRHoBI2enMui 4YE056+QHoY0rQBL8XLpJaLrLG5NlTTVBMBijWcpwX+OpGgwvUJPg8PivWciNHIwTmul DvLgdj4Gk3XggDy2IMiChqcPfmuOZc6KJLB3ytO2P+Pyu1Dw5zBwAFxmjL/c2Po8aevq PWBK7X/RuLaVOMQ2bo27Z/hD/geMBloE7XYG8/UvnhKTbxrYt/9+RV17h2JgN1ZGVgqf B+yn48ww/F2SNZqSzqcLecuGMQ8gowUzAn2B4aiHeXdiiWbpZsmHvAnHVzGOOnCV3cpA 31ig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=a7rC2YTQ; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lg16-20020a170902fb9000b001993f9bdc13si679744plb.494.2023.03.10.12.58.09; Fri, 10 Mar 2023 12:58:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=a7rC2YTQ; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231767AbjCJU4J (ORCPT + 99 others); Fri, 10 Mar 2023 15:56:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231588AbjCJUy4 (ORCPT ); Fri, 10 Mar 2023 15:54:56 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D7AB132AAD; Fri, 10 Mar 2023 12:54:55 -0800 (PST) Date: Fri, 10 Mar 2023 20:54:53 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1678481694; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h0dR0inVz8gR/sb4C4cDn6wf5TOCd2gsXb1skIBfTaE=; b=a7rC2YTQyy7fIeI1QbOcnSIBy8v7UswIjo1lreFWvsChKfVvdAmq6huh13YOOue5n2cMkb EbC7fwd9TrMTQHWd5D3A2B+kpC7TyzvnlMPZVEkMv+IBuBM+iRMFgm7LuZAM21kWCbhJxi xqB2+6k/OjHkprykGTlAlsNmp89uWDmnZw3NTejTtLrlf7U0Rl98XKPATlurQUfg1g06WD 9zY89CzVA0CqEaKWcHX8LRzZ50N1Urb/q1KDZ+xEr6Ih1VKreadfg8dhvFtR28SZ5xhn/F N+YMHy3RDxfXGaI11NylS+2QVFx++8Fm8QtJfPA+hz/iYKTBoUUVfix1p/nw2g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1678481694; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h0dR0inVz8gR/sb4C4cDn6wf5TOCd2gsXb1skIBfTaE=; b=szV94LWCnUVOLsC8n31FgxS9SH523TbSZNMr7kTg7FPNmGtT8azhSTtD9i/whxswFa3PGz BNzsoPd3lh1nAKAw== From: "tip-bot2 for Josh Poimboeuf" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: objtool/core] loongarch/cpu: Make sure play_dead() doesn't return Cc: Josh Poimboeuf , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <21245d687ffeda34dbcf04961a2df3724f04f7c8.1676358308.git.jpoimboe@kernel.org> References: <21245d687ffeda34dbcf04961a2df3724f04f7c8.1676358308.git.jpoimboe@kernel.org> MIME-Version: 1.0 Message-ID: <167848169385.5837.15599094312506772594.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757789374736066056?= X-GMAIL-MSGID: =?utf-8?q?1760015872135928207?= The following commit has been merged into the objtool/core branch of tip: Commit-ID: 13bf7923a4dd34f3d2681768a148b10ddbdb95ed Gitweb: https://git.kernel.org/tip/13bf7923a4dd34f3d2681768a148b10ddbdb95ed Author: Josh Poimboeuf AuthorDate: Mon, 13 Feb 2023 23:05:41 -08:00 Committer: Josh Poimboeuf CommitterDate: Mon, 06 Mar 2023 15:34:06 -08:00 loongarch/cpu: Make sure play_dead() doesn't return play_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be next. Link: https://lore.kernel.org/r/21245d687ffeda34dbcf04961a2df3724f04f7c8.1676358308.git.jpoimboe@kernel.org Signed-off-by: Josh Poimboeuf --- arch/loongarch/kernel/smp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/loongarch/kernel/smp.c b/arch/loongarch/kernel/smp.c index 8c6e227..51f3281 100644 --- a/arch/loongarch/kernel/smp.c +++ b/arch/loongarch/kernel/smp.c @@ -336,7 +336,7 @@ void play_dead(void) iocsr_write32(0xffffffff, LOONGARCH_IOCSR_IPI_CLEAR); init_fn(); - unreachable(); + BUG(); } #endif