Message ID | 167848169247.5837.4395210640592574700.tip-bot2@tip-bot2 |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1098550wrd; Fri, 10 Mar 2023 13:04:30 -0800 (PST) X-Google-Smtp-Source: AK7set+wP5HqNs7o5/H1/3oNvGgCa3AEDNJPMw6RrxxMuQuizBvUpDGx7cJeu2Mj3FILF9uda0jE X-Received: by 2002:aa7:98de:0:b0:5ec:702c:5880 with SMTP id e30-20020aa798de000000b005ec702c5880mr21432625pfm.32.1678482270633; Fri, 10 Mar 2023 13:04:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678482270; cv=none; d=google.com; s=arc-20160816; b=a5bKtrRa6pBla3vDlObpnnT/hADfQLz9XJnitZKF/p5kMJnO8u5D/N1WG3MKLSNHo7 vCBtiH0HvQ8E6ri++kM6kzBOqttObFJqy3DQTNyRwxQK6x0L902GJiyLLY5J8g8WfVJz ynE2o3XyEv3sDPWHNS2nSlgBc9x9bePD18XFz+/yXMpHIXX8KfGIVNBW87GxW7QcxEqi bPYAvmO4D+WGX8ISvm0+GQgvt8fpZLyoZXSiPoZGLStSeUwuegCH3MoazIZke52k5Zr8 tQ3OGUk4I20T32zXzkAq5rhbXOdznA1ks+F7PImi7cmBbD46TmltIj8gzrI7H58sEF1m bnTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=NjC0FTxtmpLAecn/XQ1NoFaX1YT4mPri5PoJld/Px6g=; b=FlT4eQCRw+IRD1ufa6HJDYun9Xs/qSGSNL59c+n5f1B2u1uerW68lrMWeFDcMb2Njm E7mKjmfwUcGZ6osj8LMpIQ240zPSIE6l1aJ5eOKYn2I5BO+tknmqLiCAEpXj+ZYEFlUN wqHayiJJ55VHkWU1bkM/TcQFx6XvJMMmbFP857S889sTM8Y+iQweSHgM2H5ekTOh/kJ0 t0qK6C4bthqcFWE8UbbYPNNRZaT8TCow+25qT6Xqroq8S42MvHYT6iJ7gXoMubOSL6uN jzxiXNo0PTE9SxJihjfWxPMZRgZoBfV4RRIc3NTcQDwHsSvIuzuRn2a9rKlF6WqIm3d2 8NjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=rDUhS6SY; dkim=neutral (no key) header.i=@linutronix.de header.b=bCFpQk9q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k8-20020a654648000000b004faf0a78c50si650252pgr.110.2023.03.10.13.04.15; Fri, 10 Mar 2023 13:04:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=rDUhS6SY; dkim=neutral (no key) header.i=@linutronix.de header.b=bCFpQk9q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231654AbjCJUzx (ORCPT <rfc822;carlos.wei.hk@gmail.com> + 99 others); Fri, 10 Mar 2023 15:55:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231547AbjCJUyz (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 10 Mar 2023 15:54:55 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D4EB108691; Fri, 10 Mar 2023 12:54:54 -0800 (PST) Date: Fri, 10 Mar 2023 20:54:52 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1678481692; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NjC0FTxtmpLAecn/XQ1NoFaX1YT4mPri5PoJld/Px6g=; b=rDUhS6SYl//kywJSTGl9pVP/irDpEUSiQlfSx31OgIB0XQrOz+9rPF5ykyCpOrMJI+pfpX LMHfKyEmU+7qSXPyvRnbSqbrkVmAmncXgypPq+aZL9t3pnP9eJtr3zSGJQ+rkeLgOY8VEx BRsiMD00FQvYwKrzzzroJ5eHFAeJudizMX7/H8V9kWwDbC++E8afj70SvF9ngZXqd6hu4f lYXRvvOx+MCJrrECBu8deUtI2hnC0ceF1lr8JQK/wCWe7iD7ihRkA54DNW91stVhSKSPWi UQHpRSqa8D/a07iI2hVg3ZQifIfAGNzi3MWZ1tZGa+OiCuxFZeI5e+CPYDj6Yw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1678481692; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NjC0FTxtmpLAecn/XQ1NoFaX1YT4mPri5PoJld/Px6g=; b=bCFpQk9q02DyTTszs1y1k0oNV7WT+yyvdEKecCUzCfDp1Gs6gZPcJAAk1qIevaFhHb/Ghh pWtFnWlpIhrB81Cg== From: "tip-bot2 for Josh Poimboeuf" <tip-bot2@linutronix.de> Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: objtool/core] mips/cpu: Make sure play_dead() doesn't return Cc: Florian Fainelli <f.fainelli@gmail.com>, philmd@linaro.org, Josh Poimboeuf <jpoimboe@kernel.org>, x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <b195e4da190bb06b7d4af15d66ce6129e2347630.1676358308.git.jpoimboe@kernel.org> References: <b195e4da190bb06b7d4af15d66ce6129e2347630.1676358308.git.jpoimboe@kernel.org> MIME-Version: 1.0 Message-ID: <167848169247.5837.4395210640592574700.tip-bot2@tip-bot2> Robot-ID: <tip-bot2@linutronix.de> Robot-Unsubscribe: Contact <mailto:tglx@linutronix.de> to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757789386129135471?= X-GMAIL-MSGID: =?utf-8?q?1760016225278807890?= |
Series |
[tip:,objtool/core] mips/cpu: Make sure play_dead() doesn't return
|
|
Commit Message
tip-bot2 for Thomas Gleixner
March 10, 2023, 8:54 p.m. UTC
The following commit has been merged into the objtool/core branch of tip: Commit-ID: a80ceed6c9c24088d7a2e3c414eae1fe88a8ccbe Gitweb: https://git.kernel.org/tip/a80ceed6c9c24088d7a2e3c414eae1fe88a8ccbe Author: Josh Poimboeuf <jpoimboe@kernel.org> AuthorDate: Mon, 13 Feb 2023 23:05:44 -08:00 Committer: Josh Poimboeuf <jpoimboe@kernel.org> CommitterDate: Wed, 08 Mar 2023 08:44:23 -08:00 mips/cpu: Make sure play_dead() doesn't return play_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be next. Acked-by: Florian Fainelli <f.fainelli@gmail.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Link: https://lore.kernel.org/r/b195e4da190bb06b7d4af15d66ce6129e2347630.1676358308.git.jpoimboe@kernel.org Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org> --- arch/mips/kernel/smp-bmips.c | 2 ++ arch/mips/loongson64/smp.c | 1 + 2 files changed, 3 insertions(+)
diff --git a/arch/mips/kernel/smp-bmips.c b/arch/mips/kernel/smp-bmips.c index 51d5dae..15466d4 100644 --- a/arch/mips/kernel/smp-bmips.c +++ b/arch/mips/kernel/smp-bmips.c @@ -415,6 +415,8 @@ void __ref play_dead(void) " wait\n" " j bmips_secondary_reentry\n" : : : "memory"); + + BUG(); } #endif /* CONFIG_HOTPLUG_CPU */ diff --git a/arch/mips/loongson64/smp.c b/arch/mips/loongson64/smp.c index 4e24b31..df8d789 100644 --- a/arch/mips/loongson64/smp.c +++ b/arch/mips/loongson64/smp.c @@ -823,6 +823,7 @@ out: state_addr = &per_cpu(cpu_state, cpu); mb(); play_dead_at_ckseg1(state_addr); + BUG(); } static int loongson3_disable_clock(unsigned int cpu)