Message ID | 1677217619-10261-2-git-send-email-quic_prashk@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp723242wrd; Thu, 23 Feb 2023 21:51:40 -0800 (PST) X-Google-Smtp-Source: AK7set9PLqA3TJq5KbtnM6iOGqy3i6tp1aa4Wj27gcGxNSkXSQQz09IDeGSYfw8quB4fT64PzwL/ X-Received: by 2002:a05:6a20:8429:b0:cc:32a8:323d with SMTP id c41-20020a056a20842900b000cc32a8323dmr4066876pzd.28.1677217900072; Thu, 23 Feb 2023 21:51:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677217900; cv=none; d=google.com; s=arc-20160816; b=yTYzq6am4eor3DbwIBd/JV/0JAbH9XW+kuOsO/1nsNL3VZru8Oclb3y5cX0u8TgJcG OC1JbQELKiBzE9dLJTq+zAxy5AuNizwiV9haM2+66t3Kk3T821WV9Bda113Nq1mqXn7b jMGOA5yUB3pyAnqwbNN2S15SeLj7yWHu3mk5/hWCp3GjXuUYtJFKCjIkDKldtbxbQWhV +b+cAgXLESX6p7zH4DxoN3ao0iiEklSYOSCGZukZbvGXdxq7llXG84dBksTFEHETG25f FubfjGoTPWHPZWFDms8s5ZHbQy/02Si5/XDpFAWfiR083brGcQVvRMRwBTnZFL4aklz9 GMtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=16b+HZhOsrI0piiOMp5tSiivng3+xt3LsM6i9yIhu1g=; b=m8JIwL3ihHGxOQ6nxq2IH7KlGLSKaJTEYKnIlYXnX/Bxk2YhDFsWhaOoCkUD5XEkDi p4AJGV+NqrD2NeBBzyQULRIejm8JX3+w6CQuvoVWdfkzncB62CAQ+zANtClCLep/ip14 EqCoPxbe1Y/hpAHBZYNOC6n6q4cSBk9aUmWGQD88qKpen7OiHvGhG8vYByn8AKTKvsQW VhoLTqr+AnQ1sCxyABDjBJgynxG3h7YSqlBf1h9VEnya4AVmKNndh0JR0EuW+t0a0RU3 1NZL4dt7XIBjfe+lyCs42Xa2KuiuchVqLzQ+xSvtmQI31qCpXj+If49D2bgzHtZfTA/x lRog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=owF8F6j4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 8-20020a630008000000b004fd51160160si16201373pga.130.2023.02.23.21.51.26; Thu, 23 Feb 2023 21:51:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=owF8F6j4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229712AbjBXFrX (ORCPT <rfc822;jeff.pang.chn@gmail.com> + 99 others); Fri, 24 Feb 2023 00:47:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjBXFrV (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 24 Feb 2023 00:47:21 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09D7859E69; Thu, 23 Feb 2023 21:47:20 -0800 (PST) Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31O251Vn029384; Fri, 24 Feb 2023 05:47:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=16b+HZhOsrI0piiOMp5tSiivng3+xt3LsM6i9yIhu1g=; b=owF8F6j4ziARsABCmRhyETCEnsS6VHP405EDQmda0J3ti2OPCL1b70/i5/EEn7+GPk9z RfibVPeEJEHNz9mSsACyqhzl6bUUUQeW3ZaohJkgCJ+iBYWZbnOZT+i3e1P3cScyDocJ nSQScaBtM/b8H/b/L3ROscbdXE/LKVLgAt30eJNWDmUsZpwTDwT1K9eiOfxl5A1M6bRS 3FIrg5YcZenh7ptIf+nAG0CjzzwCwplFCbAmeKnrqFzCCPnVJ4gj391bq44DuZvzLNn2 20y3gu9WKN8NEs/xCxR5cYFhJV8X4THykfOZMRKnyOGyiE6bSrYsyJFXbKHWMJ0Kev/h Hw== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3nwy9a3jnn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Feb 2023 05:47:15 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31O5lEpT005991 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Feb 2023 05:47:14 GMT Received: from hu-prashk-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 23 Feb 2023 21:47:11 -0800 From: Prashanth K <quic_prashk@quicinc.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Thinh Nguyen <Thinh.Nguyen@synopsys.com>, Jakob Koschel <jakobkoschel@gmail.com>, =?utf-8?b?SsOzIMOBZ2lsYSBCaXRzY2g=?= <jgilab@gmail.com>, Alan Stern <stern@rowland.harvard.edu> CC: Pratham Pratap <quic_ppratap@quicinc.com>, Jack Pham <quic_jackp@quicinc.com>, <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Prashanth K <quic_prashk@quicinc.com> Subject: [PATCH v4 1/2] usb: dwc3: gadget: Change condition for processing suspend event Date: Fri, 24 Feb 2023 11:16:58 +0530 Message-ID: <1677217619-10261-2-git-send-email-quic_prashk@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1677217619-10261-1-git-send-email-quic_prashk@quicinc.com> References: <1677217619-10261-1-git-send-email-quic_prashk@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: H-L9mDw_OepXKt4cSVSOTaF6PHWHIlfR X-Proofpoint-ORIG-GUID: H-L9mDw_OepXKt4cSVSOTaF6PHWHIlfR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-24_02,2023-02-23_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 malwarescore=0 spamscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 mlxscore=0 mlxlogscore=698 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302240046 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758690436915193546?= X-GMAIL-MSGID: =?utf-8?q?1758690436915193546?= |
Series |
Fix vbus draw of dwc3 gadget
|
|
Commit Message
Prashanth K
Feb. 24, 2023, 5:46 a.m. UTC
Currently we process the suspend interrupt event only if the device is in configured state. Consider a case where device is not configured and got suspend interrupt, in that case our gadget will still use 100mA as composite_suspend didn't happen. But battery charging specification (BC1.2) expects a downstream device to draw less than 2.5mA when unconnected OR suspended. Fix this by removing the condition for processing suspend event, and thus composite_resume would set vbus draw to 2. Fixes: 72704f876f50 ("dwc3: gadget: Implement the suspend entry event handler") Signed-off-by: Prashanth K <quic_prashk@quicinc.com> Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> --- drivers/usb/dwc3/gadget.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 89dcfac..a83f34e 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -4241,15 +4241,8 @@ static void dwc3_gadget_interrupt(struct dwc3 *dwc, break; case DWC3_DEVICE_EVENT_SUSPEND: /* It changed to be suspend event for version 2.30a and above */ - if (!DWC3_VER_IS_PRIOR(DWC3, 230A)) { - /* - * Ignore suspend event until the gadget enters into - * USB_STATE_CONFIGURED state. - */ - if (dwc->gadget->state >= USB_STATE_CONFIGURED) - dwc3_gadget_suspend_interrupt(dwc, - event->event_info); - } + if (!DWC3_VER_IS_PRIOR(DWC3, 230A)) + dwc3_gadget_suspend_interrupt(dwc, event->event_info); break; case DWC3_DEVICE_EVENT_SOF: case DWC3_DEVICE_EVENT_ERRATIC_ERROR: