Message ID | 1677156121-30364-2-git-send-email-quic_prashk@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp290872wrd; Thu, 23 Feb 2023 04:46:11 -0800 (PST) X-Google-Smtp-Source: AK7set8hzb7TI9MbQnftWC3mnUh6lAkNdKf9OGy4uBhlFHMz3BQ7YqMg8FB+B4b0afN5w9wrZEuV X-Received: by 2002:a17:902:680e:b0:19c:13d2:44c5 with SMTP id h14-20020a170902680e00b0019c13d244c5mr11624015plk.3.1677156371238; Thu, 23 Feb 2023 04:46:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677156371; cv=none; d=google.com; s=arc-20160816; b=ojfhauXEb//7V6A0aN+aN2RnX8AksKfP5USai2RLIm3zccDr4aUsBVkWPNYRaWSOzW 6tWm4otNIkcaxPps9/pqmXg2D2SvnXWyzKLly9rnP9TdrkJmkGAgxjAH41F/xLwl8fb6 szKTNFWrkca6VbvEIJmgk8pLyrHr1DA8avdByc0vL9uBaITZdvwN2Blb0Oalirxt3trx vSmu7DRgWkYoqDhl9DoSwktZwM4l98yNa7dN8Rqzj6fhAIIfJsHoKXB9Tpl/wjmnjxSa qfpqr2FfsbPRoBn7Yxv6FLoj0e6irR31niLTZyBkFx+oVtxs2zLa4yzrh9bcb7xTGOcc uRVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=NjY00UcLF5Tg2ubWKuLj92kmkGy6Av+56YP17HzFbUI=; b=wLGKnBvlyshIpiF/FTkHOGGxcWeXn1mgEnpsF6M4p7HvdmElULhzJH3sF/LJ62yZdx /0BVbtXVF+rQ3ADDJDFEy1M6UTwHxmzGTHc2p8X81UmwS9xg2n/OzcSyc2nTXXBbgtQb XlX9mSxXi/kG+qJr5UiyRxXYli2pkOH+DOVsSXYZMwrcbVvhP0y4ccOi69Oj9Visk0ai x/XIkHk2dEX2p+wghtabZzVMg9XXJFVsfIF4RG4yu3Ds0i+jlKHyscycFmqYL96PXP4U YI8Kadz+tWOJLdaiuJrXs1GaVuLjLDCLyc/9cYnYOx8WNhfMjdGzE/eUt/faVqkhvdoC sIVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=khuFKp48; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ks11-20020a170903084b00b0019b05e5b305si2254801plb.336.2023.02.23.04.45.56; Thu, 23 Feb 2023 04:46:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=khuFKp48; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234061AbjBWMmV (ORCPT <rfc822;cambridge8321@gmail.com> + 99 others); Thu, 23 Feb 2023 07:42:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234021AbjBWMmT (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 23 Feb 2023 07:42:19 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D06A113E0; Thu, 23 Feb 2023 04:42:18 -0800 (PST) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31NB5ln8017967; Thu, 23 Feb 2023 12:42:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=NjY00UcLF5Tg2ubWKuLj92kmkGy6Av+56YP17HzFbUI=; b=khuFKp48Ntl56ZorWBNEDrJCbIYnztiXpI/YJNsbeFdDLMHZ7FwzbMiDYRGmZ2PGf1m4 LWEwbvUmUOaEqRkpm7CjDdfnhSak+g78KLuY9cv5DwN6kzGquc/Ma/jK6DvRgHFVuYdo DhGWhnvy9fubFHx8IyLoOy99sn8Asw3HE8x0rA4Jw7wXTyWPksQlrJCqGPj1NK0QMUzd iE08A6AqODQFUyFNY8SRaXKS8qdW7oIxATQWdSvzVtSO+GRFeIbgZM8hNWRmzD9dQVhr bTMMkgtGSCALzQwtL3DGVqwVHDokbwhoN/j3/x7psZTBIHmue4AcfsJWvMzyMv4vmajN PA== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3nwyc5hams-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Feb 2023 12:42:15 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31NCgDAY016130 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Feb 2023 12:42:13 GMT Received: from hu-prashk-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 23 Feb 2023 04:42:10 -0800 From: Prashanth K <quic_prashk@quicinc.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Thinh Nguyen <Thinh.Nguyen@synopsys.com>, Jakob Koschel <jakobkoschel@gmail.com>, =?utf-8?b?SsOzIMOBZ2lsYSBCaXRzY2g=?= <jgilab@gmail.com>, Alan Stern <stern@rowland.harvard.edu> CC: Pratham Pratap <quic_ppratap@quicinc.com>, Jack Pham <quic_jackp@quicinc.com>, <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Prashanth K <quic_prashk@quicinc.com> Subject: [PATCH v3 1/2] usb: dwc3: gadget: Change condition for processing suspend event Date: Thu, 23 Feb 2023 18:12:00 +0530 Message-ID: <1677156121-30364-2-git-send-email-quic_prashk@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1677156121-30364-1-git-send-email-quic_prashk@quicinc.com> References: <1677156121-30364-1-git-send-email-quic_prashk@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 1qbod9bMAE7bwKrgG1x2DiKu9T7C9c7d X-Proofpoint-GUID: 1qbod9bMAE7bwKrgG1x2DiKu9T7C9c7d X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-23_06,2023-02-23_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 phishscore=0 spamscore=0 mlxlogscore=634 bulkscore=0 adultscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302230103 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758625919075543215?= X-GMAIL-MSGID: =?utf-8?q?1758625919075543215?= |
Series |
Fix vbus draw of dwc3 gadget
|
|
Commit Message
Prashanth K
Feb. 23, 2023, 12:42 p.m. UTC
Currently we process the suspend interrupt event only if the
device is in configured state. Consider a case where device
is not configured and got suspend interrupt, in that case our
gadget will still use 100mA as composite_suspend didn't happen.
But battery charging specification (BC1.2) expects a downstream
device to draw less than 2.5mA when unconnected OR suspended.
Fix this by removing the condition for processing suspend event,
and thus composite_resume would set vbus draw to 2.
Fixes: 72704f876f50 ("dwc3: gadget: Implement the suspend entry event handler")
Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
---
drivers/usb/dwc3/gadget.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
Comments
On Thu, Feb 23, 2023, Prashanth K wrote: > Currently we process the suspend interrupt event only if the > device is in configured state. Consider a case where device > is not configured and got suspend interrupt, in that case our > gadget will still use 100mA as composite_suspend didn't happen. > But battery charging specification (BC1.2) expects a downstream > device to draw less than 2.5mA when unconnected OR suspended. > > Fix this by removing the condition for processing suspend event, > and thus composite_resume would set vbus draw to 2. > > Fixes: 72704f876f50 ("dwc3: gadget: Implement the suspend entry event handler") > Signed-off-by: Prashanth K <quic_prashk@quicinc.com> > --- > drivers/usb/dwc3/gadget.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > index 89dcfac..a83f34e 100644 > --- a/drivers/usb/dwc3/gadget.c > +++ b/drivers/usb/dwc3/gadget.c > @@ -4241,15 +4241,8 @@ static void dwc3_gadget_interrupt(struct dwc3 *dwc, > break; > case DWC3_DEVICE_EVENT_SUSPEND: > /* It changed to be suspend event for version 2.30a and above */ > - if (!DWC3_VER_IS_PRIOR(DWC3, 230A)) { > - /* > - * Ignore suspend event until the gadget enters into > - * USB_STATE_CONFIGURED state. > - */ > - if (dwc->gadget->state >= USB_STATE_CONFIGURED) > - dwc3_gadget_suspend_interrupt(dwc, > - event->event_info); > - } > + if (!DWC3_VER_IS_PRIOR(DWC3, 230A)) > + dwc3_gadget_suspend_interrupt(dwc, event->event_info); > break; > case DWC3_DEVICE_EVENT_SOF: > case DWC3_DEVICE_EVENT_ERRATIC_ERROR: > -- > 2.7.4 > Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> Thanks, Thinh
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 89dcfac..a83f34e 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -4241,15 +4241,8 @@ static void dwc3_gadget_interrupt(struct dwc3 *dwc, break; case DWC3_DEVICE_EVENT_SUSPEND: /* It changed to be suspend event for version 2.30a and above */ - if (!DWC3_VER_IS_PRIOR(DWC3, 230A)) { - /* - * Ignore suspend event until the gadget enters into - * USB_STATE_CONFIGURED state. - */ - if (dwc->gadget->state >= USB_STATE_CONFIGURED) - dwc3_gadget_suspend_interrupt(dwc, - event->event_info); - } + if (!DWC3_VER_IS_PRIOR(DWC3, 230A)) + dwc3_gadget_suspend_interrupt(dwc, event->event_info); break; case DWC3_DEVICE_EVENT_SOF: case DWC3_DEVICE_EVENT_ERRATIC_ERROR: