Message ID | 1677129510-10283-2-git-send-email-quic_prashk@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp139283wrd; Wed, 22 Feb 2023 21:30:12 -0800 (PST) X-Google-Smtp-Source: AK7set+JDLYQrGj9LXcEto5faIT2qere4Vu6Vcp0kDDUIZJKG787H9bW6ciZ/CL9s6LHz6PsNU1e X-Received: by 2002:a05:6a00:21cf:b0:5a8:a0f3:6135 with SMTP id t15-20020a056a0021cf00b005a8a0f36135mr11753565pfj.3.1677130212137; Wed, 22 Feb 2023 21:30:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677130212; cv=none; d=google.com; s=arc-20160816; b=TI2jyDCGg8hYAPj56WDRbQvgRF0YihFkIywIb+YsAw8644Xd0JBK0GKs6lskkwlS7K pUTnaYmx4/WIZhJv1Lo04NJXF1NjlpaWYeg+CZCPEFO/kR+zPr/12ZvrpKmrvnmvOyrn 1KPrgKBVJsmgog+tnaC8zucTpRl/CobmFoGGFG7UsqvPGaqEg7lOMGIMRTGqYgkg3N9J ghkaIRrLOtqqEVSU8VFe0YcXpLVU+onnKmOVwE3pVssz+Trlgk1IXCaVGsBoAx6dQfnH th5Nr0xCPUb89DUNFfmDOjDe7Q8gmOgEmmd7hiQvm9jfSycJJnUq4N1yHSWYAIMBKSgE AKaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=+Lw7UTc4O0iuLiYFsUORHobiA42VjkXdjQpQhes49ho=; b=bIC8+QgdIzC+sxMPrgusU2XX7dnx7A5Hz3XfVUe4Sq2+WGYPuqfq7rgEZqTna3608h QdwCB9u34dHjIGEQfMayAL4A9kzwXOF0DKdbsGob2XKzyYAjW4QY0FVsIcOv4KRf+Ftt 9YPC3N3ko7A1OIrCzo+FeALs2T0dSEeOE9IA/NLXGpP3wvUqRUZgmYIYhpQ8tmtM2kTz RlQ0cRDysbz13GItEZRiMIMl0cP4TRMy6QlZeq4OCw+RORMQ3GU0UxGPwyKHITlixMMK pzY1y3bC2A5ch0Gawzm3hCMcDxF4RHl12MGEkqUAUhSHmlePVJLK2fONakODkuY0btCz cE9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="bI///UeG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 184-20020a6307c1000000b004fb9579eefcsi5538021pgh.766.2023.02.22.21.29.58; Wed, 22 Feb 2023 21:30:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="bI///UeG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232801AbjBWFS6 (ORCPT <rfc822;cambridge8321@gmail.com> + 99 others); Thu, 23 Feb 2023 00:18:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233179AbjBWFSx (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 23 Feb 2023 00:18:53 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 024A73C78F; Wed, 22 Feb 2023 21:18:51 -0800 (PST) Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31N2RjqX020464; Thu, 23 Feb 2023 05:18:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=+Lw7UTc4O0iuLiYFsUORHobiA42VjkXdjQpQhes49ho=; b=bI///UeGhIKYY1lnlyRDHCOcKr0MDotugA0dfmBp3bnKA8PgP0iiwpF82U+mIJ/w7FIV 6vaDahqv//d1T5Kgy9I+vHn+JczodW5p6NCqjDIf1ZKpQxxyMr6VAtEexAnQgfHzAmUg Z5tXvrvAZXnr2vqFYtW1sHZQbK8JpsFnmq+QNt9/XgyFSxrgRk/3Yq0bXQxuLwKR+9kS 1g2tom6wfzCMiLIXytgoI+hSTkUwBO5HpCksFXptmXpUUcvVDZeSABQqsXBc3mBrWfzt AlRKCDSEKGH5T/J4bmjz1JBolcXjqvBtWnmjl7AofEcDsVeGSHh36W5E61AUtimFKT0N yg== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3nwyc5gb8h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Feb 2023 05:18:48 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31N5Il0Z017975 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Feb 2023 05:18:47 GMT Received: from hu-prashk-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 22 Feb 2023 21:18:44 -0800 From: Prashanth K <quic_prashk@quicinc.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Thinh Nguyen <Thinh.Nguyen@synopsys.com>, Jakob Koschel <jakobkoschel@gmail.com>, =?utf-8?b?SsOzIMOBZ2lsYSBCaXRzY2g=?= <jgilab@gmail.com>, Alan Stern <stern@rowland.harvard.edu> CC: Pratham Pratap <quic_ppratap@quicinc.com>, Jack Pham <quic_jackp@quicinc.com>, <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Prashanth K <quic_prashk@quicinc.com> Subject: [PATCH v1 1/2] usb: dwc3: gadget: Change condition for processing suspend event Date: Thu, 23 Feb 2023 10:48:29 +0530 Message-ID: <1677129510-10283-2-git-send-email-quic_prashk@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1677129510-10283-1-git-send-email-quic_prashk@quicinc.com> References: <1677129510-10283-1-git-send-email-quic_prashk@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: OC8oiRRx223cOZ4fNAOhk93aYCKFIJU- X-Proofpoint-GUID: OC8oiRRx223cOZ4fNAOhk93aYCKFIJU- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-23_02,2023-02-22_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 phishscore=0 spamscore=0 mlxlogscore=634 bulkscore=0 adultscore=0 mlxscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302230045 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758598489488626024?= X-GMAIL-MSGID: =?utf-8?q?1758598489488626024?= |
Series |
Fix vbus draw of dwc3 gadget
|
|
Commit Message
Prashanth K
Feb. 23, 2023, 5:18 a.m. UTC
Currently we process the suspend interrupt event only if the
device is in configured state. Consider a case where device
is not configured and got suspend interrupt, in that case our
gadget will still use 100mA as composite_suspend didn't happen.
But battery charging specification (BC1.2) expects a downstream
device to draw less than 2.5mA when unconnected OR suspended.
Fix this by removing the condition for processing suspend event,
and thus composite_resume would set vbus draw to 2.
Fixes: 72704f876f50 ("dwc3: gadget: Implement the suspend entry event handler")
Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
---
drivers/usb/dwc3/gadget.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 3c63fa9..07989c6 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -4239,15 +4239,8 @@ static void dwc3_gadget_interrupt(struct dwc3 *dwc, break; case DWC3_DEVICE_EVENT_SUSPEND: /* It changed to be suspend event for version 2.30a and above */ - if (!DWC3_VER_IS_PRIOR(DWC3, 230A)) { - /* - * Ignore suspend event until the gadget enters into - * USB_STATE_CONFIGURED state. - */ - if (dwc->gadget->state >= USB_STATE_CONFIGURED) - dwc3_gadget_suspend_interrupt(dwc, - event->event_info); - } + if (!DWC3_VER_IS_PRIOR(DWC3, 230A)) + dwc3_gadget_suspend_interrupt(dwc, event->event_info); break; case DWC3_DEVICE_EVENT_SOF: case DWC3_DEVICE_EVENT_ERRATIC_ERROR: