From patchwork Sat Feb 18 14:28:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 58938 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp406479wrn; Sat, 18 Feb 2023 06:56:32 -0800 (PST) X-Google-Smtp-Source: AK7set/qb7uuKiVeWs5DRCfRAYWFAamPd3RY6islEfK8qTAIdaEd4o0Xhiezw5g6EWOAelIol/B9 X-Received: by 2002:a17:90b:4c43:b0:234:bf0:86bc with SMTP id np3-20020a17090b4c4300b002340bf086bcmr3732522pjb.31.1676732192609; Sat, 18 Feb 2023 06:56:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676732192; cv=none; d=google.com; s=arc-20160816; b=kUMQgPlh2QFhT+UbtJKlaZlQzIwQU1C0zJ2qn8p8A2T3yFZgIiuoqUg80Nx3sna6WG hqgrUO94kS/5zbHkyT54+qdAldkpZYIvh/7GC+8VOHVP0pYWavSD51HSEC5WdyEoi+68 wX5qbYpTyxsOx2M/xihwqC78Z/swnoljrpfgwg1kChdA/dzXEajhxB23e8cVZkvGfpPA wIgSptduj3wQnDz50QPM8yw1EO2C1yFSouNGw9x2LWEaVQiV4AC7lHIXF8fg/BOtaYNX fPwx8vuzVvusgkqJPJ+EdAdT/u1IfZ1dBixQR9cJqymAYKlNMjaP7IiAxZaMeOcgs87C 6sWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=YYf8cdQX1+qWLhAT0OWbBu0XyR2VvktlZhwh5Ldum5I=; b=BWfxcxqcgpFj/WZEOQ6vbNK5oOE7Kfyam7k2u31MULJTK5mJLcuO/KcgYTV/Adootj teEa9rVaX4vJSY2HzOZsinXZJ51N1C9+IE9BROYkEjj1crV5MAWQu2BYr+JHoEAsaiT3 7XBj5YecUAOSswRItHKGtAw3zl6bA+cVIzwCbn99jU2Uv6dhdpCBenudZpKHCENQYql/ suMWZ1l3ZaiuAfP7AsduI5EGWjNSpz6Yu8ZfoToea1bV/e+p/l5zsO2qjVewFRl6uygI p1soUVddba2oceO8cHjQpV8CVTlEWAacnm0/kCyh6dFzHjuyGMKDuVH0qBDDlCfA4kMa Zj6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=cZcwsny+; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=LQK6ToFd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w71-20020a63824a000000b004fd10490f3dsi5817165pgd.251.2023.02.18.06.56.20; Sat, 18 Feb 2023 06:56:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=cZcwsny+; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=LQK6ToFd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229506AbjBRO2i (ORCPT + 99 others); Sat, 18 Feb 2023 09:28:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjBRO2h (ORCPT ); Sat, 18 Feb 2023 09:28:37 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16C1315CBA for ; Sat, 18 Feb 2023 06:28:36 -0800 (PST) Date: Sat, 18 Feb 2023 14:28:33 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1676730513; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YYf8cdQX1+qWLhAT0OWbBu0XyR2VvktlZhwh5Ldum5I=; b=cZcwsny+fQZgJoMJ4M3Ps4x1/u/Fki14JvAiARAyJ7vB7fkasRfqhtEVol3mO9W6xPnePn 3Gpl2XYGZPCpztbTrUHI/4WSq8mUpsHINFDiQdcC+edmKOzuvrNOSQ4n642nu85vkHAPtp VpEWt4Na+dpxDtcFkrFvsQxZAoVGo6PbEKJ/sGLnmTG//bAilL1EFyT6KyhV5p+yOUzcng QYMUh+HE6sQPqY9Zeq125XQ2dDpo9Mf7ZYKfjiLdxVamG/kCgKwrbmQSJqezeEwNkX2tbP PX9ySlMZWE3Srx9GJnZ4XiftBDKa6mOpLOBpet6kKS25xeIFLRkMZDAGk1IonQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1676730513; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YYf8cdQX1+qWLhAT0OWbBu0XyR2VvktlZhwh5Ldum5I=; b=LQK6ToFdPcEwQ/Hje+PZDkWeSuPReN23GQkeHcvIsFAjk/sBc9JW3g973uBKbLMDr7Bjqi vHxAtuekm5kgWHDg== From: "irqchip-bot for Florian Fainelli" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-kernel@vger.kernel.org Subject: [irqchip: irq/irqchip-next] irqchip/irq-brcmstb-l2: Set IRQ_LEVEL for level triggered interrupts Cc: Florian Fainelli , philmd@linaro.org, Marc Zyngier , tglx@linutronix.de In-Reply-To: <20221216230934.2478345-2-f.fainelli@gmail.com> References: <20221216230934.2478345-2-f.fainelli@gmail.com> MIME-Version: 1.0 Message-ID: <167673051321.4906.7043097380956478723.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1752414424211640878?= X-GMAIL-MSGID: =?utf-8?q?1758181135364781658?= The following commit has been merged into the irq/irqchip-next branch of irqchip: Commit-ID: 94debe03e8afa1267f95a9001786a6aa506b9ff3 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/94debe03e8afa1267f95a9001786a6aa506b9ff3 Author: Florian Fainelli AuthorDate: Fri, 16 Dec 2022 15:09:33 -08:00 Committer: Marc Zyngier CommitterDate: Sat, 18 Feb 2023 14:23:41 irqchip/irq-brcmstb-l2: Set IRQ_LEVEL for level triggered interrupts When support for the level triggered interrupt controller flavor was added with c0ca7262088e, we forgot to update the flags to be set to contain IRQ_LEVEL. While the flow handler is correct, the output from /proc/interrupts does not show such interrupts as being level triggered when they are, correct that. Fixes: c0ca7262088e ("irqchip/brcmstb-l2: Add support for the BCM7271 L2 controller") Signed-off-by: Florian Fainelli Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20221216230934.2478345-2-f.fainelli@gmail.com --- drivers/irqchip/irq-brcmstb-l2.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c index e4efc08..091b0fe 100644 --- a/drivers/irqchip/irq-brcmstb-l2.c +++ b/drivers/irqchip/irq-brcmstb-l2.c @@ -161,6 +161,7 @@ static int __init brcmstb_l2_intc_of_init(struct device_node *np, *init_params) { unsigned int clr = IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN; + unsigned int set = 0; struct brcmstb_l2_intc_data *data; struct irq_chip_type *ct; int ret; @@ -208,9 +209,12 @@ static int __init brcmstb_l2_intc_of_init(struct device_node *np, if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(CONFIG_CPU_BIG_ENDIAN)) flags |= IRQ_GC_BE_IO; + if (init_params->handler == handle_level_irq) + set |= IRQ_LEVEL; + /* Allocate a single Generic IRQ chip for this node */ ret = irq_alloc_domain_generic_chips(data->domain, 32, 1, - np->full_name, init_params->handler, clr, 0, flags); + np->full_name, init_params->handler, clr, set, flags); if (ret) { pr_err("failed to allocate generic irq chip\n"); goto out_free_domain;