From patchwork Tue Feb 14 22:56:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 57251 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp3244568wrn; Tue, 14 Feb 2023 15:00:42 -0800 (PST) X-Google-Smtp-Source: AK7set+CvizLc2L0p6r8Rb8OqbggXToPbAsWEKbx/Qoqalfay23njjM0TPIdolmUl/mD44FaVuiK X-Received: by 2002:a05:6a20:4417:b0:c3:cc88:c3a4 with SMTP id ce23-20020a056a20441700b000c3cc88c3a4mr5165566pzb.45.1676415642094; Tue, 14 Feb 2023 15:00:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676415642; cv=none; d=google.com; s=arc-20160816; b=zJk1SEhnMfBiNhbe9IuYUiJm0PChQal2W3quVPCjITE35gV5Uzd8FtcWR2oq6wzzCf eifdO20IlsUcg8lHqvLxlTU4tR5ka79SKwO5qmb1XW5tkQuIh67bsZCv0kYXTh2bo2+d jaGqK20Xwv4bXF6wgqPOXTBaVEyYd2+4PSUrAShtfCOjubz4f+bBIWSiVaM3VMZeZGVR BOtYGdF0JHsY1AZvtSH4jNZt16w7awj/E15sgjgZVudlodKU2rZWmzlw7xG97OgLzeEl rloIjgCEwo8oHyrrbL6jjosp04A8VTqKOZNVOFobHpFlFSipfaOpIu7x/JkpfRBX/f3H BRIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=F/EyZtc/c4hULHkzUWu3gLrNDX4NGHDqf7vxGPy2BCQ=; b=rWfIIvaNQvnXprgagv9mtDVmnd0VUz8f+tLj8bH+9W7fCo6aDRMloE9MQPGAABusrZ kSzTgOp3gUGcDJgWJ8oqt5jjvcGNqX1HwQ18oSCHUBndjqcNIq0vJ+dsxlLr4+p5X+1B S3/8ZYi2pZyjX/faS0SUfEyHJvVns8KVssVO7a6mmxtJH5rfcKKRf1wSRlXYji7I4QGN Q35Zo8l38s4m+dG0XZfli5yIvtXzyTqxK0P8vbdG11YozLI+BMfggRwDm/cY2WRztJ7Q gpehNkxONxzpbNq1WvB5b1jj8vb8avlHNy8NgReHDp4DkkRwjpD0+kiDl1qtjOGeedZ2 o+Og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=JTVFvuwU; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=FdKkpmd6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c22-20020a621c16000000b005a8be9b1b56si6295726pfc.217.2023.02.14.15.00.28; Tue, 14 Feb 2023 15:00:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=JTVFvuwU; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=FdKkpmd6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232169AbjBNW43 (ORCPT + 99 others); Tue, 14 Feb 2023 17:56:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232100AbjBNW40 (ORCPT ); Tue, 14 Feb 2023 17:56:26 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3C6D28D00; Tue, 14 Feb 2023 14:56:24 -0800 (PST) Date: Tue, 14 Feb 2023 22:56:21 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1676415382; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F/EyZtc/c4hULHkzUWu3gLrNDX4NGHDqf7vxGPy2BCQ=; b=JTVFvuwU0aYI15OKztuXlSY5Zn6fPvKrT5/s6UP6VyIV0/M5oBP8NBL91YBna9pW1oRGKC M9UIkyHU2KoitPVARKKnUGEUf7q7SjWS9pHpnm0CHJb+R5ik40zpFEojbxI3x2WELf/bcj MXyvRmzLNmAmhqMBHD6i6LcNgxldDShTZpia5gJ4x3aX0papVtDHgBM0wTzcpVCAv/UU/H qQ4m5Y1rkLvL3EGwlVlZpoARxMZg9nJ70bGhvnv5Ho0Swh+cG/hoYXcatpwI9U5nth933d QDiA6Zf8MqOOQ3FM1RPPfldpH4i18PEpYMsnJLY8/KwFTOEHgvBov51ALxqQPw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1676415382; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F/EyZtc/c4hULHkzUWu3gLrNDX4NGHDqf7vxGPy2BCQ=; b=FdKkpmd6Vl01v2MUrlXi38TF1la6Ov1yO5PXcE+QwYxJ9xYhpL6QVuogIMpgvp646C+zVw hset+cBK3FjlYZBg== From: "tip-bot2 for Srivatsa S. Bhat (VMware)" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/cleanups] x86/hotplug: Remove incorrect comment about mwait_play_dead() Cc: Thomas Gleixner , "Srivatsa S. Bhat (VMware)" , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230128003751.141317-1-srivatsa@csail.mit.edu> References: <20230128003751.141317-1-srivatsa@csail.mit.edu> MIME-Version: 1.0 Message-ID: <167641538169.4906.16439407610502454489.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756225821495778393?= X-GMAIL-MSGID: =?utf-8?q?1757849208333439409?= The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: fcb3a81d221750d2a54b4e3a82b3efbbeab8780c Gitweb: https://git.kernel.org/tip/fcb3a81d221750d2a54b4e3a82b3efbbeab8780c Author: Srivatsa S. Bhat (VMware) AuthorDate: Fri, 27 Jan 2023 16:37:51 -08:00 Committer: Thomas Gleixner CommitterDate: Tue, 14 Feb 2023 23:44:34 +01:00 x86/hotplug: Remove incorrect comment about mwait_play_dead() The comment that says mwait_play_dead() returns only on failure is a bit misleading because mwait_play_dead() could actually return for valid reasons (such as mwait not being supported by the platform) that do not indicate a failure of the CPU offline operation. So, remove the comment. Suggested-by: Thomas Gleixner Signed-off-by: Srivatsa S. Bhat (VMware) Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/r/20230128003751.141317-1-srivatsa@csail.mit.edu --- arch/x86/kernel/smpboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index 55cad72..9013bb2 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1833,7 +1833,7 @@ void native_play_dead(void) play_dead_common(); tboot_shutdown(TB_SHUTDOWN_WFS); - mwait_play_dead(); /* Only returns on failure */ + mwait_play_dead(); if (cpuidle_play_dead()) hlt_play_dead(); }