From patchwork Mon Feb 13 18:48:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 56451 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2513328wrn; Mon, 13 Feb 2023 10:53:55 -0800 (PST) X-Google-Smtp-Source: AK7set/gPkDIIODJCj/dCAQnhD/+5voW8N040n8FUd3eq5z0lDWB4zjFx9GsJnYEikIMbCRXD54z X-Received: by 2002:a17:906:6a20:b0:8af:2a97:91d4 with SMTP id qw32-20020a1709066a2000b008af2a9791d4mr25525004ejc.14.1676314435412; Mon, 13 Feb 2023 10:53:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676314435; cv=none; d=google.com; s=arc-20160816; b=Prnx9PqN13zdeCG6HLDothKjuV/uGH4Pfq/qBMpkRIHGnE7hwdkOxSe1a5kaONJFTf DC5G+E6REbX270Dn4eQM44RfY06vcniPCTL7Jbw1vF1vWRIXU3eaoON6vMdTs/INao1Z yZ+eHVgZlSvSQ76bZWHSv9EPXprHSsVJUNV5ocyedP77qIlA532VRI1LP6FLvGw4FtEf 3k2bVRPprzE4mVYI2Ut+LyiR1yuc1Le6zPWRVrlD7OITCe+X+UPu/bzDK1xYt45hojs/ QGJ6y9HoPXpdh/DRGKWPENvw2HTl5Ww5gPQ/mDbterCLUTc58gNr72OeDQ9fDDudg7Zg vUBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:cc:subject:to:reply-to:sender:from :dkim-signature:dkim-signature:date; bh=9b+Byo62pKbQj/k6bgSFis9WZ9wu30fro/AnJgLkOXw=; b=VlV4m2O9+DBiNaOHMFvMlauW7A3Ice032kiu8JxmURZKVxxO2zojP9hqHivus6JeNq 69tyfwNWdQUrh+hnzCBo4UvNUrPGbUK3nwYJaQuhphRB7IU5hFvb25OUgBEQHK71cbBC EonZvQBNPrfh1R5azBm7mFM8hGvC220TSpTyascXP4N6c2yRD8bENsuW9v6yMWiY57WR ko7GLtQ7XA5e4AUOQNOjIV3D2uajj+FqzubyJt10mMA89FYwnqM1knlX7ciXNbyaF8RB f6VsIxAgjiAzt6VDQqw8eHpT8ZkeUgjRV+vEziS/QMH5HBlYx9XPf25TVP82wG6hiNAr snnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=RZ1OMgRr; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fn24-20020a1709069d1800b0088ef8637b30si13041672ejc.568.2023.02.13.10.53.31; Mon, 13 Feb 2023 10:53:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=RZ1OMgRr; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230020AbjBMStA (ORCPT + 99 others); Mon, 13 Feb 2023 13:49:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229841AbjBMSsg (ORCPT ); Mon, 13 Feb 2023 13:48:36 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C32A0E07E; Mon, 13 Feb 2023 10:48:35 -0800 (PST) Date: Mon, 13 Feb 2023 18:48:33 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1676314113; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9b+Byo62pKbQj/k6bgSFis9WZ9wu30fro/AnJgLkOXw=; b=RZ1OMgRrfq6Xxy23hHrVzeAH9ufILm00sTvAObQHPSguQn06LA1DGhnpOWmVTLAmadoJO3 aWQa4DmktpVcxcZVxGck9MMxS7npRb8sUJMcg/rrSBJ1Woyo66OclF+p442uX6knDu8kdz QFQ8na4WbWBkcmxtq2uRpSpWl8lleobLjFVR+UDofW+EjLwE1XINrBiWr8U0etcTe9jpo+ rzv6QKNlCSK2aosLaYpOibjjx2AA+cZBJBU2gXXMFJAgctbE5D4/bycY32nihsVLMVY8Vm hxUiNMh4lKq2Hb7wa526wFXWra8SCGMtPfySCvSwolMcMDZPUUrufoW7aqOWCw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1676314113; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9b+Byo62pKbQj/k6bgSFis9WZ9wu30fro/AnJgLkOXw=; b=8NkPDS8GsY8hURi+83+QpKzDSg4mc/hPy51SOikFWc0rAsd5ogflJwR6IL9RBMhqRQztxQ Xz8KbVeVaDvMrtBg== From: "tip-bot2 for Paul E. McKenney" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: timers/core] clocksource: Improve read-back-delay message Cc: "Paul E. McKenney" , John Stultz , Thomas Gleixner , Stephen Boyd , Feng Tang , x86@kernel.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Message-ID: <167631411351.4906.13640037074294664636.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757743085516064771?= X-GMAIL-MSGID: =?utf-8?q?1757743085516064771?= The following commit has been merged into the timers/core branch of tip: Commit-ID: f092eb34b33043152bfb8a4ca01db9a06728261d Gitweb: https://git.kernel.org/tip/f092eb34b33043152bfb8a4ca01db9a06728261d Author: Paul E. McKenney AuthorDate: Tue, 13 Dec 2022 13:57:28 -08:00 Committer: Paul E. McKenney CommitterDate: Tue, 03 Jan 2023 20:43:45 -08:00 clocksource: Improve read-back-delay message When cs_watchdog_read() is unable to get a qualifying clocksource read within the limit set by max_cswd_read_retries, it prints a message and marks the clocksource under test as unstable. But that message is unclear to anyone unfamiliar with the code: clocksource: timekeeping watchdog on CPU13: wd-tsc-wd read-back delay 1000614ns, attempt 3, marking unstable Therefore, add some context so that the message appears as follows: clocksource: timekeeping watchdog on CPU13: wd-tsc-wd excessive read-back delay of 1000614ns vs. limit of 125000ns, wd-wd read-back delay only 27ns, attempt 3, marking tsc unstable Signed-off-by: Paul E. McKenney Cc: John Stultz Cc: Thomas Gleixner Cc: Stephen Boyd Cc: Feng Tang --- kernel/time/clocksource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c index a3d19f6..b599149 100644 --- a/kernel/time/clocksource.c +++ b/kernel/time/clocksource.c @@ -260,8 +260,8 @@ static enum wd_read_status cs_watchdog_read(struct clocksource *cs, u64 *csnow, goto skip_test; } - pr_warn("timekeeping watchdog on CPU%d: wd-%s-wd read-back delay of %lldns, attempt %d, marking unstable\n", - smp_processor_id(), cs->name, wd_delay, nretries); + pr_warn("timekeeping watchdog on CPU%d: wd-%s-wd excessive read-back delay of %lldns vs. limit of %ldns, wd-wd read-back delay only %lldns, attempt %d, marking %s unstable\n", + smp_processor_id(), cs->name, wd_delay, WATCHDOG_MAX_SKEW, wd_seq_delay, nretries, cs->name); return WD_READ_UNSTABLE; skip_test: