From patchwork Mon Feb 13 18:26:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 56434 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2503079wrn; Mon, 13 Feb 2023 10:30:59 -0800 (PST) X-Google-Smtp-Source: AK7set81rW6thdvX0ZiDyYQderfIvsU0JYEic6BWrae0VElj5V9RXmTo1Uv4z9eFVFx70GmWNOck X-Received: by 2002:a17:907:d089:b0:8af:2abb:3407 with SMTP id vc9-20020a170907d08900b008af2abb3407mr19261781ejc.11.1676313059270; Mon, 13 Feb 2023 10:30:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676313059; cv=none; d=google.com; s=arc-20160816; b=R99Q4Sq1tHOjCYOr3sOwcoA9SKzK1sZiXkL/TyxmWXgOhiu6p2mgtlhyeB8nKHDJhG KYD+3+HTMgjHuDcYK8ClBWfRkEpvxcU528BXkf7T65613LVFBJjlY2fmkuBWan5G+VcS KMGdmr7yuX3Q1Tc3wOMXWjJjCtrSfPEvUt8J/zqM6uoSQ1jP/rxotX6YoW9sSgfO+qzz qSn4dbc6eRnXfT7jS56qzj+K8C8nulX24NMHYF0TvhC8UHkSThOlXGoqpn2k7X7MxKbN 0QlLJ8fvxFVoVsv60vMhEWiTtcIHUHKF0PPUegD7M49BiKnH4mQ7JhAEAumval0Trhgv 6sww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=gUYW88Z3PvwE7weQUKwxFw/NWF6SI7hmAUO2Ck8gTCg=; b=iGobtFyjLQBs0chCht4KS0+R4AHtLy6KCqSKX376Y2DX8xnTey5bqSfzrVM8R+zYM+ pTJ7k9vwE6IxRK5o+3u+BuOHWvgpSq/faKP6aQNk2vVUzuWefwO9iPidDaepYfUREh5T 1xfwfwArtS3yC2bdlVRrXMglgzP79OeEq+EQzFbj1OY/GAASKjd97BD23rluhBeBBNCo Fl5ArYhKScPzba+k56FkEc+PI9eavLZvs2hKF3jpOaShiX80p8WtiQW007jT7ir74dlz 488bvacq1wOKTiUXGfi5ho5E6TbZbap7GHXbtMMfc7hpviKZgEKDkoHbQJ+R/PqPQD39 3spw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=pAjik7xI; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=79j+AQ5B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t10-20020a170906c38a00b00878809a0f92si13943723ejz.541.2023.02.13.10.30.36; Mon, 13 Feb 2023 10:30:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=pAjik7xI; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=79j+AQ5B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230495AbjBMS0r (ORCPT + 99 others); Mon, 13 Feb 2023 13:26:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229931AbjBMS02 (ORCPT ); Mon, 13 Feb 2023 13:26:28 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CECA2103; Mon, 13 Feb 2023 10:26:27 -0800 (PST) Date: Mon, 13 Feb 2023 18:26:23 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1676312784; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gUYW88Z3PvwE7weQUKwxFw/NWF6SI7hmAUO2Ck8gTCg=; b=pAjik7xIa0Ys/v/btmFOeilYCYlpZEgMTC2TiDuPIP4N5sdRUULDW4zCL7WJ4ou8xeANhr 8G7U5MP/cfRQG2kDadPSbw31zS4HSwLbd37OHnmqTTuPblx2gsSSGsxstPjPRds88qUbZE 4s1kSE33FavgHULJ9W3jLVnUrixQ4lyzZYNrKTSHk3OC2ao0mZmA1d1uqcmor43aKdOJmp /E4GrGrLAMzUW625cDcaU1sNN9qc0eGgj72EioKh3YWol7fMZDn8AXAz5xkJXpM9/EUMJI 1qqCFWviFK5wmbm2q2/yhAytqJ7XLawMwpzHYsEf5pusd/x5fyg77pnm6pf9aQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1676312784; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gUYW88Z3PvwE7weQUKwxFw/NWF6SI7hmAUO2Ck8gTCg=; b=79j+AQ5B860yhzGfNAG7LsO4Gg90zIy8fT3Kr6XS0IdCy64OI0E9sT0osPgPry7kIn25ti l42PdGAmfPQew9Dg== From: tip-bot2 for Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: timers/core] clocksource/drivers/sh_cmt: Mark driver as non-removable Cc: u.kleine-koenig@pengutronix.de, Daniel Lezcano , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230123220221.48164-1-u.kleine-koenig@pengutronix.de> References: <20230123220221.48164-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Message-ID: <167631278391.4906.3345100760900674930.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755852587874042187?= X-GMAIL-MSGID: =?utf-8?q?1757741642090351935?= The following commit has been merged into the timers/core branch of tip: Commit-ID: c3daa4754f3c57231bf47dcf4bdf897bc5c5f1f1 Gitweb: https://git.kernel.org/tip/c3daa4754f3c57231bf47dcf4bdf897bc5c5f1f1 Author: Uwe Kleine-König AuthorDate: Mon, 23 Jan 2023 23:02:21 +01:00 Committer: Daniel Lezcano CommitterDate: Mon, 13 Feb 2023 13:10:17 +01:00 clocksource/drivers/sh_cmt: Mark driver as non-removable The comment in the remove callback suggests that the driver is not supposed to be unbound. However returning an error code in the remove callback doesn't accomplish that. Instead set the suppress_bind_attrs property (which makes it impossible to unbind the driver via sysfs). The only remaining way to unbind a sh_cmt device would be module unloading, but that doesn't apply here, as the driver cannot be built as a module. Also drop the useless remove callback. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20230123220221.48164-1-u.kleine-koenig@pengutronix.de Signed-off-by: Daniel Lezcano --- drivers/clocksource/sh_cmt.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/clocksource/sh_cmt.c b/drivers/clocksource/sh_cmt.c index 7b952aa..8b2e079 100644 --- a/drivers/clocksource/sh_cmt.c +++ b/drivers/clocksource/sh_cmt.c @@ -1145,17 +1145,12 @@ static int sh_cmt_probe(struct platform_device *pdev) return 0; } -static int sh_cmt_remove(struct platform_device *pdev) -{ - return -EBUSY; /* cannot unregister clockevent and clocksource */ -} - static struct platform_driver sh_cmt_device_driver = { .probe = sh_cmt_probe, - .remove = sh_cmt_remove, .driver = { .name = "sh_cmt", .of_match_table = of_match_ptr(sh_cmt_of_table), + .suppress_bind_attrs = true, }, .id_table = sh_cmt_id_table, };