diff mbox series

[tip:,timers/core] clocksource/drivers/sh_cmt: Mark driver as non-removable

Message ID 167631278391.4906.3345100760900674930.tip-bot2@tip-bot2
State New
Headers
Series [tip:,timers/core] clocksource/drivers/sh_cmt: Mark driver as non-removable |

Commit Message

tip-bot2 for Thomas Gleixner Feb. 13, 2023, 6:26 p.m. UTC 
  The following commit has been merged into the timers/core branch of tip:

Commit-ID:     c3daa4754f3c57231bf47dcf4bdf897bc5c5f1f1
Gitweb:        https://git.kernel.org/tip/c3daa4754f3c57231bf47dcf4bdf897bc5c5f1f1
Author:        Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
AuthorDate:    Mon, 23 Jan 2023 23:02:21 +01:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Mon, 13 Feb 2023 13:10:17 +01:00

clocksource/drivers/sh_cmt: Mark driver as non-removable

The comment in the remove callback suggests that the driver is not
supposed to be unbound. However returning an error code in the remove
callback doesn't accomplish that. Instead set the suppress_bind_attrs
property (which makes it impossible to unbind the driver via sysfs).
The only remaining way to unbind a sh_cmt device would be module
unloading, but that doesn't apply here, as the driver cannot be built as
a module.

Also drop the useless remove callback.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230123220221.48164-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/sh_cmt.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
diff mbox series

Patch

diff --git a/drivers/clocksource/sh_cmt.c b/drivers/clocksource/sh_cmt.c
index 7b952aa..8b2e079 100644
--- a/drivers/clocksource/sh_cmt.c
+++ b/drivers/clocksource/sh_cmt.c
@@ -1145,17 +1145,12 @@  static int sh_cmt_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int sh_cmt_remove(struct platform_device *pdev)
-{
-	return -EBUSY; /* cannot unregister clockevent and clocksource */
-}
-
 static struct platform_driver sh_cmt_device_driver = {
 	.probe		= sh_cmt_probe,
-	.remove		= sh_cmt_remove,
 	.driver		= {
 		.name	= "sh_cmt",
 		.of_match_table = of_match_ptr(sh_cmt_of_table),
+		.suppress_bind_attrs = true,
 	},
 	.id_table	= sh_cmt_id_table,
 };