From patchwork Mon Feb 13 18:26:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 56432 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2503006wrn; Mon, 13 Feb 2023 10:30:52 -0800 (PST) X-Google-Smtp-Source: AK7set+RzSiKrMjzaDuifeUGZCr/JOLmM1FS6IKL5IXJYSB758TxmKNjJfKufNMgGLhbqFBJzwbn X-Received: by 2002:a05:6402:3583:b0:4a3:43c1:843e with SMTP id y3-20020a056402358300b004a343c1843emr9863014edc.18.1676313052034; Mon, 13 Feb 2023 10:30:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676313052; cv=none; d=google.com; s=arc-20160816; b=uAsZMj8bHdUbnTr++1AEKT52FGR7Twd5PENowNXpNRKWn9xc/MYLYA/gCIiPzINna5 WOFJbltYSOZEqdpxyksJGPGtogy1BxAKSL3KLPqELtx2Dxb7wgCuyabWalYHhEK96WYz pNj+mRpF83SxlHgb/lDSjPeOOXRV2U474n6XljV61HrMcW6yPo/r8DRsm7rKXnE2XJXC t+50vjQnEOQZ//Eii2g9WOeKIcUtMrkuZUL8ITHu9gdDmySF56dNz1qBGa48w3g/Vdiw IQaOOWgfMIdVGusaRExm0cVsnkAZ/f/OGTrhhX/LiSk6KcALdHAlb+bsCYgNdp3dsBg6 3lHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=I9C/RHQ23PWQE6219xLIoTf2rCC7qnKzbFR98gTwWxA=; b=w6Ea/LqK+NqcDBT+VIjAmhN6FK1LOGnhn2Whi3xzy0z09E0UHIcvcVNQ2VAXb4a/Rm iDtnN9ijN1yv8NlkC34d47TD3ugYkvm6yh7JFkDCwaz+YmwU2eGez0smz4rjJxnGx6Qa fzZjY7qZbBWA6Qege0qsPOb84ErCAhOldJoEjXWj/BySl8oL/JYBQ797gseWbIB8ldnF x/QFgN/CbyK/6+H7Q594NQCc/oCwei2BUtoxNVMF2r7rDogvqwr23GamZcoOQByoowRj LUmBtwNEEDQvsAJzAKfCV7+ZjiKlNq2TPbFL43TVcMNs3YdlGD1dFl5ABR165gPgVNjw LLGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="mzk9w/lq"; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v11-20020aa7d80b000000b004acc3bf2a7asi5900006edq.385.2023.02.13.10.30.28; Mon, 13 Feb 2023 10:30:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="mzk9w/lq"; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230517AbjBMS0f (ORCPT + 99 others); Mon, 13 Feb 2023 13:26:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229872AbjBMS00 (ORCPT ); Mon, 13 Feb 2023 13:26:26 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01BA026AE; Mon, 13 Feb 2023 10:26:23 -0800 (PST) Date: Mon, 13 Feb 2023 18:26:21 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1676312782; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I9C/RHQ23PWQE6219xLIoTf2rCC7qnKzbFR98gTwWxA=; b=mzk9w/lqw0bnr7GqZJbONsR5+eD93+wiTTjo9RtvEM7OIMMsyEwpA7bhUVCmo9mvOT1FMF QzfHRI6PqDMDwJ5HMNAOJE1KCfTu575tp4FHfOxz889/eAynhEyssZkbrNpOthGTYSn98R LpF0tK1XyiH6KSitJL2jL/2FJ7LpKMzhXSltFHo48R8ZUKZSD79JFqqx1Ek9TYd+qMNNSY SNLs4O29UG+GenC0REgPu5+wB1FDN49LA+KNvuZiRPV8bxDxpEibv/WsVqNP0TG1DF2HYT 0PIHK2ftYd0uVN+titKN5AsPge04tsCmPVcoJGchjpLqsUHW/mRRkCHugAPjwQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1676312782; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I9C/RHQ23PWQE6219xLIoTf2rCC7qnKzbFR98gTwWxA=; b=G0E9vtzzmJ4o2ihBKm5A1LPVYdQA9yCN2ud+IFyxpgvLYCu8O0YTYBt/KAIlkK29ktbH0o DGBD3eCwcIxP7rAg== From: tip-bot2 for Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: timers/core] clocksource/drivers/em_sti: Mark driver as non-removable Cc: u.kleine-koenig@pengutronix.de, Daniel Lezcano , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230207193010.469495-1-u.kleine-koenig@pengutronix.de> References: <20230207193010.469495-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Message-ID: <167631278165.4906.17139987456534507798.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757741634907663018?= X-GMAIL-MSGID: =?utf-8?q?1757741634907663018?= The following commit has been merged into the timers/core branch of tip: Commit-ID: cf16f631b0bbd98df4b2ccc13346f564412eae68 Gitweb: https://git.kernel.org/tip/cf16f631b0bbd98df4b2ccc13346f564412eae68 Author: Uwe Kleine-König AuthorDate: Tue, 07 Feb 2023 20:30:10 +01:00 Committer: Daniel Lezcano CommitterDate: Mon, 13 Feb 2023 13:10:17 +01:00 clocksource/drivers/em_sti: Mark driver as non-removable The comment in the remove callback suggests that the driver is not supposed to be unbound. However returning an error code in the remove callback doesn't accomplish that. Instead set the suppress_bind_attrs property (which makes it impossible to unbind the driver via sysfs). The only remaining way to unbind a em_sti device would be module unloading, but that doesn't apply here, as the driver cannot be built as a module. Also drop the useless remove callback. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20230207193010.469495-1-u.kleine-koenig@pengutronix.de Signed-off-by: Daniel Lezcano --- drivers/clocksource/em_sti.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c index ab190df..c04b47b 100644 --- a/drivers/clocksource/em_sti.c +++ b/drivers/clocksource/em_sti.c @@ -333,11 +333,6 @@ static int em_sti_probe(struct platform_device *pdev) return 0; } -static int em_sti_remove(struct platform_device *pdev) -{ - return -EBUSY; /* cannot unregister clockevent and clocksource */ -} - static const struct of_device_id em_sti_dt_ids[] = { { .compatible = "renesas,em-sti", }, {}, @@ -346,10 +341,10 @@ MODULE_DEVICE_TABLE(of, em_sti_dt_ids); static struct platform_driver em_sti_device_driver = { .probe = em_sti_probe, - .remove = em_sti_remove, .driver = { .name = "em_sti", .of_match_table = em_sti_dt_ids, + .suppress_bind_attrs = true, } };