Message ID | 1675725124-7375-2-git-send-email-si-wei.liu@oracle.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2515550wrn; Mon, 6 Feb 2023 15:13:01 -0800 (PST) X-Google-Smtp-Source: AK7set88/IRABhhkQdAcbPlhXQjwcPwxqawNFvfAR6iOfr5sptWxjk9mIxuy1/e3gBx3bHIbPDbV X-Received: by 2002:a17:902:e185:b0:199:2dc6:bb1d with SMTP id y5-20020a170902e18500b001992dc6bb1dmr391247pla.19.1675725181176; Mon, 06 Feb 2023 15:13:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675725181; cv=none; d=google.com; s=arc-20160816; b=MEH5wGzzNJ9qZH30Lqy03nw2iUiAXGloZ5IqVsroiVguv6HBOzF+SmJ3pw8XsWpHkp s5Y0Y0SDDPeyVlg7VrqcIFXq+oqkOFsmUCkWCGbH111zi1ut/06fBIUVb2CzleRozoFY cjt17umauRrd+9rJdW68JkBEcTy9QMFwniD3fi5gQsFbNZBqhIZuJ1/7Gfg3ll86xg5G 6MbrZGEXTvSi6icoeTlb7Z5imxnDDnWNNBtkS+syVy9kTQYWWmv3Hky2jmljJ6eqKXBl +365aQaIdYB6KSp8GOnVEuC7J/1arYyAdtKwcGHhmn7CEq+Gb7vFVWnGaAYZcLSH+Pyo J6Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=j/lEJg/ReXobH4hd+iLRobue9kWLN1CWVWeI2l8aOjc=; b=Ogdv/R6BJZr+gAVwU0v33vVE6nlGQGNqG/7TxAV8JvX80DeTTkJX4sy3bvBb9BiYnQ h0nuxigmQ2ppa2W94AoapagoBsjMjcUm/MUma0Mq0oKgmaFJTd/JJYYfeFwGMKx5Ymz6 0y9by6cviBWV/Zk2ZvwiLJW2h5aKB1J+CFcG3Scvh8WjCxWWMM0RX2K7wFWjGebtYgBJ 9aJxZTiWk1agUTxYrna7Q7jDM4yGflfWUD15Is3HsCaVPEzTtqDehYBbo1gajwjgL1QC luwC9EQXXDxy36fXg9c2U3J+ywH31LUWR0eOeKmgFeTSCBB20k48BQ0Y66R4oYpxgsPy TKsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2022-7-12 header.b=WB3eTk+S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i2-20020a170902c94200b0019488aa379asi13325746pla.181.2023.02.06.15.12.48; Mon, 06 Feb 2023 15:13:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2022-7-12 header.b=WB3eTk+S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229740AbjBFXMe (ORCPT <rfc822;kmanaouilinux@gmail.com> + 99 others); Mon, 6 Feb 2023 18:12:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbjBFXMb (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 6 Feb 2023 18:12:31 -0500 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C527A5FDE for <linux-kernel@vger.kernel.org>; Mon, 6 Feb 2023 15:12:30 -0800 (PST) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 316KE2p5029602; Mon, 6 Feb 2023 23:12:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2022-7-12; bh=j/lEJg/ReXobH4hd+iLRobue9kWLN1CWVWeI2l8aOjc=; b=WB3eTk+SgwsCzELNpHj1CqMpsrcyUnmWzL2NPge8m/zz8Gn30O/zUXzOv5wEsFFIDttU gdFWo/0idlAM9nIkaMldtqxE9VTFvy6g6OayaZ3jl7PFq7+C0FMlvrz0wDcPV84kzh0L wg7JFPko41Ty65spVCxyWrwhI/n0JuFatvmmKhc/u5YjXhUcelkOfqs3hlMn77BNE7LZ N7SLY2z2W1ZAyw6SysPRmVyyWK9kmdIP8p6G2D+ONFDAgF8Dx/jV+8kRwV7oNTwInuMQ uZ2+iMIVb3uyTpbmxst5YGM4X3/LgmXpFyzTtseqt56gH6p0qEm4N/UhuWFI0O4lK77t Jg== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3nhdsdm98y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 06 Feb 2023 23:12:25 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 316LpWgq021033; Mon, 6 Feb 2023 23:12:25 GMT Received: from ban25x6uut24.us.oracle.com (ban25x6uut24.us.oracle.com [10.153.73.24]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 3nhdt4sj6f-2; Mon, 06 Feb 2023 23:12:24 +0000 From: Si-Wei Liu <si-wei.liu@oracle.com> To: mst@redhat.com, jasowang@redhat.com, parav@nvidia.com, elic@nvidia.com Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH RESENT v4 1/6] vdpa: fix improper error message when adding vdpa dev Date: Mon, 6 Feb 2023 15:11:59 -0800 Message-Id: <1675725124-7375-2-git-send-email-si-wei.liu@oracle.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1675725124-7375-1-git-send-email-si-wei.liu@oracle.com> References: <1675725124-7375-1-git-send-email-si-wei.liu@oracle.com> X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-02-06_07,2023-02-06_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302060202 X-Proofpoint-ORIG-GUID: NxvGEQMqPTMj-jDk_enlwONQlORkSbJd X-Proofpoint-GUID: NxvGEQMqPTMj-jDk_enlwONQlORkSbJd X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757125207407617035?= X-GMAIL-MSGID: =?utf-8?q?1757125207407617035?= |
Series |
features provisioning fixes and mlx5_vdpa support
|
|
Commit Message
Si-Wei Liu
Feb. 6, 2023, 11:11 p.m. UTC
In below example, before the fix, mtu attribute is supported by the parent mgmtdev, but the error message showing "All provided are not supported" is just misleading. $ vdpa mgmtdev show vdpasim_net: supported_classes net max_supported_vqs 3 dev_features MTU MAC CTRL_VQ CTRL_MAC_ADDR ANY_LAYOUT VERSION_1 ACCESS_PLATFORM $ vdpa dev add mgmtdev vdpasim_net name vdpasim0 mtu 5000 max_vqp 2 Error: vdpa: All provided attributes are not supported. kernel answers: Operation not supported After fix, the relevant error message will be like: $ vdpa dev add mgmtdev vdpasim_net name vdpasim0 mtu 5000 max_vqp 2 Error: vdpa: Some provided attributes are not supported: 0x1000. kernel answers: Operation not supported Fixes: d8ca2fa5be1b ("vdpa: Enable user to set mac and mtu of vdpa device") Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com> Reviewed-by: Parav Pandit <parav@nvidia.com> Reviewed-by: Eli Cohen <elic@nvidia.com> --- drivers/vdpa/vdpa.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c index 8ef7aa1..3a82ca78 100644 --- a/drivers/vdpa/vdpa.c +++ b/drivers/vdpa/vdpa.c @@ -622,9 +622,11 @@ static int vdpa_nl_cmd_dev_add_set_doit(struct sk_buff *skb, struct genl_info *i err = PTR_ERR(mdev); goto err; } + if ((config.mask & mdev->config_attr_mask) != config.mask) { - NL_SET_ERR_MSG_MOD(info->extack, - "All provided attributes are not supported"); + NL_SET_ERR_MSG_FMT_MOD(info->extack, + "Some provided attributes are not supported: 0x%llx", + config.mask & ~mdev->config_attr_mask); err = -EOPNOTSUPP; goto err; }