[irqchip:,irq/irqchip-next] irqchip/ti-sci: Fix refcount leak in ti_sci_intr_irq_domain_probe
| Message ID | 167559659238.4906.13590911560182651325.tip-bot2@tip-bot2 |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1737111wrn;
Sun, 5 Feb 2023 03:33:32 -0800 (PST)
X-Google-Smtp-Source:
AK7set+KXpPC0Xkerf9Ug/CfASUGZJaaTiW99FGOPnSNnjJamKKZjQ0Ajxv1I/v75+8TJciwS1Xn
X-Received: by 2002:a62:388e:0:b0:590:6a57:9901 with SMTP id
f136-20020a62388e000000b005906a579901mr12987622pfa.18.1675596812090;
Sun, 05 Feb 2023 03:33:32 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1675596812; cv=none;
d=google.com; s=arc-20160816;
b=lMvezgYAXjiQW0iZvDfVgy3V8OM677aMtXvzyTwTbzZt8cLBWa/1RXF+fB9kGwPyw3
I0NGab4uB6wKE5EOPjRbGiE4J7/Ktw1j02ftT1vFfqPkgRaClDJkDT3nXk3J0W6jcPUq
g4hCsu4nWKy47HbiXgo/yFBhY3EMvAObMcj8sQz1VmwE7ctCrHGC95TtiXzvVcN9AfAh
JnJPyPbfFsqShVI+xMHS9SZzPrYqqjt1ar+3bNs+sNLHRLUuDiYxNSW6PCGa1ReTN09r
wcCaSBVv+cWjV6NsZctH5kxpgI7B7waevjuDn/Pet9exyHXH2/od+u1tHHZdnFT298gA
W3BQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:robot-unsubscribe
:robot-id:message-id:mime-version:references:in-reply-to:cc:subject
:to:reply-to:sender:from:dkim-signature:dkim-signature:date;
bh=mP3XJsTShQL14hAC+mnjW3TmxZmxPDuuvtQahw08qMo=;
b=aR0H3mSdFLSaEeTVkexXrTG3A3YrFXQkNHIKFQRuOyj0KOxrm6NlujCXRdvfgIqefk
4wyhtlLRv7V6H+Y4yioJwxVRk7pLD1iHthWLsUPTHwIZBOnaQcz2Xc0eiPFB/Qzfi4SY
Bqc2YTLdrex7+JsCebOWLZ++grKrQm4DHPeTdGnXR99eszv3qjsiD8kNxSzNTFpYfrhq
FIp2k49x4swDugEH+WNQ/FGPu1wuY7R5L4NjqQap4Fiwnqmo8LqzTIQ1rUyMG99R3wDZ
D6N3rPkmvg2d5CtBM9E2Q+kOw1C+X2qcB/mehwxuJZeXXcgg5gA88QOo4tAj5TM18pYy
7Gyw==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linutronix.de header.s=2020 header.b="LKw/e55/";
dkim=neutral (no key) header.i=@linutronix.de header.b=t+dx30LQ;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
t9-20020a056a00138900b0059072f087b7si10445764pfg.135.2023.02.05.03.33.20;
Sun, 05 Feb 2023 03:33:32 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linutronix.de header.s=2020 header.b="LKw/e55/";
dkim=neutral (no key) header.i=@linutronix.de header.b=t+dx30LQ;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229605AbjBELaA (ORCPT <rfc822;nicolai.engesland@gmail.com>
+ 99 others); Sun, 5 Feb 2023 06:30:00 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38978 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229585AbjBEL35 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sun, 5 Feb 2023 06:29:57 -0500
Received: from galois.linutronix.de (Galois.linutronix.de
[IPv6:2a0a:51c0:0:12e:550::1])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A956E1E5E6
for <linux-kernel@vger.kernel.org>;
Sun, 5 Feb 2023 03:29:55 -0800 (PST)
Date: Sun, 05 Feb 2023 11:29:52 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
s=2020; t=1675596592;
h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date:
message-id:message-id:to:to:cc:cc:mime-version:mime-version:
content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=mP3XJsTShQL14hAC+mnjW3TmxZmxPDuuvtQahw08qMo=;
b=LKw/e55/tpjYTJOaM0hxZcb1hJHTjblWzVlg82iMZARZgsmkoE79yJ0neH8HCmAwwBHKop
LwQ/eDW/gvF/NRwj2YAJjdd/S3YaRJ5oXrEraBX7A67NhHM/RIQcbg3oQ7BaAhm6jB0ZXG
2TjpGEGvZDPvMw7wOx1KwdMGuCh+ODGG56bNJNdlDsbt/Z8letS6/+TtrfBYuqFcYv7UmO
hq2LwXr5LYvmIWbotn8bxECwzLpuG+WdoXZBSAcDxcUxRQSpU+caJ8NiTiWEltNXBu0LLq
C18yqHnYEPAExpi7zX32t0RzQsNl+gMFpS9vOoXi+hExk79Oz0OrNNuIpZCieg==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
s=2020e; t=1675596592;
h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date:
message-id:message-id:to:to:cc:cc:mime-version:mime-version:
content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=mP3XJsTShQL14hAC+mnjW3TmxZmxPDuuvtQahw08qMo=;
b=t+dx30LQf4QZvBYHW4j4+u+Bo1QHI/pB3Lsyc1IAlVlp+aKQPdH4tQUoYMKjby1OZ96ID8
/VKxkmnFy2CxgEBA==
From: "irqchip-bot for Miaoqian Lin" <tip-bot2@linutronix.de>
Sender: tip-bot2@linutronix.de
Reply-to: linux-kernel@vger.kernel.org
To: linux-kernel@vger.kernel.org
Subject: [irqchip: irq/irqchip-next] irqchip/ti-sci: Fix refcount leak in
ti_sci_intr_irq_domain_probe
Cc: Miaoqian Lin <linmq006@gmail.com>, Marc Zyngier <maz@kernel.org>,
tglx@linutronix.de
In-Reply-To: <20230102085611.3955984-1-linmq006@gmail.com>
References: <20230102085611.3955984-1-linmq006@gmail.com>
MIME-Version: 1.0
Message-ID: <167559659238.4906.13590911560182651325.tip-bot2@tip-bot2>
Robot-ID: <tip-bot2@linutronix.de>
Robot-Unsubscribe: Contact <mailto:tglx@linutronix.de> to get blacklisted from
these emails
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1753900472863281876?=
X-GMAIL-MSGID: =?utf-8?q?1756990602962627683?=
|
| Series |
[irqchip:,irq/irqchip-next] irqchip/ti-sci: Fix refcount leak in ti_sci_intr_irq_domain_probe
|
|
Commit Message
tip-bot2 for Thomas Gleixner
Feb. 5, 2023, 11:29 a.m. UTC
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 02298b7bae12936ca313975b02e7f98b06670d37
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/02298b7bae12936ca313975b02e7f98b06670d37
Author: Miaoqian Lin <linmq006@gmail.com>
AuthorDate: Mon, 02 Jan 2023 12:56:10 +04:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Sun, 05 Feb 2023 11:11:24
irqchip/ti-sci: Fix refcount leak in ti_sci_intr_irq_domain_probe
of_irq_find_parent() returns a node pointer with refcount incremented,
We should use of_node_put() on it when not needed anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: cd844b0715ce ("irqchip/ti-sci-intr: Add support for Interrupt Router driver")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20230102085611.3955984-1-linmq006@gmail.com
---
drivers/irqchip/irq-ti-sci-intr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c index fe8fad2..020ddf2 100644 --- a/drivers/irqchip/irq-ti-sci-intr.c +++ b/drivers/irqchip/irq-ti-sci-intr.c @@ -236,6 +236,7 @@ static int ti_sci_intr_irq_domain_probe(struct platform_device *pdev) } parent_domain = irq_find_host(parent_node); + of_node_put(parent_node); if (!parent_domain) { dev_err(dev, "Failed to find IRQ parent domain\n"); return -ENODEV;