From patchwork Tue Jan 31 23:22:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Si-Wei Liu X-Patchwork-Id: 51083 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp90540wrn; Tue, 31 Jan 2023 15:24:37 -0800 (PST) X-Google-Smtp-Source: AK7set8NUsYtQ0jHjRoy8dU4z9LK9I77m6LUHfn5KV+Jsh8xHcnq6GzdQX0cN9hRppsNvYrCmGts X-Received: by 2002:a17:903:124c:b0:194:d664:be3a with SMTP id u12-20020a170903124c00b00194d664be3amr953899plh.16.1675207476978; Tue, 31 Jan 2023 15:24:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675207476; cv=none; d=google.com; s=arc-20160816; b=ucAg8a4HpK0lT6Bk0Wq6zLFLMg/GWQWKF0suZ5bUqYwzownRJEfM8XQ+DHD6RLLIPU NrdLZ4r0XIPm2aBabaZZJfsbbU/wgDCat98Q7rsyYOc+MTNY3N0aJ0YakzjRRN1uIHHs 1dqNC4sC3C984fuhP8ICbXdwqq8B/845v6B0xSM1Io/tYwo8mMJuKFK4cgyxLVNOfji1 PnuLg5dh8TI6QtCG7UQRyT3XKlqNEGeKG6MbsdXSG/udgGjjoaCTQrtlsduUZpsElpAe NBxX9bvoZE6uoUk2mDc0PylXlKoWJfNhMcd08S8i2xrz98muhSB/tlaZE3YUCOJoSz+B WbAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=r0Xf7HwYTIa5HdBeaweSNt2PODdB5AMoLanWqL4vsmE=; b=0UndgkuNHaA7Pjud2bMpXUOJgV2LSHP/1480zFlPDg2p0BOnpE0tft8s791OkEB6pi 30lwWj+zzEa605UJWXLBbzplu8oll6JrUyggTDVyZqccqEy+fPKubVzrwmO3q50ByzXj slbNuZXtCL8wFDripEe25zKDBtm949mURxcwJw73ZTQV2Ic4opigRaDVIdnRxsE/Erdk +1LR6jNh7enhAKkqWKTE6KMypEKw+ZCb+CKegsqun6y7hpm+GiBNS/HZ8qcH7JNsAsQJ GiJp9hwYK3sDDiegR5moKWRLn1COCFPhkQoGr8BDzTaH41IuT/VPTpUSzgLczuUoYBUy 3Qow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2022-7-12 header.b=BUnktRU2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w15-20020a1709027b8f00b00196263e2942si16515425pll.497.2023.01.31.15.24.25; Tue, 31 Jan 2023 15:24:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2022-7-12 header.b=BUnktRU2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232158AbjAaXWc (ORCPT + 99 others); Tue, 31 Jan 2023 18:22:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231825AbjAaXWa (ORCPT ); Tue, 31 Jan 2023 18:22:30 -0500 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B6C510421 for ; Tue, 31 Jan 2023 15:22:29 -0800 (PST) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30VIiH7A021428; Tue, 31 Jan 2023 23:22:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2022-7-12; bh=r0Xf7HwYTIa5HdBeaweSNt2PODdB5AMoLanWqL4vsmE=; b=BUnktRU2vwxC/uFjHpEvn6ISYNM1vWBs/qmac0ANisN6YzjgOuGQ1LvA3c/63h2fQ8l+ HXFba+DVS68CjBHXNkqXR1tVQ4atC3AIe3dIuU3CqFRe2vxLJlJmPxP7SVWePb1RyhMQ P7bJtVRBQjxwAr01OY8hVDqPIPp+AwyJHr3C9hibR+3rPkndTb2qiDZpAVlX+6uJw08C xOz6tsFB+X0+BiN/qxX2dGax/BbJjOGdDysiBdWkDezURD2MIfWnievjhi1BK3k8lHaD fnFILnVqej6Ww1nEIQUd2doXiGHpYHVbtI/+i0pUfme55QzczLT3A/xhamLatR12Vg2T PQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ncvr8q23c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 31 Jan 2023 23:22:25 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 30VMuk9L031540; Tue, 31 Jan 2023 23:22:24 GMT Received: from ban25x6uut24.us.oracle.com (ban25x6uut24.us.oracle.com [10.153.73.24]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTP id 3nct5d8c94-2; Tue, 31 Jan 2023 23:22:23 +0000 From: Si-Wei Liu To: mst@redhat.com, jasowang@redhat.com, parav@nvidia.com, elic@nvidia.com Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/6] vdpa: fix improper error message when adding vdpa dev Date: Tue, 31 Jan 2023 15:22:02 -0800 Message-Id: <1675207327-22289-2-git-send-email-si-wei.liu@oracle.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1675207327-22289-1-git-send-email-si-wei.liu@oracle.com> References: <1675207327-22289-1-git-send-email-si-wei.liu@oracle.com> X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-31_08,2023-01-31_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 suspectscore=0 adultscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301310201 X-Proofpoint-GUID: L0k5arDU938cX72WhdbrMRGjMC5w9dFr X-Proofpoint-ORIG-GUID: L0k5arDU938cX72WhdbrMRGjMC5w9dFr X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756582355398795927?= X-GMAIL-MSGID: =?utf-8?q?1756582355398795927?= In below example, before the fix, mtu attribute is supported by the parent mgmtdev, but the error message showing "All provided are not supported" is just misleading. $ vdpa mgmtdev show vdpasim_net: supported_classes net max_supported_vqs 3 dev_features MTU MAC CTRL_VQ CTRL_MAC_ADDR ANY_LAYOUT VERSION_1 ACCESS_PLATFORM $ vdpa dev add mgmtdev vdpasim_net name vdpasim0 mtu 5000 max_vqp 2 Error: vdpa: All provided attributes are not supported. kernel answers: Operation not supported After fix, the relevant error message will be like: $ vdpa dev add mgmtdev vdpasim_net name vdpasim0 mtu 5000 max_vqp 2 Error: vdpa: Some provided attributes are not supported. kernel answers: Operation not supported $ vdpa dev add mgmtdev vdpasim_net name vdpasim0 max_vqp 2 Error: vdpa: All provided attributes are not supported. kernel answers: Operation not supported Signed-off-by: Si-Wei Liu Acked-by: Jason Wang --- drivers/vdpa/vdpa.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c index 8ef7aa1..5e57935 100644 --- a/drivers/vdpa/vdpa.c +++ b/drivers/vdpa/vdpa.c @@ -622,13 +622,20 @@ static int vdpa_nl_cmd_dev_add_set_doit(struct sk_buff *skb, struct genl_info *i err = PTR_ERR(mdev); goto err; } - if ((config.mask & mdev->config_attr_mask) != config.mask) { + if (config.mask && (config.mask & mdev->config_attr_mask) == 0) { NL_SET_ERR_MSG_MOD(info->extack, "All provided attributes are not supported"); err = -EOPNOTSUPP; goto err; } + if ((config.mask & mdev->config_attr_mask) != config.mask) { + NL_SET_ERR_MSG_MOD(info->extack, + "Some provided attributes are not supported"); + err = -EOPNOTSUPP; + goto err; + } + err = mdev->ops->dev_add(mdev, name, &config); err: up_write(&vdpa_dev_lock);