From patchwork Thu Jan 19 01:22:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "zhaoyang.huang" X-Patchwork-Id: 45559 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp79979wrn; Wed, 18 Jan 2023 17:34:03 -0800 (PST) X-Google-Smtp-Source: AMrXdXvyFV7gke4pYquoNFInAyz3PrAaZqXZ9vLl0jujjLSWjSfEv2/cJdTEBFFfhwtBU1CpA4ce X-Received: by 2002:a17:903:2015:b0:194:8d2f:68f5 with SMTP id s21-20020a170903201500b001948d2f68f5mr8493838pla.17.1674092043379; Wed, 18 Jan 2023 17:34:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674092043; cv=none; d=google.com; s=arc-20160816; b=mIxQW1s0zaWjANmnuk+qK5MnhwR92sO1Dr6GQLcJQ4z2XGSfX3deRfO8Neb2qqqRd0 uYuZwtq/PXAFO/HsgrPG8ctjZMjp6hq8zKWtnG3g4eOf8eSnoaXm7nQxGba1CapjJ9bM MXzvrFclSiztrDtfnFXyoOYGpHaRDRSvCcGro5SbNB8pSRXNxxSgPQehPliVoceD7YGc fo/dqxaxsoiKX7/iQmVLNHeB4FabIQEA0u5rE8N4SUzhD2M36bs2+SVqrmsyxfTVGuiv mG5IJmFPfJP2Byz22T78wxsP/ecU8djyR4jhzJtQziy9ppM2V7dU7eer6SqEI/hrfrFm ZkAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:to:from; bh=jorMgqEQTOzxVCmiX8ybMmNHTugBay0HmFWGSRVJFk8=; b=Grt10yri9A+1CFGvRAHdfdzZqBsJowtK+V6GIXvzGy5IxObRGRGRYA8rTCTTgGdIAt wkHQwTyJX80fT/q19nuC6t0L5LlDTSYK649aaFd+WEyXn6QtX7PG/TfQrDTBHiITsXq+ oOibgPM9FX+40/3lRewjk/J9qiJXrM5GQB6e8TQbpafTaVbKB7nKk2wUaOtVZqF5Cuj8 4RjNpZygrdIVyLAw6LIJFvOKyThhIIjOXQmD3zHNwAxu+VVNZppsyJ7zQR6SYc7PqFkq CLu9NJWAaS7qoj2/BQozce1+E9dpDF26+GE5/WaapabTi71LF/gIrStPzG9UiWSFFImq x9Cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w4-20020a170902e88400b0018958008877si41494291plg.39.2023.01.18.17.33.51; Wed, 18 Jan 2023 17:34:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229689AbjASB32 (ORCPT + 99 others); Wed, 18 Jan 2023 20:29:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229976AbjASB21 (ORCPT ); Wed, 18 Jan 2023 20:28:27 -0500 Received: from SHSQR01.spreadtrum.com (unknown [222.66.158.135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0664B6D35C for ; Wed, 18 Jan 2023 17:23:02 -0800 (PST) Received: from SHSend.spreadtrum.com (bjmbx01.spreadtrum.com [10.0.64.7]) by SHSQR01.spreadtrum.com with ESMTP id 30J1Mu1A093179; Thu, 19 Jan 2023 09:22:56 +0800 (+08) (envelope-from zhaoyang.huang@unisoc.com) Received: from bj03382pcu.spreadtrum.com (10.0.74.65) by BJMBX01.spreadtrum.com (10.0.64.7) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Thu, 19 Jan 2023 09:22:54 +0800 From: "zhaoyang.huang" To: Andrew Morton , Catalin Marinas , Vlastimil Babka , "Nathan Chancellor" , Peter Zijlstra , Zhaoyang Huang , , , , Mirsad Todorovac Subject: [PATCHv4 2/2] mm: use stack_depot_early_init for kmemleak Date: Thu, 19 Jan 2023 09:22:25 +0800 Message-ID: <1674091345-14799-2-git-send-email-zhaoyang.huang@unisoc.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1674091345-14799-1-git-send-email-zhaoyang.huang@unisoc.com> References: <1674091345-14799-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 X-Originating-IP: [10.0.74.65] X-ClientProxiedBy: SHCAS01.spreadtrum.com (10.0.1.201) To BJMBX01.spreadtrum.com (10.0.64.7) X-MAIL: SHSQR01.spreadtrum.com 30J1Mu1A093179 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755412738678355116?= X-GMAIL-MSGID: =?utf-8?q?1755412738678355116?= From: Zhaoyang Huang Mirsad report bellow error which caused by stack_depot_init failed in kvcalloc. Solve this by having stackdepot use stack_depot_early_init. On 1/4/23 17:08, Mirsad Goran Todorovac wrote: I hate to bring bad news again, but there seems to be a problem with the output of /sys/kernel/debug/kmemleak: [root@pc-mtodorov ~]# cat /sys/kernel/debug/kmemleak unreferenced object 0xffff951c118568b0 (size 16): comm "kworker/u12:2", pid 56, jiffies 4294893952 (age 4356.548s) hex dump (first 16 bytes): 6d 65 6d 73 74 69 63 6b 30 00 00 00 00 00 00 00 memstick0....... backtrace: [root@pc-mtodorov ~]# Apparently, backtrace of called functions on the stack is no longer printed with the list of memory leaks. This appeared on Lenovo desktop 10TX000VCR, with AlmaLinux 8.7 and BIOS version M22KT49A (11/10/2022) and 6.2-rc1 and 6.2-rc2 builds. This worked on 6.1 with the same CONFIG_KMEMLEAK=y and MGLRU enabled on a vanilla mainstream kernel from Mr. Torvalds' tree. I don't know if this is deliberate feature for some reason or a bug. Please find attached the config, lshw and kmemleak output. reported-by: Mirsad Todorovac suggested-by: Vlastimil Babka Signed-off-by: Zhaoyang Huang Acked-by: Mike Rapoport (IBM) Acked-by: Catalin Marinas Acked-by: Vlastimil Babka --- v2: use stack_depot_want_early_init instead of CONFIG_STACKDEPOT_ALWAYS_INIT v3: have the Kconfig changes commited in another patch v4: select CONFIG_STACKDEPOT_ALWAYS_INIT when DEBUG_KMEMLEAK_DEFAULT_OFF is off --- Signed-off-by: Zhaoyang Huang --- mm/Kconfig.debug | 1 + mm/kmemleak.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug index d1893ac..466a37e 100644 --- a/mm/Kconfig.debug +++ b/mm/Kconfig.debug @@ -219,6 +219,7 @@ config DEBUG_KMEMLEAK select KALLSYMS select CRC32 select STACKDEPOT + select STACKDEPOT_ALWAYS_INIT if !DEBUG_KMEMLEAK_DEFAULT_OFF help Say Y here if you want to enable the memory leak detector. The memory allocation/freeing is traced in a way diff --git a/mm/kmemleak.c b/mm/kmemleak.c index 762b91f..ddc1ddf 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -2070,8 +2070,10 @@ static int __init kmemleak_boot_config(char *str) return -EINVAL; if (strcmp(str, "off") == 0) kmemleak_disable(); - else if (strcmp(str, "on") == 0) + else if (strcmp(str, "on") == 0) { kmemleak_skip_disable = 1; + stack_depot_want_early_init(); + } else return -EINVAL; return 0;