From patchwork Mon Jan 16 23:08:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 44355 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1447136wrn; Mon, 16 Jan 2023 15:11:50 -0800 (PST) X-Google-Smtp-Source: AMrXdXsXAKJSoNs/y+I2TL+DtBT7Ku+fLpf1kWhe1by3y/ZOkDI9nT8hkN4UJ+7zXjGkrq8niKgP X-Received: by 2002:a05:6402:174d:b0:49e:4b8:f6ab with SMTP id v13-20020a056402174d00b0049e04b8f6abmr926392edx.8.1673910709878; Mon, 16 Jan 2023 15:11:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673910709; cv=none; d=google.com; s=arc-20160816; b=L0Nxv0QLUsL+h42nQgrp0HoDCWXySGCx5UlbCFB0DCHbxHslQ8EDJ6B1jafHmT//ou stdFZPomE9F8Ld3kZXQ43+V73uvq/pUwOuPeQberGvhDAmTNq85u8/pvo/PN9vA7ycgj FAxblBx5VmIL0vMfEAQJ83CqTXwCQZrmYGo+tcPMT+Wd2BkzbhqAw4IVfZZasepxFp8r gndizNx9i8kbxEZL/HqJHBkA7wJ3E7ImgrRESXiZPPxn9kSuV3FpqBPdgYmiMu2gF0Sn 4fEStnrwYzVYOwSNx+rYQs10Q18P4sDSf0UB4yJghQbY2dOJE4c+98FQzpJfPqvhwYBr OYnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:organization:dkim-signature; bh=AXGRyxrMRjzyNrjh13JZHEue2NHbrOxKU/9FUI9urUA=; b=vWkSDauifgtcH3BJDaWpWibnZujEkpPSKia/1ZHq4VIcRckoRHVyGrodrS6BI0q+JU 8ps/RpolFQtM7hULuYnJN7LMJrDH3tKNEpfZy3ZnCh21MmckNX6YF8vAsILV5ZVAQc2k owqJI6CvBn4FtFKBYH9aPfQT1LFm/4/M/MS0pDgV8yFR+X6DkaTyD+5OyLkLREfWBQvQ 8iZ8gqUnnSeDVUjRBmjZbQzdwghrrPv22FUYCzjdX7DiOEW/ZRvPknfVWJO9U0Cf4O9r n/Xm6J0REJgHywk0M49cMZjJChvo/c9L7buu7FxUSL3+SEsbW5Q+gX611ehtDoCLOaMb MxIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="ZC7InEO/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gt20-20020a1709072d9400b00866e7c0ae3esi16440949ejc.827.2023.01.16.15.11.25; Mon, 16 Jan 2023 15:11:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="ZC7InEO/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232684AbjAPXKZ (ORCPT + 99 others); Mon, 16 Jan 2023 18:10:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235209AbjAPXJf (ORCPT ); Mon, 16 Jan 2023 18:09:35 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 581C522DF6 for ; Mon, 16 Jan 2023 15:08:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673910523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AXGRyxrMRjzyNrjh13JZHEue2NHbrOxKU/9FUI9urUA=; b=ZC7InEO/20UsqM0wBy8uaRx85t+cfUfrCHKKj6O1jmLnveFzqho8dHi7n1gQi+Isk/grRx lY0oetTprlRoXGsgwd16e5iQ5+3l9GV7rBG2R5R9TsshNy5DBt7MB1ynIja9902MGOHPtI 56IjfJBhy+rP7LBTq/6+lK7fH0rDQ4U= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-661-49nb9eXwM3SfZlrM7W4EnA-1; Mon, 16 Jan 2023 18:08:40 -0500 X-MC-Unique: 49nb9eXwM3SfZlrM7W4EnA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CE2282A59556; Mon, 16 Jan 2023 23:08:39 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id A01352166B26; Mon, 16 Jan 2023 23:08:38 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Subject: [PATCH v6 05/34] iov_iter: Change the direction macros into an enum From: David Howells To: Al Viro Cc: dhowells@redhat.com, Christoph Hellwig , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 16 Jan 2023 23:08:38 +0000 Message-ID: <167391051810.2311931.8545361041888737395.stgit@warthog.procyon.org.uk> In-Reply-To: <167391047703.2311931.8115712773222260073.stgit@warthog.procyon.org.uk> References: <167391047703.2311931.8115712773222260073.stgit@warthog.procyon.org.uk> User-Agent: StGit/1.5 MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755222596896657174?= X-GMAIL-MSGID: =?utf-8?q?1755222596896657174?= Change the ITER_SOURCE and ITER_DEST direction macros into an enum and provide three new helper functions: iov_iter_dir() - returns the iterator direction iov_iter_is_dest() - returns true if it's an ITER_DEST iterator iov_iter_is_source() - returns true if it's an ITER_SOURCE iterator Signed-off-by: David Howells cc: Al Viro Link: https://lore.kernel.org/r/167305161763.1521586.6593798818336440133.stgit@warthog.procyon.org.uk/ # v4 Link: https://lore.kernel.org/r/167344726413.2425628.317218805692680763.stgit@warthog.procyon.org.uk/ # v5 --- include/linux/uio.h | 30 ++++++++++++++++++++++++++---- 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/include/linux/uio.h b/include/linux/uio.h index 365e26c405f2..8d0dabfcb2fe 100644 --- a/include/linux/uio.h +++ b/include/linux/uio.h @@ -29,8 +29,10 @@ enum iter_type { ITER_UBUF, }; -#define ITER_SOURCE 1 // == WRITE -#define ITER_DEST 0 // == READ +enum iter_dir { + ITER_DEST = 0, // == READ + ITER_SOURCE = 1, // == WRITE +} __mode(byte); struct iov_iter_state { size_t iov_offset; @@ -39,9 +41,9 @@ struct iov_iter_state { }; struct iov_iter { - u8 iter_type; + enum iter_type iter_type __mode(byte); bool nofault; - bool data_source; + enum iter_dir data_source; bool user_backed; union { size_t iov_offset; @@ -114,6 +116,26 @@ static inline bool iov_iter_is_xarray(const struct iov_iter *i) return iov_iter_type(i) == ITER_XARRAY; } +static inline enum iter_dir iov_iter_dir(const struct iov_iter *i) +{ + return i->data_source; +} + +static inline bool iov_iter_is_source(const struct iov_iter *i) +{ + return iov_iter_dir(i) == ITER_SOURCE; /* ie. WRITE */ +} + +static inline bool iov_iter_is_dest(const struct iov_iter *i) +{ + return iov_iter_dir(i) == ITER_DEST; /* ie. READ */ +} + +static inline bool iov_iter_dir_valid(enum iter_dir direction) +{ + return direction == ITER_DEST || direction == ITER_SOURCE; +} + static inline bool user_backed_iter(const struct iov_iter *i) { return i->user_backed;