From patchwork Mon Jan 16 23:08:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 44352 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1446800wrn; Mon, 16 Jan 2023 15:10:49 -0800 (PST) X-Google-Smtp-Source: AMrXdXv79gP/rW+UIdcG+W2G/yhK5K9s452DpWDgBKyintSe+qL4Z01quL69Cj7PSEG/WEeClySQ X-Received: by 2002:a05:6402:5110:b0:49d:fff2:d4d7 with SMTP id m16-20020a056402511000b0049dfff2d4d7mr1122547edd.30.1673910649250; Mon, 16 Jan 2023 15:10:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673910649; cv=none; d=google.com; s=arc-20160816; b=WvTOYyjoTf4uHvys+7myZrUgvjeWCwtPfacKAtAhdijEm8hbQcgfs4nroXcgb2bjWg pvb5oH4A8H6rdW67vFU2+OXmRZ5N7bDS6CqJgAUfofgcoSAnvYMonGxh8maSLVKpzuC8 u36XM72jROPW35yMs3MF39m1IqJSSIwAvJdky+gkzn7JjN04j2CEAES0XY5YXuaTH/tc D0mphHTCR6Xbgy5wGmKxmSolK0h/WBJ672xr5SNMzOPkN3NBLEVhErn7n8gWWrkmdr8G mha2AOJhfLUo6RpSJT85M6kPV+SCZrjYFF7w2R/4xTt3vK5lliMogQcu9Y8dRTJIwLUY BOjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:organization:dkim-signature; bh=U7dHEM5AmzKgzCCEEdwyvVJA92oDXUOBOpHeITrEM9k=; b=W0ZCPa/uvl0wCCIQQhdZHdBr3z5mICeKw82Qd3ubxHp13/ls27xN3tE888geedc2TY Lm1gP7dUZVoOJjKpBPQyukvRskT1I4ay92BYQQpInWPB+1n8rQq4VPJczAuse12Sr6sy PupOXyjjb37NbhHoFYYdxND3sprNMA7x8ZJ1yrOFIY81T9Vub1MtzyvWRuW6oTMDCKMZ pUc3eTQvvcaMqbpeCn2DQLqH6D353qO3nevjEXSBn0zD9JoFd2tRIa6uTeN6E71wyTun Io/0fpGez936nsQI08iiY2HOphgKA1Kmx9EVKCKWaABck3qvVCC1oEI+Pjatjn/Elbau ZysQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SebS2ZJ5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j20-20020a05640211d400b0047db5ff4936si2046833edw.490.2023.01.16.15.10.25; Mon, 16 Jan 2023 15:10:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SebS2ZJ5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235175AbjAPXJn (ORCPT + 99 others); Mon, 16 Jan 2023 18:09:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235196AbjAPXJG (ORCPT ); Mon, 16 Jan 2023 18:09:06 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A59C722032 for ; Mon, 16 Jan 2023 15:08:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673910497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U7dHEM5AmzKgzCCEEdwyvVJA92oDXUOBOpHeITrEM9k=; b=SebS2ZJ5nIMKTlmgSs5/X8GGIt2lkmWBsgRyl4+aqtEYTK8lFKkzfISV1WgkRF+4R0KbCh xr5/VFa+1hWgFFBiep47MVwNbTzaR6mECGJo3EL90kNE8r76eVDUPw9aV8z//2w22xXR/x cr6Nd2a+LvpgCgBU5AlhvYPSqP50W2A= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-574-m8_Zm0OtPyCt81uCEzo9Ig-1; Mon, 16 Jan 2023 18:08:12 -0500 X-MC-Unique: m8_Zm0OtPyCt81uCEzo9Ig-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CE7FB101A52E; Mon, 16 Jan 2023 23:08:11 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7D3F9492B00; Mon, 16 Jan 2023 23:08:10 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Subject: [PATCH v6 01/34] vfs: Unconditionally set IOCB_WRITE in call_write_iter() From: David Howells To: Al Viro Cc: Christoph Hellwig , Jens Axboe , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, dhowells@redhat.com, Christoph Hellwig , Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 16 Jan 2023 23:08:09 +0000 Message-ID: <167391048988.2311931.1567396746365286847.stgit@warthog.procyon.org.uk> In-Reply-To: <167391047703.2311931.8115712773222260073.stgit@warthog.procyon.org.uk> References: <167391047703.2311931.8115712773222260073.stgit@warthog.procyon.org.uk> User-Agent: StGit/1.5 MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755222532591891773?= X-GMAIL-MSGID: =?utf-8?q?1755222532591891773?= IOCB_WRITE is set by aio, io_uring and cachefiles before submitting a write operation to the VFS, but it isn't set by, say, the write() system call. Fix this by setting IOCB_WRITE unconditionally in call_write_iter(). This will allow drivers to use IOCB_WRITE instead of the iterator data source to determine the I/O direction. Signed-off-by: David Howells cc: Alexander Viro cc: Christoph Hellwig cc: Jens Axboe cc: linux-block@vger.kernel.org cc: linux-fsdevel@vger.kernel.org --- include/linux/fs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/fs.h b/include/linux/fs.h index 066555ad1bf8..649ff061440e 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -2183,6 +2183,7 @@ static inline ssize_t call_read_iter(struct file *file, struct kiocb *kio, static inline ssize_t call_write_iter(struct file *file, struct kiocb *kio, struct iov_iter *iter) { + kio->ki_flags |= IOCB_WRITE; return file->f_op->write_iter(kio, iter); }