diff mbox series

[bpf-next] samples: bpf: Use "grep -E" instead of "egrep"

Message ID 1668765001-12477-1-git-send-email-yangtiezhu@loongson.cn
State New
Headers
Series [bpf-next] samples: bpf: Use "grep -E" instead of "egrep" |

Commit Message

Tiezhu Yang Nov. 18, 2022, 9:50 a.m. UTC 
  The latest version of grep claims the egrep is now obsolete so the build
now contains warnings that look like:
	egrep: warning: egrep is obsolescent; using grep -E
fix this up by moving the related file to use "grep -E" instead.

  sed -i "s/egrep/grep -E/g" `grep egrep -rwl samples/bpf`

Here are the steps to install the latest grep:

  wget http://ftp.gnu.org/gnu/grep/grep-3.8.tar.gz
  tar xf grep-3.8.tar.gz
  cd grep-3.8 && ./configure && make
  sudo make install
  export PATH=/usr/local/bin:$PATH

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 samples/bpf/test_cgrp2_tc.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jiri Olsa Nov. 18, 2022, 10:28 a.m. UTC | #1 
On Fri, Nov 18, 2022 at 05:50:01PM +0800, Tiezhu Yang wrote:
> The latest version of grep claims the egrep is now obsolete so the build
> now contains warnings that look like:
> 	egrep: warning: egrep is obsolescent; using grep -E
> fix this up by moving the related file to use "grep -E" instead.
> 
>   sed -i "s/egrep/grep -E/g" `grep egrep -rwl samples/bpf`
> 
> Here are the steps to install the latest grep:
> 
>   wget http://ftp.gnu.org/gnu/grep/grep-3.8.tar.gz
>   tar xf grep-3.8.tar.gz
>   cd grep-3.8 && ./configure && make
>   sudo make install
>   export PATH=/usr/local/bin:$PATH
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

Acked-by: Jiri Olsa <jolsa@kernel.org>

jirka

> ---
>  samples/bpf/test_cgrp2_tc.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/samples/bpf/test_cgrp2_tc.sh b/samples/bpf/test_cgrp2_tc.sh
> index 12faf58..395573b 100755
> --- a/samples/bpf/test_cgrp2_tc.sh
> +++ b/samples/bpf/test_cgrp2_tc.sh
> @@ -115,7 +115,7 @@ do_exit() {
>      if [ "$DEBUG" == "yes" ] && [ "$MODE" != 'cleanuponly' ]
>      then
>  	echo "------ DEBUG ------"
> -	echo "mount: "; mount | egrep '(cgroup2|bpf)'; echo
> +	echo "mount: "; mount | grep -E '(cgroup2|bpf)'; echo
>  	echo "$CGRP2_TC_LEAF: "; ls -l $CGRP2_TC_LEAF; echo
>  	if [ -d "$BPF_FS_TC_SHARE" ]
>  	then
> -- 
> 2.1.0
>
patchwork-bot+netdevbpf@kernel.org Nov. 18, 2022, 11 p.m. UTC | #2 
Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Fri, 18 Nov 2022 17:50:01 +0800 you wrote:
> The latest version of grep claims the egrep is now obsolete so the build
> now contains warnings that look like:
> 	egrep: warning: egrep is obsolescent; using grep -E
> fix this up by moving the related file to use "grep -E" instead.
> 
>   sed -i "s/egrep/grep -E/g" `grep egrep -rwl samples/bpf`
> 
> [...]

Here is the summary with links:
  - [bpf-next] samples: bpf: Use "grep -E" instead of "egrep"
    https://git.kernel.org/bpf/bpf-next/c/ee748cd95e3a

You are awesome, thank you!
diff mbox series

Patch

diff --git a/samples/bpf/test_cgrp2_tc.sh b/samples/bpf/test_cgrp2_tc.sh
index 12faf58..395573b 100755
--- a/samples/bpf/test_cgrp2_tc.sh
+++ b/samples/bpf/test_cgrp2_tc.sh
@@ -115,7 +115,7 @@  do_exit() {
     if [ "$DEBUG" == "yes" ] && [ "$MODE" != 'cleanuponly' ]
     then
 	echo "------ DEBUG ------"
-	echo "mount: "; mount | egrep '(cgroup2|bpf)'; echo
+	echo "mount: "; mount | grep -E '(cgroup2|bpf)'; echo
 	echo "$CGRP2_TC_LEAF: "; ls -l $CGRP2_TC_LEAF; echo
 	if [ -d "$BPF_FS_TC_SHARE" ]
 	then