From patchwork Mon Oct 17 22:27:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Moger, Babu" X-Patchwork-Id: 3781 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp1669885wrs; Mon, 17 Oct 2022 15:30:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5o+YEKNdJ7S0fM1s0+O8DoFechTEu/jbcXADvdJGJmtXfkTArzJwXVpWrEKKAq7JO0uVJx X-Received: by 2002:a17:902:f786:b0:180:6f9e:23b with SMTP id q6-20020a170902f78600b001806f9e023bmr76460pln.37.1666045825366; Mon, 17 Oct 2022 15:30:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1666045825; cv=pass; d=google.com; s=arc-20160816; b=XIE9aasDZksqcPn4WVXXxiXnneAj8hmkvF/qdIYa3FOV6p5CSADODfw23oL+ZDBIz/ oPQ3wlVvqlkpw0q7J21KbsaR1XMn8sVcdKAuI/5a34MX4peEamHpRqdkd2RRdRZjm7jh Hml0aNUp5rfS7WSNQPMD8iNdbgb5l8IEkQ32eUusQhJpO2tplrZamyJNFwsn6WbeaFSq baFPsO/WjjW7mHpLGjRYZvYlvhIPAIj9QWDexWZof+3dcaDYUgUnitI7aibryiOBrsv8 jts7XkiDZkmVhoHTBox2P4u9/dGWw42uL39Yqazq50WxlO4Xtxnh6B5KGi08X2w6swgy sJPw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:dkim-signature; bh=6bv7CzDbWswhhZMyEbNoAAkCOs7/1eJj6H82m1ZpCyk=; b=UHzB+XNZjGTvoSoAhy12yhrgcAYqsac6P9e0wWplq5v+UKZP4AG1agJU3LG1RIWO6w QAioCWT17Osf7Vbz9cGiFtmV+eNTNg24t/eMoXzoK4UFA+sBx3mapDrOVhlMQnrowd7V ATtP/UUSz0nvb5PxFF/bEZNvICTcCuluL+LVsGGBocgPsaTimw8DPUJgvdPbLnFbSQzR u8Gy+GhuIEOdRVv1GAZF1bHutRrulxHbT6MV7t2SnVgdBmxztmxsyFmwwMyUtycX3i/v 933W+yi0epAkVOtjD7WMYtJn+cGgW7c6cj5rGUQmPxL1kLSwYNlMXPwH5NvOBY7hseyb ByKQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=jGT2zPT+; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s9-20020a170902b18900b0016dc27fb9fbsi12444169plr.117.2022.10.17.15.30.12; Mon, 17 Oct 2022 15:30:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=jGT2zPT+; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230177AbiJQW2e (ORCPT + 99 others); Mon, 17 Oct 2022 18:28:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229969AbiJQW2b (ORCPT ); Mon, 17 Oct 2022 18:28:31 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2049.outbound.protection.outlook.com [40.107.223.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DAA2814D9; Mon, 17 Oct 2022 15:28:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zd/03qZCTNPpAEgVNW0D6JJVc13Eglc+Ul+J3SUZgVo8yXeEfaQKqLzQzi+/PnPCJ7Fex5TBRJLVlgGs65U27SWjKOA4+ADp5orcO/lYb9jrmBKkIpF3k0Lj2CilIFbdA1GBunOfzDuvd4dOG//TOTYqWPnael4m6+UnaY+ew8BPj9HXRnm/PaVHHA5z2HYdzqlI9A4VtAJAWS70kFM71yBLnkwdM1vQYKen9t8c34z49wDVNXwr/xEhI06iQ78pn5d8nN5SPSUYL2SVJOgF1t/QZy0oT+KU8j4/AL2ZYhAUJ/SwBvfYowq8TG4ykW5LdDRITJJjR34cp7VRBufEtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6bv7CzDbWswhhZMyEbNoAAkCOs7/1eJj6H82m1ZpCyk=; b=oJHO/0JLQxzSww0PSZhbKWiv82zqCfakLhLVB4NmwtEoTnpd5eSTA5indjnr9NV27spQ26K4HQaxtPQjFtD+xW2iHQ0gj9Zh2VNcfDVlcdL67NNpElzsbTGcLT3aLwTVNXgB65XIH0kFhq1rlvb8+vAOtIa8zwf0ipFmNX8BYOsum6f2vyv3pcKCjh2ptLnz3yPNP5qGVUkMv680EUs4VCCZ/Pfx6ehC8aoQPfE74zmspHz8N1CcQ2M3c3fubvexraW66fUljIWjRrSY4xo9VYoqh0zKs0Vn2pDUVos7sA7qE0YNsVxZKajecdpc397RTBSH8RH60+DazsO5XII8LQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=alien8.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6bv7CzDbWswhhZMyEbNoAAkCOs7/1eJj6H82m1ZpCyk=; b=jGT2zPT+KnEbsRtpCqKrbodjo1EshqcUWmOTXxW4rFgwfgIdeeRXLCshX8vmXg4RV+4olF4SVcXvhR4WIcok5T4PdIDQUHjlmmi4uUF5Vh0Azaytfjo3MKAFgd0n4kiDNR/bn4wgP2RFFWuezBeS+hw3oafVfMBBMd6+JGHgg4A= Received: from BN8PR04CA0064.namprd04.prod.outlook.com (2603:10b6:408:d4::38) by BL1PR12MB5222.namprd12.prod.outlook.com (2603:10b6:208:31e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Mon, 17 Oct 2022 22:27:15 +0000 Received: from BN8NAM11FT086.eop-nam11.prod.protection.outlook.com (2603:10b6:408:d4:cafe::9e) by BN8PR04CA0064.outlook.office365.com (2603:10b6:408:d4::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24 via Frontend Transport; Mon, 17 Oct 2022 22:27:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT086.mail.protection.outlook.com (10.13.176.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5723.20 via Frontend Transport; Mon, 17 Oct 2022 22:27:15 +0000 Received: from [127.0.1.1] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 17:27:13 -0500 Subject: [PATCH v7 09/12] x86/resctrl: Add sysfs interface to write mbm_total_bytes event configuration From: Babu Moger To: , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , Date: Mon, 17 Oct 2022 17:27:13 -0500 Message-ID: <166604563304.5345.2402589906956965706.stgit@bmoger-ubuntu> In-Reply-To: <166604543832.5345.9696970469830919982.stgit@bmoger-ubuntu> References: <166604543832.5345.9696970469830919982.stgit@bmoger-ubuntu> User-Agent: StGit/1.1.dev103+g5369f4c MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT086:EE_|BL1PR12MB5222:EE_ X-MS-Office365-Filtering-Correlation-Id: ac366786-2979-423a-1cfb-08dab08ebea9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8QclPc0lSZWBi1OPFJ79Ni1i+cF0TeY09XyAenS+5l5tFzJwnbVr7oyBpmCvfDrLj7aGCXiOgHfl0+tiwwuKHxAlPGJjG46NXdeOaWkcEPmTHz8f1/0H9GNL//E1HyYdtWvE76AFygQ9pgBeQPEJzyVfqVyRCFHhEnWwVnL2UF3X9cAbPIXd5kplP+XPD7qBTVhvWgEPKfBcIif9l+Tw+NNOr0Z3c+3hFFCHK/9czs0Gpnvl4Yzp5IQvhNo4yxyhHvo3lgKLmTZpFNFaO7Zo26Mbrf6MTmnOaD7bBKECf/mehjMOeUwH8qDo9wOMNT6RrLpMDcibIexSK3RgHW9m1PI++cheZVagOfJvirSMbyoA4NF+kQuowmVItejfjNFrIC7jDsCw1j2CSVVlImnM4RjVQZbxxjP+j9hzO8IhZEjXrA0YAQnGtDiKIWfHR32reA69Up1ZxhvM5q9B7O9/VelMHyAUrmXx09aP56FCpogx1ItEs8o0BRlTScC+4K53nV1cxGFuLsS3h3MEHHDL5wXr0MtzPLxmmLPEwuqwz92XMqRluMbpMZEBFOQUViHnsAQQa7O6L9oQLcTCqrTGPiISpd1NQ7qpHqyr5l67j4drbHB1WvRrHYhrx67qE38wltPlIH2PtTD07xO+8GMWxBES1gZ7HSzzvXuRdjv8KcNCP1bGMlG7AZOGLIcJC46kmrs4BjLIi+VcHLvb4Fy4ua92vJlT2Vy/qRFXTmRR2qicSUTeZitng5kUAv7Lemxxmb785BvnyNp7d86/wLXneREWOdWnJvFFJchTlYCNv7a0ZT+v8tu0Y0RndklaLJJs1bB4GjvexVy7GJNcatufqQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(7916004)(346002)(136003)(396003)(39860400002)(376002)(451199015)(46966006)(40470700004)(36840700001)(16576012)(316002)(110136005)(186003)(40460700003)(44832011)(103116003)(4326008)(54906003)(2906002)(26005)(8936002)(16526019)(41300700001)(86362001)(83380400001)(9686003)(7416002)(336012)(70206006)(70586007)(426003)(47076005)(40480700001)(8676002)(5660300002)(82740400003)(33716001)(82310400005)(36860700001)(356005)(81166007)(478600001)(71626007)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 22:27:15.6476 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ac366786-2979-423a-1cfb-08dab08ebea9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT086.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5222 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746975667533851255?= X-GMAIL-MSGID: =?utf-8?q?1746975667533851255?= The current event configuration can be changed by the user by writing to the configuration file /sys/fs/resctrl/info/L3_MON/mbm_total_config. The event configuration settings are domain specific and will affect all the CPUs in the domain. Following are the types of events supported: ==== =========================================================== Bits Description ==== =========================================================== 6 Dirty Victims from the QOS domain to all types of memory 5 Reads to slow memory in the non-local NUMA domain 4 Reads to slow memory in the local NUMA domain 3 Non-temporal writes to non-local NUMA domain 2 Non-temporal writes to local NUMA domain 1 Reads to memory in the non-local NUMA domain 0 Reads to memory in the local NUMA domain ==== =========================================================== For example: To change the mbm_total_bytes to count only reads on domain 0, the bits 0, 1, 4 and 5 needs to be set, which is 110011b (in hex 0x33). Run the command. $echo 0=0x33 > /sys/fs/resctrl/info/L3_MON/mbm_total_config To change the mbm_total_bytes to count all the slow memory reads on domain 1, the bits 4 and 5 needs to be set which is 110000b (in hex 0x30). Run the command. $echo 1=0x30 > /sys/fs/resctrl/info/L3_MON/mbm_total_config Signed-off-by: Babu Moger --- arch/x86/kernel/cpu/resctrl/internal.h | 23 +++++ arch/x86/kernel/cpu/resctrl/rdtgroup.c | 146 ++++++++++++++++++++++++++++++++ 2 files changed, 169 insertions(+) diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h index 326a1b582f38..c42b12934a0e 100644 --- a/arch/x86/kernel/cpu/resctrl/internal.h +++ b/arch/x86/kernel/cpu/resctrl/internal.h @@ -42,6 +42,29 @@ */ #define MBM_CNTR_WIDTH_OFFSET_MAX (62 - MBM_CNTR_WIDTH_BASE) +/* Reads to Local DRAM Memory */ +#define READS_TO_LOCAL_MEM BIT(0) + +/* Reads to Remote DRAM Memory */ +#define READS_TO_REMOTE_MEM BIT(1) + +/* Non-Temporal Writes to Local Memory */ +#define NON_TEMP_WRITE_TO_LOCAL_MEM BIT(2) + +/* Non-Temporal Writes to Remote Memory */ +#define NON_TEMP_WRITE_TO_REMOTE_MEM BIT(3) + +/* Reads to Local Memory the system identifies as "Slow Memory" */ +#define READS_TO_LOCAL_S_MEM BIT(4) + +/* Reads to Remote Memory the system identifies as "Slow Memory" */ +#define READS_TO_REMOTE_S_MEM BIT(5) + +/* Dirty Victims to All Types of Memory */ +#define DIRTY_VICTIMS_TO_ALL_MEM BIT(6) + +/* Max event bits supported */ +#define MAX_EVT_CONFIG_BITS GENMASK(6, 0) struct rdt_fs_context { struct kernfs_fs_context kfc; diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c index 305fb0475970..25ff56ecb817 100644 --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c @@ -1494,6 +1494,151 @@ static int mbm_local_config_show(struct kernfs_open_file *of, return 0; } +static void mon_event_config_write(void *info) +{ + struct mon_config_info *mon_info = info; + u32 msr_index; + + switch (mon_info->evtid) { + case QOS_L3_MBM_TOTAL_EVENT_ID: + msr_index = 0; + break; + case QOS_L3_MBM_LOCAL_EVENT_ID: + msr_index = 1; + break; + default: + /* Not expected to come here */ + return; + } + + wrmsr(MSR_IA32_EVT_CFG_BASE + msr_index, mon_info->mon_config, 0); +} + +static int mbm_config_write(struct rdt_resource *r, struct rdt_domain *d, + u32 evtid, u32 val) +{ + struct mon_config_info mon_info = {0}; + cpumask_var_t cpu_mask; + int ret = 0, cpu; + + rdt_last_cmd_clear(); + + /* mon_config cannot be more than the supported set of events */ + if (val > MAX_EVT_CONFIG_BITS) { + rdt_last_cmd_puts("Invalid event configuration\n"); + return -EINVAL; + } + + cpus_read_lock(); + + if (!zalloc_cpumask_var(&cpu_mask, GFP_KERNEL)) { + rdt_last_cmd_puts("cpu_mask allocation failed\n"); + ret = -ENOMEM; + goto e_unlock; + } + + /* + * Read the current config value first. If both are same then + * we dont need to write it again. + */ + mon_info.evtid = evtid; + mondata_config_read(d, &mon_info); + if (mon_info.mon_config == val) + goto e_cpumask; + + mon_info.mon_config = val; + + /* Pick all the CPUs in the domain instance */ + for_each_cpu(cpu, &d->cpu_mask) + cpumask_set_cpu(cpu, cpu_mask); + + /* + * Update MSR_IA32_EVT_CFG_BASE MSRs on all the CPUs in + * cpu_mask. The MSRs offset from MSR MSR_IA32_EVT_CFG_BASE + * are scoped at the domain level. Writing any of these MSRs + * on one CPU is supposed to be observed by all CPUs in the + * domain. However, the hardware team recommends to update + * these MSRs on all the CPUs in the domain. + */ + on_each_cpu_mask(cpu_mask, mon_event_config_write, &mon_info, 1); + + /* + * When an Event Configuration is changed, the bandwidth counters + * for all RMIDs and Events will be cleared by the hardware. The + * hardware also sets MSR_IA32_QM_CTR.Unavailable (bit 62) for + * every RMID on the next read to any event for every RMID. + * Subsequent reads will have MSR_IA32_QM_CTR.Unavailable (bit 62) + * cleared while it is tracked by the hardware. Clear the + * mbm_local and mbm_total counts for all the RMIDs. + */ + memset(d->mbm_local, 0, sizeof(struct mbm_state) * r->num_rmid); + memset(d->mbm_total, 0, sizeof(struct mbm_state) * r->num_rmid); + +e_cpumask: + free_cpumask_var(cpu_mask); + +e_unlock: + cpus_read_unlock(); + + return ret; +} + +static int mon_config_parse(struct rdt_resource *r, char *tok, u32 evtid) +{ + char *dom_str = NULL, *id_str; + struct rdt_domain *d; + unsigned long dom_id, val; + int ret = 0; + +next: + if (!tok || tok[0] == '\0') + return 0; + + /* Start processing the strings for each domain */ + dom_str = strim(strsep(&tok, ";")); + id_str = strsep(&dom_str, "="); + + if (!dom_str || kstrtoul(id_str, 10, &dom_id)) { + rdt_last_cmd_puts("Missing '=' or non-numeric domain id\n"); + return -EINVAL; + } + + if (!dom_str || kstrtoul(dom_str, 16, &val)) { + rdt_last_cmd_puts("Missing '=' or non-numeric event configuration value\n"); + return -EINVAL; + } + + list_for_each_entry(d, &r->domains, list) { + if (d->id == dom_id) { + ret = mbm_config_write(r, d, evtid, val); + if (ret) + return -EINVAL; + goto next; + } + } + + return -EINVAL; +} + +static ssize_t mbm_total_config_write(struct kernfs_open_file *of, + char *buf, size_t nbytes, loff_t off) +{ + struct rdt_resource *r = of->kn->parent->priv; + int ret; + + /* Valid input requires a trailing newline */ + if (nbytes == 0 || buf[nbytes - 1] != '\n') + return -EINVAL; + + rdt_last_cmd_clear(); + + buf[nbytes - 1] = '\0'; + + ret = mon_config_parse(r, buf, QOS_L3_MBM_TOTAL_EVENT_ID); + + return ret ?: nbytes; +} + /* rdtgroup information files for one cache resource. */ static struct rftype res_common_files[] = { { @@ -1597,6 +1742,7 @@ static struct rftype res_common_files[] = { .mode = 0644, .kf_ops = &rdtgroup_kf_single_ops, .seq_show = mbm_total_config_show, + .write = mbm_total_config_write, }, { .name = "mbm_local_config",