From patchwork Thu Oct 13 18:29:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saurabh Singh Sengar X-Patchwork-Id: 2299 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp428389wrs; Thu, 13 Oct 2022 11:51:49 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7zu5g35BRT2DFc1Uxe5l2jaIpyyp6AnXi3D9guyRQdbRF7VaVTUGu0J/56KHg7Np7H4+2x X-Received: by 2002:a17:903:200a:b0:181:75fc:e0c6 with SMTP id s10-20020a170903200a00b0018175fce0c6mr1118752pla.93.1665687109163; Thu, 13 Oct 2022 11:51:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665687109; cv=none; d=google.com; s=arc-20160816; b=DCE4FnyoEb4BIssl/fWUx5J3q0PrwSS6MVGCXRmafjK9zJ6yK6uCZZyxqucWFNkssP wV9mIVLa1UU4TtQrth1Ca8Bm3IUQNI1LXlO9uhvabqThkxFO/sx//cn7fw07Lpo9vhO4 bOgje5doboXNuNx47fYTNcjNgKSNEjsV4xptXN1Lp1JjVUdkGnOYDSSQoKbkp2PboBeE YVkEqcQ7N1HUWFULFEVfMF2jSGIlptpENVCA22b2knTase2W5D5t2cz5yeqdMBxaPYj0 3/2jsTfBaSyyK/DGuKC1+n3Um5B8hoG1eIiNt0BDDLPTrddQ6C1ZUiEH/LZRdc0zlu/q nK0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:to:from:dkim-signature :dkim-filter; bh=LEICLpqkAHA55SgqSRkWd7Q239A6x6Ah2FjEDgwjgI4=; b=y/DtFQtZxnw8WyyYpIvO4LKqGXcIan++bipPdDDS6P7lgz16p70WZel+SXh8D9xbVd qpYyLZ+rzXAb6GmIf0EbqER8xQy8yCOuQCjHudNfb66WbyNVjv0MK0c39SFsjlHOGQPD MS1CyUX9G9+wykkAVFE3RlTKjRK/HTq6kPUkQhAvqt1O4tkU2/3z5y3YIew/ihC/8+Uo s/PJ23+PD8lYtwMRGG6r/Z4HGNgmZiKMMUZA2COi8DZbnKpepvh/HZEPFY6lnlPg5mro j9R+TSsHJ34rFrKLMEvu4i4QZ4l1HovFBbiChyOnF1z7+TLAskdraFGP3U1lmPQDNLWB 2bbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=mTgLYdKd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j192-20020a638bc9000000b00462c469b730si123563pge.648.2022.10.13.11.51.37; Thu, 13 Oct 2022 11:51:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=mTgLYdKd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232105AbiJMSeb (ORCPT + 99 others); Thu, 13 Oct 2022 14:34:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232033AbiJMSeL (ORCPT ); Thu, 13 Oct 2022 14:34:11 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 805A418D444; Thu, 13 Oct 2022 11:30:39 -0700 (PDT) Received: from linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net (linux.microsoft.com [13.77.154.182]) by linux.microsoft.com (Postfix) with ESMTPSA id C70CC20F9E34; Thu, 13 Oct 2022 11:29:18 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C70CC20F9E34 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1665685758; bh=LEICLpqkAHA55SgqSRkWd7Q239A6x6Ah2FjEDgwjgI4=; h=From:To:Subject:Date:From; b=mTgLYdKdGykhbNSoo5PIyT6nrzCY02AjSwwWN1D+AJWEqOVyWGaSNkSIdS/O1q2QC gcuBfWEL0sd93Q2+qKoJ7Zar+bWhnV1lLfQ7VQn8QvclUX/QrWEj2w6WbQCtVCD+9F guGi4CgEcqPMHiJ17RHKT2JW415rIHwbiYmis5g4= From: Saurabh Sengar To: ssengar@microsoft.com, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, gregkh@linuxfoundation.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, mikelley@microsoft.com Subject: [PATCH] uio_hv_generic: Enable interrupt for low speed VMBus devices Date: Thu, 13 Oct 2022 11:29:14 -0700 Message-Id: <1665685754-13971-1-git-send-email-ssengar@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 X-Spam-Status: No, score=-19.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746599526594483099?= X-GMAIL-MSGID: =?utf-8?q?1746599526594483099?= Hyper-V is adding some "specialty" synthetic devices. Instead of writing new kernel-level VMBus drivers for these devices, the devices will be presented to user space via this existing Hyper-V generic UIO driver, so that a user space driver can handle the device. Since these new synthetic devices are low speed devices, they don't support monitor bits and we must use vmbus_setevent() to enable interrupts from the host. Signed-off-by: Saurabh Sengar --- drivers/uio/uio_hv_generic.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c index c08a6cfd119f..8e5aa4a1247f 100644 --- a/drivers/uio/uio_hv_generic.c +++ b/drivers/uio/uio_hv_generic.c @@ -84,6 +84,9 @@ hv_uio_irqcontrol(struct uio_info *info, s32 irq_state) dev->channel->inbound.ring_buffer->interrupt_mask = !irq_state; virt_mb(); + if (!dev->channel->offermsg.monitor_allocated && irq_state) + vmbus_setevent(dev->channel); + return 0; } @@ -239,12 +242,6 @@ hv_uio_probe(struct hv_device *dev, void *ring_buffer; int ret; - /* Communicating with host has to be via shared memory not hypercall */ - if (!channel->offermsg.monitor_allocated) { - dev_err(&dev->device, "vmbus channel requires hypercall\n"); - return -ENOTSUPP; - } - pdata = devm_kzalloc(&dev->device, sizeof(*pdata), GFP_KERNEL); if (!pdata) return -ENOMEM;