From patchwork Thu Oct 13 12:36:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shengjiu Wang X-Patchwork-Id: 2048 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp274221wrs; Thu, 13 Oct 2022 06:18:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5eA8ILY9NJjSDYXixswTKsQTeV9TCwsyxN6hUvbdZLm0ShVjI7kcxKBX+P8+bL9CiGuMyC X-Received: by 2002:a17:907:9485:b0:78e:119f:940 with SMTP id dm5-20020a170907948500b0078e119f0940mr2026766ejc.535.1665667123747; Thu, 13 Oct 2022 06:18:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665667123; cv=none; d=google.com; s=arc-20160816; b=WZ9+sCaVeEZ2TTfpO6p3c67BiQ2fslUbdaRGYDW/6RNDMWODFErL+5bzi6QnTJ8pdi 9HzGWgrR2qNTnAny2PEu8Vc1f4OdwOgki+GdcA3QbT/ra0Y62LYVx3NJGjFuBMoYGllg 0ZOTsiBVwvra4OCqrWFsLTQ5xTKP7+wPM3wkz66MHzH+zQtctCClGWvlPFumsjIlTQCB LvkVSxQ9B4BIKDh5MAbAl4bsdTOH5vg7TqFZ8q5cF8cc2mb6TS9MJJOL5Cj5+3ckvDyq U7CPOA5Xj7ewmtkTWUX7r692m7fklOzjHdB2/LbNvk7vcLTe9mw/q++AtKhl39fDAGd4 EXMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=Owgmg8MGQE+4rIg5DSlhphzDpJVDzLpv1LpfE6BPn4M=; b=nnQVmhBZzfExuPs3d8Y0Z1xzFB/LYSdjcpzm0g/Z0bX/+/MyMgHjJ9cZqdHexA/WZK u5bRzXzSbWXkwP3PCBsE16i/YYJW9E3bMDA3bMaWler0JglJRdDNhBaUO4XvEoC+82CJ lKtk3+apNKHFdLvK8e0NCNWCU+H0Pl8yOOQgDFBkREq7FvYkDM6ktSrvvnKBGIcb1xFn VVN1hAxnbMJ7AolgsJRW+edaQRMkyfl2pooaXr8RjIPjlvGtLce9FslNr9v2YPCy8BOj N0eyfOT23XHV5BWqeauCgTxQRoOrvRwhh2LPkc5YkscLJY1WpWXuUtP3HRTPnbEdU/rX 3PXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ee8-20020a056402290800b00450e1ffe3edsi16426915edb.382.2022.10.13.06.18.14; Thu, 13 Oct 2022 06:18:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229657AbiJMM4v (ORCPT + 99 others); Thu, 13 Oct 2022 08:56:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229540AbiJMM4s (ORCPT ); Thu, 13 Oct 2022 08:56:48 -0400 Received: from inva020.nxp.com (inva020.nxp.com [92.121.34.13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 520F5139E45 for ; Thu, 13 Oct 2022 05:56:47 -0700 (PDT) Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 97F821B45BA; Thu, 13 Oct 2022 14:56:45 +0200 (CEST) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 60F4E1B45BC; Thu, 13 Oct 2022 14:56:45 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id 09EF31802204; Thu, 13 Oct 2022 20:56:43 +0800 (+08) From: Shengjiu Wang To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, viorel.suman@nxp.com Cc: shengjiu.wang@gmail.com Subject: [PATCH] ASoC: ak4458: add optional reset control to instead of gpio Date: Thu, 13 Oct 2022 20:36:51 +0800 Message-Id: <1665664611-21350-1-git-send-email-shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.7.4 X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746578569953681647?= X-GMAIL-MSGID: =?utf-8?q?1746578569953681647?= From: Viorel Suman Add optional reset control instead of GPIO to manage codec PDN pin. As there is reference counter for reset control, so need to remove one ak4458_reset in runtime resume to make the reference counter balance. Signed-off-by: Viorel Suman Signed-off-by: Shengjiu Wang --- sound/soc/codecs/ak4458.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c index 626310859814..ac328d598291 100644 --- a/sound/soc/codecs/ak4458.c +++ b/sound/soc/codecs/ak4458.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include #include @@ -46,6 +47,7 @@ struct ak4458_priv { struct device *dev; struct regmap *regmap; struct gpio_desc *reset_gpiod; + struct reset_control *reset; struct gpio_desc *mute_gpiod; int digfil; /* SSLOW, SD, SLOW bits */ int fs; /* sampling rate */ @@ -633,6 +635,12 @@ static void ak4458_reset(struct ak4458_priv *ak4458, bool active) if (ak4458->reset_gpiod) { gpiod_set_value_cansleep(ak4458->reset_gpiod, active); usleep_range(1000, 2000); + } else if (!IS_ERR_OR_NULL(ak4458->reset)) { + if (active) + reset_control_assert(ak4458->reset); + else + reset_control_deassert(ak4458->reset); + usleep_range(1000, 2000); } } @@ -668,7 +676,6 @@ static int __maybe_unused ak4458_runtime_resume(struct device *dev) if (ak4458->mute_gpiod) gpiod_set_value_cansleep(ak4458->mute_gpiod, 1); - ak4458_reset(ak4458, true); ak4458_reset(ak4458, false); regcache_cache_only(ak4458->regmap, false); @@ -748,6 +755,10 @@ static int ak4458_i2c_probe(struct i2c_client *i2c) ak4458->drvdata = of_device_get_match_data(&i2c->dev); + ak4458->reset = devm_reset_control_get_optional_shared(ak4458->dev, NULL); + if (IS_ERR(ak4458->reset)) + return PTR_ERR(ak4458->reset); + ak4458->reset_gpiod = devm_gpiod_get_optional(ak4458->dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(ak4458->reset_gpiod))