From patchwork Mon Dec 25 17:46:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Elfring X-Patchwork-Id: 183229 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp494283dyb; Mon, 25 Dec 2023 09:47:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IEnMgannyTqny333lVHzXhP1FgTF4V82gYH/RVFb/mSY4W26SM3FGHkqG40Ig44WIwVoqh/ X-Received: by 2002:a05:6808:11c3:b0:3ba:4c6:f39b with SMTP id p3-20020a05680811c300b003ba04c6f39bmr6392613oiv.98.1703526449015; Mon, 25 Dec 2023 09:47:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703526448; cv=none; d=google.com; s=arc-20160816; b=uYMS/NPpPe6ldpeXBjMNE/2UlspcXNHDT1WB0E+hEYThWFP1cGKwP87mAt2rbT3hAP bpS/R350DvQ2IuhixkgjLYdMyn9rjvXFNcPWcZSY8C/iYvTByOqD8R1trk0R9nwe5z5c +1Pj8wpwPSQlOl2kOHX1YZjv8XZZ9ozSv2dK73FVan2xRoYPkjQK/9hUROS5ZH0quZEF 8IpWXfZbrOKiW/ED9Mk29hmirf03j6umSopyyQ6DlZ3VNfMGKeLKZYmdgfjbc+0J23fi FJqllOuvtoozY+a/GUk77rCQ+DPmZQi55GGnrwKAPpL2nmSsvq6IUYJUpBCIA11q5NUI RlDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=eJzgxGEUok1ldx0JR0QKMd4IctC4HOcqlicPsn0u19w=; fh=xQ7XBkV8Vfr1n1guxZ3RC0eNPkZJ/hSLNnxt7nNRj5I=; b=GOMlYJvw3mK5N23J81TWvQUvNQOJpzCF7+O2Nwj6jzkh1wGf9MXA8XTCgj1kpf+VKp bIOrHMdE/OhOooPiH8Yt/kmNe3QXgwDKchNPzokMUzJytbcxpMgKLGKAZG4RxSEM7/pL K2DlIR1ax2A0qMudBim5zJcKrqtSETBkGnHmjS1aCe9t0u1kKXkeAp+N+umTkXESISLq CyHwBLDCP1148+aPa/qAINLr/KWkRi1IOxYai55+dQOMJMl67ub1rEsV2Z6CZCnR0ge5 37/5fMJ+ajn/CswlDnIlXsyRdUsqXn3NqlwCkcTXdImO27z0T2l40zJjot7VM2FVbp6l ncqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=GiO7qeHC; spf=pass (google.com: domain of linux-kernel+bounces-11135-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11135-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id s17-20020a656911000000b005cdf992367dsi5657758pgq.730.2023.12.25.09.47.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Dec 2023 09:47:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-11135-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=GiO7qeHC; spf=pass (google.com: domain of linux-kernel+bounces-11135-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11135-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 7697BB216F7 for ; Mon, 25 Dec 2023 17:47:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3D892537FA; Mon, 25 Dec 2023 17:47:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="GiO7qeHC" X-Original-To: linux-kernel@vger.kernel.org Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A220D52F6C; Mon, 25 Dec 2023 17:47:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1703526384; x=1704131184; i=markus.elfring@web.de; bh=yZfNVyN4f4vfAqTUZd3nhSOWUqIAg4Bk9xRcEkmGZ5M=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=GiO7qeHCXutEbfDxFIdz4So3jEDLAuTIEVpxo6C6Hd7t9H3wD2azDaACSutB62aQ YwqXdfHwqdzHRLMyn0Z2L1I+524QFb6MXZCjg7gR+CrtHia7VmbV6QlGEIxmjPM1w 3JJAj9p+eRGZ/kCBzT/Ma9GcDjJqa2X9FDKu/VdvBRaqolrAh32WOTUNASbU+mnLn 4L6GnoftHVl4140LMk7mGlMRx5csm6qinrSpYKkEEkoXZKr2ewbbu5yqZZqtqWYHl GLBShQsPoandcv0O205o3ggQYErKlhypAoOb/Fl8vumw0Ra5luK1E4floSkx+i/B9 98H/MVwTv4CnuD3jyA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MS17h-1rgJlD0Q8J-00TZ2O; Mon, 25 Dec 2023 18:46:24 +0100 Message-ID: <15936ac5-5380-42fa-b13a-e6b2ccf92490@web.de> Date: Mon, 25 Dec 2023 18:46:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: =?utf-8?q?=5BPATCH_7/7=5D_EDAC/amd64=3A_Move_an_assignment_for_the_?= =?utf-8?q?variable_=E2=80=9CF3=E2=80=9D_in_probe=5Fone=5Finstance=28=29?= Content-Language: en-GB From: Markus Elfring To: linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org, Borislav Petkov , James Morse , Mauro Carvalho Chehab , Robert Richter , Tony Luck , Yazen Ghannam Cc: LKML , cocci@inria.fr, Muralidhara M K References: <8c9e2c01-9ed0-4392-af40-4e8eb393cb67@web.de> In-Reply-To: <8c9e2c01-9ed0-4392-af40-4e8eb393cb67@web.de> X-Provags-ID: V03:K1:66u+l/NmUncqbzV4DyhYiHKTFwdL8r80fp0lKBBqJ4Se1lKH36E GRmsALRYZzIW/mZQat/0+0+7qD1JqwkFqKB1IjRWouz9CCsUT3Q1Xn7MOSCIkdWAg0LlRPY fsTP51u3VQUz6c4p72SnFchlNUCxKVUE8v9BRvw3ZqJem/eJCNJIHoqdnUGko/13jb6Fh+Z mZXcmp6jjjDEZmDhtHGSA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:vZ18hv2qYMk=;dqmj3WTTTp6yGfjGEUHWNrWEOJU yt2QYNCgE0N5ixA/hQm26un+3Uzx029yhuNPS8eyYQw44Mb9/856Jvi328c4KjUHx5dyB31jR bmQ2FLL2iH/meS+Rh/adpIgGW/wu6NKPnCL1n9eLMFoMKLUiXz99Puwjz+1dL1O+HhzLz09RI A1KVzV80mW2YKtageXbFY1VuXlFlRTwBFlMVv9mfCYleqvgeZtSeicfXqAjxLWBC52umcmN6A VbfKqgIdcyB0RvK3WcxnhKqiSppA9Rj9NQHlNLOWFEfhgv7BYXr+yJsb33sEskYCjVOBQS3D8 qOhCwOPRytdLEhbUcUKuE8lcCyrxrZh2Sd4onQBKsy14OIm5VEOqrmTDaGtuGL0v88whKKnZd cG5JQ+K1EVxYAxb/veAHWtOso9f8rcFMKdy7KVMcdI52hawN77L/rsBzhPcm2fkhnUl3WOadn oyEbKEYKCi0pKtThDZgALTSqvpXYbW5YlpPsr8xG8pIJUmW6hvVnjhDU10WW6kOfRg/BsLvcq 9E/Mx9nbddgtpIySrnAlnZRBqJwx3Ifb9mNWZh3k74FGuyijm1pN44+kUspkS4aXRNfOZOVoL VdhYNpARcU7Bjwa8UuvZ8T2eG+rGoHQ4a/tr0JOLGYuFWqgD6/8PUXT0ZphRPRxu3oznk93/4 dU89SApnK96KCVuqQyZxNc72NhFenzVvgyuHzktkaSUWEJoQuv1ianExWedXUF6deXzfPOBc8 N/e7UX5+zQPnQ3lSs8t69XhGz7JuWprKS7yKoI6D4JI3NceCYFiQPmSuPfLVbNn1gmxnmODz8 9/cHwOAKOz4buRNFxA7tQDa6NeDtKW+PuZHDGW5oHAPrn+ED9yrxpP+j/qe0UVwXjRGaCclnj j9s0TbFd4HatEHu3M2S5HVO+aJ3f4aVFFuaXI7lGhF7GL7TnHuUqnlMudtL//4VMqTBzw4xhY J/d6AQ== X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786276949410262180 X-GMAIL-MSGID: 1786276949410262180 From: Markus Elfring Date: Mon, 25 Dec 2023 17:54:33 +0100 Move one assignment for a local variable so that its setting will only be performed immediately before this pointer is used. Signed-off-by: Markus Elfring --- drivers/edac/amd64_edac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.43.0 diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c index 698cde573847..91e0abdf762f 100644 --- a/drivers/edac/amd64_edac.c +++ b/drivers/edac/amd64_edac.c @@ -4263,7 +4263,7 @@ static bool instance_has_memory(struct amd64_pvt *pvt) static int probe_one_instance(unsigned int nid) { - struct pci_dev *F3 = node_to_amd_nb(nid)->misc; + struct pci_dev *F3; struct amd64_pvt *pvt; struct ecc_settings *s; int ret; @@ -4281,6 +4281,7 @@ static int probe_one_instance(unsigned int nid) } pvt->mc_node_id = nid; + F3 = node_to_amd_nb(nid)->misc; pvt->F3 = F3; ret = per_family_init(pvt);