From patchwork Fri Apr 21 10:41:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 86243 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp971810vqo; Fri, 21 Apr 2023 03:46:50 -0700 (PDT) X-Google-Smtp-Source: AKy350ZYVXr7YjmcR+cRlGx/ZfysOrUGykkWnzUffXcjn9DrrcDC2ev7DzN8pTVrGhAk1kUTypCx X-Received: by 2002:a05:6a20:914b:b0:ef:890c:3005 with SMTP id x11-20020a056a20914b00b000ef890c3005mr6277176pzc.17.1682074010095; Fri, 21 Apr 2023 03:46:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682074010; cv=none; d=google.com; s=arc-20160816; b=zZuCljEMn8ECCgO2oRbcXSFhe9AROBzu/u5AFml3CLlIquFFZE2V37aa4kXfO+UlAL aCSk7Z9/unnkuuuH+DTfuFMif/kcHVS6/WzYgoPk/HTm042eD6wN8e7QdOCHz3OxnxXY z3QPlDqc8b5nMBHLzu+2Kd34KYs43Zw3TUn2F2ZmTvoYcW30BmpUFuDAKQuSXgAFvLbD OEmEKtKTePxP0St2oQRNRO9f2yeKZHGkIyG5QOSk/C8cUIf+Br9Hi+P9boIdqYnXXQ58 faoS/WhluqCMmKFQmo3pk0GMdMTHqDrisKuGPVf7uZmbXBw2qbTjTbmUTwQtardw28dh s7Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=0Lud2bmV2Dni/HQ7LD8dzY1T7ghtMyeOGVVq6vz/KY4=; b=tYUdhGhCQXNxG71NpP9qWqybmD5Uzn/vafD5qU0qE3RbCA4e4rNmltmDzsycVWK5uv ZIAKy7XV+R7wL/OO+sk/KujftSSpq76cPff83VUdLOsK8ujhrMo0KqbLbeKz/oUnTqs6 mYSBSg4bq16AsmQ3MW+FeGYGKy+ivBPoD7FCWstTlH7Nk8HYI96lpMaDCf374CAvemiw L3KRUymYBGjiKLxVQ1s5DdaKQGZV4hWUJ6u6EckCJjmt+Lvvm2YKNioV9CO8z6B14JxV lexzK7YL2m5uJuNrJ3rsJrw+Mx4mswkn+vjvmaNp8wZCUc2+LSdwUlxiPP3nq1CC46O7 iPXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tGrpluEy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j69-20020a638048000000b005180515929csi4012988pgd.28.2023.04.21.03.46.35; Fri, 21 Apr 2023 03:46:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tGrpluEy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229543AbjDUKmG (ORCPT + 99 others); Fri, 21 Apr 2023 06:42:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbjDUKmE (ORCPT ); Fri, 21 Apr 2023 06:42:04 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FCBDA5ED for ; Fri, 21 Apr 2023 03:42:01 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3f1957e80a2so5314395e9.1 for ; Fri, 21 Apr 2023 03:42:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682073720; x=1684665720; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=0Lud2bmV2Dni/HQ7LD8dzY1T7ghtMyeOGVVq6vz/KY4=; b=tGrpluEyBAL+tKGdC8h9q2vZiZG0p6utHNQyjpOyR2anTmwu1WfD/UckRVHYfxdoJq P2cOBlafdR2Q2clqrJ3GH7BaxsDsQ4Y0g+Tcqc03ZdQhLFr2D7hUs2R85/9Ys1Ufez6+ teKLz1ILIAW4v0TE3x+gk9tZlcqa7NyMsyJjw8++a1JPfQTbAXRIyEXqpxpOCgW18wZ6 q87Ql7IMwrpBkTptIQ196ldv/8h9vjwsPAsJ3TwJcb6o1weaa2ZIqXJ1qj+vuwq41Js5 UhLbq51nEhro4w7KxmUQW5DwTV78/MhrFwX54SjB4dj7Bo+rfvf51lsxKAROZAKfewCj f6bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682073720; x=1684665720; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0Lud2bmV2Dni/HQ7LD8dzY1T7ghtMyeOGVVq6vz/KY4=; b=eP41G2fvx7hg1GTbsIPDapMPqTgItHwNHLPW051lzgJB7UcTHYrfl5rTtbec1umL8z Aqb7QuhAOz2R+dyZ0T5cDDxiAA5ugkayeQkbI8ojikgThPmeZQyIsLfXI8VLHXax2igg f9BeMOmHfE3L2+px8+I0SY15mIEIQsFV/0q3a82DZo7yddxW+X6sIyLKwy6FZlhv/JBm GUullQ8MZkTl66+4Fmpo2806dL/obrq5ScOA4hrfgnk1V/UTmhvnADeI1j615w8Zn0L0 YxmzpwpX7BloR8DxZd1O4PT8r7BCjz7zZP1tTDy9zwr0S2p8ghCmsH+oO1wdtX3Wa/pI wCGQ== X-Gm-Message-State: AAQBX9du2bvYGw7oOF6nFtXJ/MJs1kb7ZD+jpdOsNG8Q8F2FSvyFopJ4 Hr8tpLZnyFNnp2PgrgjA3FFZEw== X-Received: by 2002:a5d:594c:0:b0:2e5:8874:d883 with SMTP id e12-20020a5d594c000000b002e58874d883mr7219791wri.8.1682073719821; Fri, 21 Apr 2023 03:41:59 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id l9-20020a05600c1d0900b003f17eded97bsm7920120wms.19.2023.04.21.03.41.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 03:41:59 -0700 (PDT) Date: Fri, 21 Apr 2023 13:41:56 +0300 From: Dan Carpenter To: Patrik =?iso-8859-1?q?Dahlstr=F6m?= Cc: Jonathan Cameron , Lars-Peter Clausen , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] iio: adc: palmas: fix off by one bugs Message-ID: <14fee94a-7db7-4371-b7d6-e94d86b9561e@kili.mountain> MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763782436697851912?= X-GMAIL-MSGID: =?utf-8?q?1763782436697851912?= Valid values for "adc_chan" are zero to (PALMAS_ADC_CH_MAX - 1). Smatch detects some buffer overflows caused by this: drivers/iio/adc/palmas_gpadc.c:721 palmas_gpadc_read_event_value() error: buffer overflow 'adc->thresholds' 16 <= 16 drivers/iio/adc/palmas_gpadc.c:758 palmas_gpadc_write_event_value() error: buffer overflow 'adc->thresholds' 16 <= 16 The effect of this bug in other functions is more complicated but obviously we should fix all of them. Fixes: a99544c6c883 ("iio: adc: palmas: add support for iio threshold events") Signed-off-by: Dan Carpenter --- --- drivers/iio/adc/palmas_gpadc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/palmas_gpadc.c b/drivers/iio/adc/palmas_gpadc.c index c1c439215aeb..7dfc9c927a23 100644 --- a/drivers/iio/adc/palmas_gpadc.c +++ b/drivers/iio/adc/palmas_gpadc.c @@ -547,7 +547,7 @@ static int palmas_gpadc_read_raw(struct iio_dev *indio_dev, int adc_chan = chan->channel; int ret = 0; - if (adc_chan > PALMAS_ADC_CH_MAX) + if (adc_chan >= PALMAS_ADC_CH_MAX) return -EINVAL; mutex_lock(&adc->lock); @@ -595,7 +595,7 @@ static int palmas_gpadc_read_event_config(struct iio_dev *indio_dev, int adc_chan = chan->channel; int ret = 0; - if (adc_chan > PALMAS_ADC_CH_MAX || type != IIO_EV_TYPE_THRESH) + if (adc_chan >= PALMAS_ADC_CH_MAX || type != IIO_EV_TYPE_THRESH) return -EINVAL; mutex_lock(&adc->lock); @@ -684,7 +684,7 @@ static int palmas_gpadc_write_event_config(struct iio_dev *indio_dev, int adc_chan = chan->channel; int ret; - if (adc_chan > PALMAS_ADC_CH_MAX || type != IIO_EV_TYPE_THRESH) + if (adc_chan >= PALMAS_ADC_CH_MAX || type != IIO_EV_TYPE_THRESH) return -EINVAL; mutex_lock(&adc->lock); @@ -710,7 +710,7 @@ static int palmas_gpadc_read_event_value(struct iio_dev *indio_dev, int adc_chan = chan->channel; int ret; - if (adc_chan > PALMAS_ADC_CH_MAX || type != IIO_EV_TYPE_THRESH) + if (adc_chan >= PALMAS_ADC_CH_MAX || type != IIO_EV_TYPE_THRESH) return -EINVAL; mutex_lock(&adc->lock); @@ -744,7 +744,7 @@ static int palmas_gpadc_write_event_value(struct iio_dev *indio_dev, int old; int ret; - if (adc_chan > PALMAS_ADC_CH_MAX || type != IIO_EV_TYPE_THRESH) + if (adc_chan >= PALMAS_ADC_CH_MAX || type != IIO_EV_TYPE_THRESH) return -EINVAL; mutex_lock(&adc->lock);