From patchwork Wed Sep 13 14:08:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 138833 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp1120654vqx; Wed, 13 Sep 2023 07:20:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG3z9aF5+dAFcTY1Pet4+lsoWxoPW62NEfgS5cgTsmf1cgpGfKumwoWEVtNplRKcKZ6QJAW X-Received: by 2002:a17:90a:ca15:b0:25d:eca9:1621 with SMTP id x21-20020a17090aca1500b0025deca91621mr2179612pjt.6.1694614822372; Wed, 13 Sep 2023 07:20:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694614822; cv=none; d=google.com; s=arc-20160816; b=all2t1jwV3xcLpreJfzzd+SaqdbnAuAQESft7GOBFT1t6c9UQOWmoT0bFoLFhMvjqR A3HW82Ef5mSXqTnQfbXj8S7U1X8zVa9cmpSsPgjCyXLetap10+k8KLXbGx9e+zZvGBa6 mHksiNc4G0UKop9RQYTfIA+LUpAwxoEAGr13c71Og+nDMB9nsv79V2KXkwcZwv5ReYtm 7aYzZIpHaLJdy0uMc4SUqRZSD/E3mZdbv4cQtszXXdq3I73UiyioP+NDZj5VuceAu3le ylvovF7S73KYTcOVnPqBIEWd35bcUgKr5sppPqvT2n54EKaP6aPZjxsnrJ/f1QKI78rr MR4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=9PJMxrpBvh3w1DimG9rh1UueGLdE4ByVNznPkvKjx10=; fh=fKMC3BTGjlLXl5EvEhzqt3WHCynqYJKK7wAqLAOkWUw=; b=SMlkjlbJsiEtHh/Zwm/tmHiC+/e3tno2E9evp40bj8PU44zkqk4FQJtqnt1WABg+yz gHzWWBOPUBue3y7TV1ht0haaZOSyznV2+RQ2zxF6RnACdDiWhtaoCQQooaa86XUnVVjR 2mMlpR7IgSRbG5671B84J4f5RC3vQl1n/pwfxEChiuEY0wR+hGdbIgJ66ZtTXUPo5QxC tU+/RmUvQLdL3v5KMezFPcmh6M7t/fkYyFOgBFnWqRHcjmezpVrEnjCnibKa8pzl81Nm ++7WEGzNjuh6UZS78K5+cSdvUGn/bV+jj/tgJtcY4U4TmFT5Pc4kfMdhQMBwyOzlcy3B jz5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id m15-20020a17090b068f00b002740f52e526si417985pjz.139.2023.09.13.07.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 07:20:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id C3864804ACC2; Wed, 13 Sep 2023 07:09:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241367AbjIMOJU (ORCPT + 36 others); Wed, 13 Sep 2023 10:09:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241263AbjIMOI4 (ORCPT ); Wed, 13 Sep 2023 10:08:56 -0400 Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [IPv6:2a02:1800:120:4::f00:13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CB431BDD for ; Wed, 13 Sep 2023 07:08:50 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:f674:9611:cd05:f25a]) by baptiste.telenet-ops.be with bizsmtp id lS8n2A0043fvA4V01S8nqD; Wed, 13 Sep 2023 16:08:48 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qgQXd-003crw-KA; Wed, 13 Sep 2023 16:08:47 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qgQXu-00FV4d-Vg; Wed, 13 Sep 2023 16:08:46 +0200 From: Geert Uytterhoeven To: linux-m68k@lists.linux-m68k.org Cc: Arnd Bergmann , Finn Thain , Michael Schmitz , Philip Blundell , Greg Ungerer , Joshua Thompson , Sam Creasey , Laurent Vivier , linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH v2 16/52] m68k: amiga: pcmcia: Replace set but not used variable by READ_ONCE() Date: Wed, 13 Sep 2023 16:08:06 +0200 Message-Id: <1436fa6b329c2212aaf020055afbb97e64b6f039.1694613528.git.geert@linux-m68k.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 13 Sep 2023 07:09:24 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776932431916618700 X-GMAIL-MSGID: 1776932431916618700 When building with W=1: arch/m68k/amiga/pcmcia.c: In function ‘pcmcia_reset’: arch/m68k/amiga/pcmcia.c:29:23: warning: variable ‘b’ set but not used [-Wunused-but-set-variable] 29 | unsigned char b; | ^ Fix this by using READ_ONCE(), and removing the variable. Signed-off-by: Geert Uytterhoeven Acked-by: Arnd Bergmann --- v2: - Add Acked-by. --- arch/m68k/amiga/pcmcia.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/m68k/amiga/pcmcia.c b/arch/m68k/amiga/pcmcia.c index 7106f0c3639bc105..63cce6b590df4dcb 100644 --- a/arch/m68k/amiga/pcmcia.c +++ b/arch/m68k/amiga/pcmcia.c @@ -26,11 +26,10 @@ static unsigned char cfg_byte = GAYLE_CFG_0V|GAYLE_CFG_150NS; void pcmcia_reset(void) { unsigned long reset_start_time = jiffies; - unsigned char b; gayle_reset = 0x00; while (time_before(jiffies, reset_start_time + 1*HZ/100)); - b = gayle_reset; + READ_ONCE(gayle_reset); } EXPORT_SYMBOL(pcmcia_reset);