From patchwork Thu Sep 7 13:41:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 137681 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ab0a:0:b0:3f2:4152:657d with SMTP id m10csp77771vqo; Thu, 7 Sep 2023 11:30:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEzikUMk4xncpqhhEL2pX/uNi7FfOC+BvZVWdHaupTSrCxaSYuUDxg3VYPTqAmnspUaTkUt X-Received: by 2002:a17:902:bd93:b0:1c3:2dcb:25c9 with SMTP id q19-20020a170902bd9300b001c32dcb25c9mr367930pls.40.1694111419102; Thu, 07 Sep 2023 11:30:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694111419; cv=none; d=google.com; s=arc-20160816; b=kfvN9PDLaSWmd9zcm6YxmP4nITBfX5TF21Fxv2YATWxDzmVR04w6fPzY95ZA+bkEOg Ap+FlB6b+LEwMlUy4BdAPYVNSOV7uwzecoaQ5hqEIaIzKLcY+LKYqRW40iYf0rnT/PcU URKtqX1xikGuUbLjMuy7MWYYG2XWGCu/R/XlYggKgLGw2a+9V7/wwV1vIb5+QfpmYe8W p0NuBA247aBKFHiSy39xEdowEy38oSKZafFHmwqoPHIItFvrAEYLDzqRmFZ8WFGvMMDW di23fSd6k/09O8908zhYbq9Glm/YKbucDHJq5wNWj3s5xa+VZiRa881zJBfxE9sfarZE vijA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=l/7O908plcfOZNFdtj6J5XIgDAIJh5Bmuj+flglQlvM=; fh=fKMC3BTGjlLXl5EvEhzqt3WHCynqYJKK7wAqLAOkWUw=; b=n55Z/QZbMBXU9oegJt94mr7JuXcyd49CHrMoEMZNzxKpk55PhbFvMi4wOQIK/M5AED no0ToQJxoo4/L4u2OhKZ+C9soXa2bMM1wv6Y+6aZA7zkcpMGqFA2IHnSJXYUF7zV/3Fg vTe6IQLRpjrfoXgOuqTinXE2pgMBHxUKf+5ohFhbVEy2yfdxlROamDhwpScra6l6+1hM 4HYMowX6S6S87wHfmAQ/4yFHtTkmoA05+xbPrBRpiaX+ZNVGZSz3d+UnkfII1DagAQvn Q4IsqH+7wm7Rf1XqKZ/q6YQY5E0OJPGH5Yw9kHVSckSF06x64m6EPvFCsS4kZnieQftz WFfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id la5-20020a170902fa0500b001bf5753e0ccsi122182plb.119.2023.09.07.11.30.11; Thu, 07 Sep 2023 11:30:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229547AbjIGPga (ORCPT + 42 others); Thu, 7 Sep 2023 11:36:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344277AbjIGPcv (ORCPT ); Thu, 7 Sep 2023 11:32:51 -0400 Received: from weierstrass.telenet-ops.be (weierstrass.telenet-ops.be [IPv6:2a02:1800:110:4::f00:11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5F271FCA for ; Thu, 7 Sep 2023 08:32:29 -0700 (PDT) Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by weierstrass.telenet-ops.be (Postfix) with ESMTPS id 4RhL5L60NCz4x16y for ; Thu, 7 Sep 2023 15:42:14 +0200 (CEST) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:c214:2eac:128d:f67e]) by andre.telenet-ops.be with bizsmtp id j1hy2A0022mGBSJ011hyGA; Thu, 07 Sep 2023 15:41:59 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qeFGQ-002m9B-Jc; Thu, 07 Sep 2023 15:41:57 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qeFGf-00CMgq-R7; Thu, 07 Sep 2023 15:41:57 +0200 From: Geert Uytterhoeven To: linux-m68k@lists.linux-m68k.org Cc: Arnd Bergmann , Finn Thain , Michael Schmitz , Philip Blundell , Greg Ungerer , Joshua Thompson , Sam Creasey , Laurent Vivier , linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 23/52] m68k: apollo: Remove unused debug console functions Date: Thu, 7 Sep 2023 15:41:24 +0200 Message-Id: <133c76b1bd98932d8aeed8f1a85271cbe4d39a65.1694093327.git.geert@linux-m68k.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776404575397964697 X-GMAIL-MSGID: 1776404575397964697 When building with W=1: arch/m68k/apollo/config.c:111:5: warning: no previous prototype for ‘dn_serial_console_wait_key’ [-Wmissing-prototypes] 111 | int dn_serial_console_wait_key(struct console *co) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~ arch/m68k/apollo/config.c:118:6: warning: no previous prototype for ‘dn_serial_console_write’ [-Wmissing-prototypes] 118 | void dn_serial_console_write (struct console *co, const char *str,unsigned int count) | ^~~~~~~~~~~~~~~~~~~~~~~ arch/m68k/apollo/config.c:238:6: warning: no previous prototype for ‘dn_dummy_waitbut’ [-Wmissing-prototypes] 240 | void dn_dummy_waitbut(void) { | ^~~~~~~~~~~~~~~~ Fix this by removing these unused functions. The last user of dn_serial_console_write() was removed in v2.3.41. The other functions never had any users. Signed-off-by: Geert Uytterhoeven --- arch/m68k/apollo/config.c | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/arch/m68k/apollo/config.c b/arch/m68k/apollo/config.c index 42a8b8e2b664226a..fccbb40772dca6b9 100644 --- a/arch/m68k/apollo/config.c +++ b/arch/m68k/apollo/config.c @@ -4,7 +4,6 @@ #include #include #include -#include #include #include #include @@ -108,27 +107,6 @@ static void __init dn_setup_model(void) } -int dn_serial_console_wait_key(struct console *co) { - - while(!(sio01.srb_csrb & 1)) - barrier(); - return sio01.rhrb_thrb; -} - -void dn_serial_console_write (struct console *co, const char *str,unsigned int count) -{ - while(count--) { - if (*str == '\n') { - sio01.rhrb_thrb = (unsigned char)'\r'; - while (!(sio01.srb_csrb & 0x4)) - ; - } - sio01.rhrb_thrb = (unsigned char)*str++; - while (!(sio01.srb_csrb & 0x4)) - ; - } -} - void dn_serial_print (const char *str) { while (*str) { @@ -237,12 +215,6 @@ void dn_dummy_reset(void) { } -void dn_dummy_waitbut(void) { - - dn_serial_print("waitbut\n"); - -} - static void dn_get_model(char *model) { strcpy(model, "Apollo ");