From patchwork Mon Jul 3 14:42:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ahelenia_Ziemia=C5=84ska?= X-Patchwork-Id: 115401 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp575667vqx; Mon, 3 Jul 2023 07:45:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6iwM+lw1KYcbnyRFnn/yw7OdQg+BiYtZtd8yF5OPyC/LGc9670kdY/uUnki2XHv82yBtbm X-Received: by 2002:a05:6a21:9989:b0:12c:bbd3:a0dd with SMTP id ve9-20020a056a21998900b0012cbbd3a0ddmr15448605pzb.0.1688395553713; Mon, 03 Jul 2023 07:45:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688395553; cv=none; d=google.com; s=arc-20160816; b=XSYLl1O4MtvhIbIsPb48kJKmFFZannZ4RJrhFsgBSomhz0uz+SvPu63VTYtj2VQxbY Q3DTEPpmNmv0ei0haLgMqftfmMfJ5VMmI5sQtrF+/B3EuoTXe9A7y3kV6jTcTNYv0qhv SAjsyF9jPIkIFpgbPLERpG/KDEd4SrDe4V2G3ITwHg87CiNi4oCqhMKONgoxJkrppGHF CYdIo8FoyjQ/nf/BaavRJ0GTDBLQnE6EQu5WCU0cOJTznC+vQ59CEd9WLOXtZHJsBBUJ hnGZU6+7P6zGaJnJwCU3cxvGkOiC7cIrkl9cCXKyd4+ORi2a2Ht3GcBaUicyIVRFH3YZ gRBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=So6jXT0WYt/MPFDr7iZzJBW84Dz1OXnGoKO73pWKQ2Y=; fh=AfCaarrJloRV9X8pgVoQkWOYp+JFhFv1/c5FQOfH+1Q=; b=PURehPUOwpInNSms7FvVUa+hqStgs/z/H6n3lilFYn7SbjNBGuRr0pAmqS3F8eTwRL ty3S4BqoiX3Tncd2JYrfbqbhtJiyor10NtH6cFIailfb0Zb1f7pvqj5TVl9m6WWihEqY nDQXYX5UeXl4hd+Qv6LIvRv1NBpAf7BXo8OuvJ2FZUNOIArwsgTgjVE8yW3gAdzkS1Hl 81lDlQbWDr6iWBibfZbqLKL/4ZsCAg3xhZlrR7aXGtKFiQpOawvuERQRNP9ih+UV3ZaY qa112Xpsiz5lCaMk+cST7gWm2jBVkZxv+PsSXveSMJAPuKqnAKtoQ+iLPenRlUELxxiT ZSfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nabijaczleweli.xyz header.s=202305 header.b=EsXuPnSi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nabijaczleweli.xyz Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j16-20020a170902da9000b001b891de7583si3365795plx.348.2023.07.03.07.45.40; Mon, 03 Jul 2023 07:45:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@nabijaczleweli.xyz header.s=202305 header.b=EsXuPnSi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nabijaczleweli.xyz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231304AbjGCOm3 (ORCPT + 99 others); Mon, 3 Jul 2023 10:42:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231290AbjGCOm1 (ORCPT ); Mon, 3 Jul 2023 10:42:27 -0400 Received: from tarta.nabijaczleweli.xyz (unknown [139.28.40.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 806B2E74; Mon, 3 Jul 2023 07:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nabijaczleweli.xyz; s=202305; t=1688395342; bh=SowbDY6YnsriPuN0djgR0SpF4itfDBztRXtp8moML7o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EsXuPnSi0xOmIDA9aB+N2jhQz9p0AOzj61HDIQTIJdzsnRWnGbDF/huwP1B2Kx+s4 GKbOd+IEDrPuqA8IYlgDBOn6HOsDRcDqUnEcUykq7eexZHfYx4Z3D/N8VYaI//nkFq WJkt4AYUkUzX5FoP6FZzjhpdok8hVpqoRCs4WGx2pbfxIKqawO2xUiBirSXWlAmDpE P8FV50NHcwz5rhWzafQCFhpJ2R+IRTIKCBssG8XeIt/RX5FLzqNjXl7fEXeVDbeqZB +llvKsXyqOJZ9yQPPq7UR0PsOfrof+FV3TOpe1D5CNEgiM3y7YUE3X9IMLGbTYa4l6 iS2kXT2bbIGnA== Received: from tarta.nabijaczleweli.xyz (unknown [192.168.1.250]) by tarta.nabijaczleweli.xyz (Postfix) with ESMTPSA id 9D49F1DC4; Mon, 3 Jul 2023 16:42:22 +0200 (CEST) Date: Mon, 3 Jul 2023 16:42:21 +0200 From: Ahelenia =?utf-8?q?Ziemia=C5=84ska?= To: Christian Brauner Cc: Alexander Viro , Jan Kara , Amir Goldstein , Chung-Chiang Cheng , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 3/3] splice: fsnotify_access(in), fsnotify_modify(out) on success in tee Message-ID: <10d76dd8c85017ae3cd047c9b9a32e26daefdaa2.1688393619.git.nabijaczleweli@nabijaczleweli.xyz> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20230517 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,PDS_RDNS_DYNAMIC_FP, RDNS_DYNAMIC,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770411056199349706?= X-GMAIL-MSGID: =?utf-8?q?1770411056199349706?= Same logic applies here: this can fill up the pipe, and pollers that rely on getting IN_MODIFY notifications never wake up. Fixes: 983652c69199 ("splice: report related fsnotify events") Link: https://lore.kernel.org/linux-fsdevel/jbyihkyk5dtaohdwjyivambb2gffyjs3dodpofafnkkunxq7bu@jngkdxx65pux/t/#u Link: https://bugs.debian.org/1039488 Signed-off-by: Ahelenia Ziemiańska Reviewed-by: Amir Goldstein Acked-by: Jan Kara --- fs/splice.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/splice.c b/fs/splice.c index 5deb12d743b1..c49909dbf3c5 100644 --- a/fs/splice.c +++ b/fs/splice.c @@ -1815,6 +1815,11 @@ long do_tee(struct file *in, struct file *out, size_t len, unsigned int flags) } } + if (ret > 0) { + fsnotify_access(in); + fsnotify_modify(out); + } + return ret; }