From patchwork Thu Apr 13 13:51:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 83000 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1062851vqo; Thu, 13 Apr 2023 07:07:28 -0700 (PDT) X-Google-Smtp-Source: AKy350YSRyo98WaWkvA6zEux+k7GYw2R7y5KutFat8vV/X/G1z/Ia2Tcq4NXPifnfmfrFPZb5svZ X-Received: by 2002:aa7:c394:0:b0:501:c3de:dc5c with SMTP id k20-20020aa7c394000000b00501c3dedc5cmr2513665edq.18.1681394847494; Thu, 13 Apr 2023 07:07:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681394847; cv=none; d=google.com; s=arc-20160816; b=ckVsriCcSgS1RtTC1y4fo5NM9B76I+iM2t6hYGG0tLGBTswafRuC6ySJaty2zODbYq jINny4bOx5LnD6g5iibz2DZlOuD9HyhTwJNJ7WLQksKYlgMUdQQF0EUR92Uo963SPNef AcnwtdBbu7kQRUNLFXnMjzsj04g9NuxnxKTEx2cnh6n/L2t5DgKWQL8GrOsTpWC+zIup 7oUuV17Z27vtowQnnB+6jvHx/LuSP1Q/RTe3UdEfTS2g4MbG/0ey6Bqqige1eMtapttn /HhWTAUN1m2hxCbBzk8tkHMGiYv6p/6RUiDdlUBjwUM8J6aWCyqmT/Cxju6hWPy6f+2Y CdHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-transfer-encoding :content-id:mime-version:subject:cc:to:from:organization :dkim-signature; bh=B7GgR7IsxIkffahtry2Nj63PUFsJG3FcJvFXpSBJLNA=; b=nlTBkaD7iFHMDbCylh8wXGb5sHQK7FZJZGM9+gC9ydnfvB5RX1h2Pvlf3ByqANjMaC 6HOPbi6E/ar4oaTEOCm83GE3Wk+70z6OcivUFa4A6azng0JZKgXtvSOYfhyXHL2Y9cOJ 6Q+UxaXCNNEFVY8NVm1XIG12HvffvbsBlaw4vdptARRIEe7Zj7ZA2M0C2OQKEO/bZyLU dRYcTUekBKEmIzqgQCy00sZwp6woQB3Bm4bNqraMcS6mq7eDgOjWqmFylu/Zs/KvsdLH hQLdS65qB0gw74FrL3jGep2Q/381qH2jxFZ2SUFG1CYlYQypdo6QDzNyuYZO/Qfa6QAS KAjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=T7+QvR3y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v14-20020aa7cd4e000000b005048c25caa7si1762515edw.557.2023.04.13.07.07.02; Thu, 13 Apr 2023 07:07:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=T7+QvR3y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231440AbjDMNw7 (ORCPT + 99 others); Thu, 13 Apr 2023 09:52:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231513AbjDMNwz (ORCPT ); Thu, 13 Apr 2023 09:52:55 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53498183 for ; Thu, 13 Apr 2023 06:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681393923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=B7GgR7IsxIkffahtry2Nj63PUFsJG3FcJvFXpSBJLNA=; b=T7+QvR3y6EGIKj22s2vgU4ppZyTw/Y6vX8MU0Cc2TDHONEnodzmbQRFM+NdezIZ/1eiehK hyjkJGy8nGg49HCYuSvNAZxtxCMzqpQhyiwaoTK+DWBq7ybg9sJf9HZrHcNv/J+cLB0u6W FXnFHa4T9cqywZJm/l79raAn3Se3m6A= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-22-jphSqTr7PGaLvWhPkTXB_g-1; Thu, 13 Apr 2023 09:51:59 -0400 X-MC-Unique: jphSqTr7PGaLvWhPkTXB_g-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C45411C07597; Thu, 13 Apr 2023 13:51:57 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.177]) by smtp.corp.redhat.com (Postfix) with ESMTP id E0C43492B00; Thu, 13 Apr 2023 13:51:56 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells To: Chuck Lever cc: dhowells@redhat.com, Scott Mayhew , Herbert Xu , linux-nfs@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] sunrpc: Fix RFC6803 encryption test MIME-Version: 1.0 Content-ID: <1078409.1681393916.1@warthog.procyon.org.uk> Date: Thu, 13 Apr 2023 14:51:56 +0100 Message-ID: <1078410.1681393916@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763069946378662721?= X-GMAIL-MSGID: =?utf-8?q?1763070283588195856?= The usage_data[] array in rfc6803_encrypt_case() is uninitialised, so clear it as it may cause the tests to fail otherwise. Fixes: b958cff6b27b ("SUNRPC: Add encryption KUnit tests for the RFC 6803 encryption types") Link: https://lore.kernel.org/r/380323.1681314997@warthog.procyon.org.uk/ Signed-off-by: David Howells cc: Chuck Lever cc: Scott Mayhew cc: Herbert Xu cc: linux-nfs@vger.kernel.org cc: linux-crypto@vger.kernel.org --- net/sunrpc/auth_gss/gss_krb5_test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sunrpc/auth_gss/gss_krb5_test.c b/net/sunrpc/auth_gss/gss_krb5_test.c index ce0541e32fc9..aa6ec4e858aa 100644 --- a/net/sunrpc/auth_gss/gss_krb5_test.c +++ b/net/sunrpc/auth_gss/gss_krb5_test.c @@ -1327,6 +1327,7 @@ static void rfc6803_encrypt_case(struct kunit *test) if (!gk5e) kunit_skip(test, "Encryption type is not available"); + memset(usage_data, 0, sizeof(usage_data)); usage.data[3] = param->constant; Ke.len = gk5e->Ke_length;