diff mbox series

[v3] Staging: pi433: Updated bitrate range from datasheet

Message ID 0eaf24f26b1f7e89350b54a65c7f47a6@iitb.ac.in
State New
Headers
Series [v3] Staging: pi433: Updated bitrate range from datasheet |

Commit Message

Aman Sharma March 4, 2024, 7:49 a.m. UTC 
  Updated bitrate range for FSK and OOK modulation from the RFM69 
Datasheet.
The values are mentioned in Section 2.3.2 of the datasheet.

Signed-off-by: Aman Sharma<amansharma6122002@gmail.com>
---
  V1->V2: Added explanation about values in commit msg
  V2->V3: Added version comments after changelog

  drivers/staging/pi433/Documentation/pi433.txt | 6 ++++--
  drivers/staging/pi433/TODO                    | 1 -
  2 files changed, 4 insertions(+), 3 deletions(-)

-* Some missing data (marked with ###) needs to be added in the 
documentation

Comments

Dan Carpenter March 4, 2024, 8:28 a.m. UTC | #1 
On Mon, Mar 04, 2024 at 01:19:36PM +0530, Aman Sharma wrote:
> Updated bitrate range for FSK and OOK modulation from the RFM69 Datasheet.
> The values are mentioned in Section 2.3.2 of the datasheet.
> 
> Signed-off-by: Aman Sharma<amansharma6122002@gmail.com>
                            ^
Space character still missing.  Btw, I tested and checkpatch.pl will
find this issue.  Please, run checkpatch on your patches.

regards,
dan carpenter
diff mbox series

Patch

diff --git a/drivers/staging/pi433/Documentation/pi433.txt 
b/drivers/staging/pi433/Documentation/pi433.txt
index 4a0d34b4ad37..9ce7282ef6f8 100644
--- a/drivers/staging/pi433/Documentation/pi433.txt
+++ b/drivers/staging/pi433/Documentation/pi433.txt
@@ -78,7 +78,8 @@  rf params:
  		Allowed values: 433050000...434790000
  	bit_rate
  		bit rate used for transmission.
-		Allowed values: #####
+		Allowed values (For FSK): 1200...320000
+		Allowed values (For OOK): 1200...32768
  	dev_frequency
  		frequency deviation in case of FSK.
  		Allowed values: 600...500000
@@ -169,7 +170,8 @@  rf params:
  		Allowed values: 433050000...434790000
  	bit_rate
  		bit rate used for transmission.
-		Allowed values: #####
+		Allowed values (For FSK): 1200...320000
+		Allowed values (For OOK): 1200...32768
  	dev_frequency
  		frequency deviation in case of FSK.
  		Allowed values: 600...500000
diff --git a/drivers/staging/pi433/TODO b/drivers/staging/pi433/TODO
index 63a40bfcc67e..61ed3a1578bc 100644
--- a/drivers/staging/pi433/TODO
+++ b/drivers/staging/pi433/TODO
@@ -2,4 +2,3 @@ 
  * still TODOs, annotated in the code
  * currently the code introduces new IOCTLs. I'm afraid this is a bad 
idea.
    -> Replace this with another interface, hints are welcome!