From patchwork Tue Nov 22 11:12:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evgeniy Baskov X-Patchwork-Id: 24292 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2139850wrr; Tue, 22 Nov 2022 03:20:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf5JjXp/L0HQRiTW/xgnpkOTdAH7YhzItZLCQPRBstaJOhslAd5l92IjDa2iEj0UK/MmAAL0 X-Received: by 2002:aa7:c511:0:b0:469:7731:5b29 with SMTP id o17-20020aa7c511000000b0046977315b29mr10375648edq.419.1669116023237; Tue, 22 Nov 2022 03:20:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669116023; cv=none; d=google.com; s=arc-20160816; b=pwhh7FOyb/CF38y4daauaUfXClBDqzJqQc7S7nMPaTCvQ/+S0ak9ploZgUODNbBoc8 ThQGnlN9phYKY4t5cg0ZltCC33H1RJz7go5WOSozj3ebkzP59IoMpfSl8OqQAOshmkcF gghgwBLb+2m/MxtX+sIt6HxKgYo/858sUXiZCAOlJy7IFd7dIbwCmIf1+glSn+rYqfjE kfw25QA3r5va29eBR2U2Scidc0XCJ60Td1O8TGf+GYgw9g8/2NWa8Z8dU1c0tJLc3ZY6 iiTTjfEIyx/GFoq+sLnn0QlaWbOlD8hyCbnu7hz86jk3DlfTTKbBc21Vfmy1zSI01mYG +7Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=gi2WlP5Zdwk8PRGKzYD5z08u+9dLExeKMbf/xGGfE+4=; b=WlyM9SknPUQJEEfmesEO9ahFzA04gM1nKgC2JO3HwxNhPtKx2xOqR5tcXYgZbgnrs2 4FbKCB15Q8K+cJ2Y4CapsQD3KnGHsRF32WzKANJ7v1sPQWLXTNLinBfFTYq3ac2CJ0Jd zd1RJ8JLrDtlXT+lgf2JG2KeiDzn9cyIvnOIigYjhnXphtzxS1WUrF4Y4A5LOA01UJXa DO+hlgjRFYwZ2hyuyFKAIdfQicw3nsq84aetzfKEZsaViGXjQzwYsa3HhJDUX9YBZTBn DCzznIGBgqdklYKDktzUh6jO+h9YhUQtQhryJPq8v7Xo+IByxfK4w1ou5/dn2moq6BH6 mWyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=SdIP03hT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qf5-20020a1709077f0500b00787e1d77943si12767839ejc.49.2022.11.22.03.19.59; Tue, 22 Nov 2022 03:20:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ispras.ru header.s=default header.b=SdIP03hT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233332AbiKVLTD (ORCPT + 99 others); Tue, 22 Nov 2022 06:19:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbiKVLRf (ORCPT ); Tue, 22 Nov 2022 06:17:35 -0500 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 537CD6069E; Tue, 22 Nov 2022 03:14:50 -0800 (PST) Received: from localhost.localdomain (unknown [83.149.199.65]) by mail.ispras.ru (Postfix) with ESMTPSA id 5DD6140737D3; Tue, 22 Nov 2022 11:14:46 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru 5DD6140737D3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1669115686; bh=gi2WlP5Zdwk8PRGKzYD5z08u+9dLExeKMbf/xGGfE+4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SdIP03hTfI1NPSEvLMieLadei3nHwxitjzhDFs1oysvYyePn46+906Ot4745cHGst IaGVBW2lNi1wB8XP7f7X/4a8NaCKlORCVX6e8y9GH6kgsYYfn/+TiGmeNgYRGzloyw 6WqHplq1pX/a8Vnb8HXX/mktbJo0UxhQ4BuNZlGI= From: Evgeniy Baskov To: Ard Biesheuvel Cc: Peter Jones , Borislav Petkov , Andy Lutomirski , Dave Hansen , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Alexey Khoroshilov , "Limonciello, Mario" , joeyli , lvc-project@linuxtesting.org, x86@kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: [PATCH v3 24/24] efi/libstub: Make memory protection warnings include newlines Date: Tue, 22 Nov 2022 14:12:33 +0300 Message-Id: <0bcea49ef39c76f84ee9a79976c91aa6e94080fa.1668958803.git.baskov@ispras.ru> X-Mailer: git-send-email 2.37.4 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750195003238756102?= X-GMAIL-MSGID: =?utf-8?q?1750195003238756102?= From: Peter Jones efi_warn() doesn't put newlines on messages, and that makes reading warnings without newlines hard to do. Signed-off-by: Peter Jones --- drivers/firmware/efi/libstub/mem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/efi/libstub/mem.c b/drivers/firmware/efi/libstub/mem.c index 35acec241dd3..d10996e4eb01 100644 --- a/drivers/firmware/efi/libstub/mem.c +++ b/drivers/firmware/efi/libstub/mem.c @@ -294,7 +294,7 @@ efi_status_t efi_adjust_memory_range_protection(unsigned long start, rounded_end - rounded_start, attr_clear); if (status != EFI_SUCCESS) { - efi_warn("Failed to clear memory attributes at [%08lx,%08lx]: %lx", + efi_warn("Failed to clear memory attributes at [%08lx,%08lx]: %lx\n", (unsigned long)rounded_start, (unsigned long)rounded_end, status); @@ -307,7 +307,7 @@ efi_status_t efi_adjust_memory_range_protection(unsigned long start, rounded_end - rounded_start, attributes); if (status != EFI_SUCCESS) { - efi_warn("Failed to set memory attributes at [%08lx,%08lx]: %lx", + efi_warn("Failed to set memory attributes at [%08lx,%08lx]: %lx\n", (unsigned long)rounded_start, (unsigned long)rounded_end, status);