From patchwork Fri Dec 8 16:08:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 175885 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5555458vqy; Fri, 8 Dec 2023 08:09:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IEClbVrmPunPw21ZsVoW37a0tn+3vM5bqDlAPW39odH27oMv9hgQEiGEfCILvEtx26jlHbQ X-Received: by 2002:a05:6a00:856:b0:6cd:f8cd:528e with SMTP id q22-20020a056a00085600b006cdf8cd528emr343500pfk.5.1702051766435; Fri, 08 Dec 2023 08:09:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702051766; cv=none; d=google.com; s=arc-20160816; b=E/RjiJX0TflUNN43pijLARqTEV/itOAMYTHe749+wIrU6YT6Jz04ZOAsk17399usox hYwJz9o2RWvFg81rSb4+WnXaZkR+4KLI7QJRv3MOfrJ7zS8y9h7CWpCvxD470tkY9xno bPXI+tzuyyqWaiWLkcz+DN4MZi2kxk3wa4iNYnqce0NqnmQtDVHmyTScwTxH8QJg2gjH 4Ny4bSrTqm4i7fHSYUAv1lW0Ax6ohB4YucpAlSxV5eFnDxY8UbipL/ojv8Px5LdJFy0X +gx9y85van+DwCXeDE9ad9RAKAMk84sUz/QBzJhPGv/fahzMN8Yp22ayew3JrqBVE7K8 xsbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=G4X8U/nj8Sp7IUk7o/bFguXGKEwzaIctyUMz3eVvU5w=; fh=vyx8h/R3/RgPDF3hs4DKbHATzneQA+WUA+Ft3xYcKZY=; b=057YYHVIc1Wg3/2zXc8S+iLeoow420HqWCRivz1srrRoK1fBFKEm0wES52ZG7JwEvy ySkYvrYepFSFQul2xbQdBXvxVOgSn6oiVVqh+zXmEyffkesNJL+qU0wgL/q8Bj/H5fcM vDVx+TkEHrDXFlZCC5YxVuC0KdGXH4y5qdB2IvykbltlTwmDyGivD41bw1Np/VpGSr5R b8O4dCfevtsuk7LiyEN8N3L9HI6biZAAd5J9xfPuIHltunw0ZdclyiW4LCt6G+W+DaeW +vKLZKjdgtMNJi+7laEeVYmBJS7l1QrlljNlsjigl4HkpYvVupmCtl/PsChWKVJuD6Gd avfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id fh29-20020a056a00391d00b006cbf2bcf071si1749883pfb.204.2023.12.08.08.09.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 08:09:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 4699F8725CC7; Fri, 8 Dec 2023 08:09:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573829AbjLHQJM (ORCPT + 99 others); Fri, 8 Dec 2023 11:09:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233534AbjLHQJJ (ORCPT ); Fri, 8 Dec 2023 11:09:09 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96371198C for ; Fri, 8 Dec 2023 08:09:15 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBdPd-00008J-Pz; Fri, 08 Dec 2023 17:09:13 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBdPd-00ES0Y-DP; Fri, 08 Dec 2023 17:09:13 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rBdPd-00GUaa-4I; Fri, 08 Dec 2023 17:09:13 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Dominik Brodowski , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 7/7] pcmcia: xxs1500_ss: Convert to platform remove callback returning void Date: Fri, 8 Dec 2023 17:08:12 +0100 Message-ID: <09a89926787cb9f64caa73c510f04d9f04a5136f.1702051073.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1937; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=1a3XrsIBjUzDTZoYZo4bHiJM6guDdpuYJ7uENxq/LbU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlcz97w6if+bX06ito1EaAC/uUsJes2JGyWHnGh dgvlVq86nCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXM/ewAKCRCPgPtYfRL+ Ts89B/oCRgIz6tkNDFCrphlrv06SguKi+HPpSGGGY7TgCExVUV2jfIhyf6ZdBHryu2siN/p4VPj ZhfzTTulkKtT2wo2fzHOMk8aGeD9c9FUnA9sBwKZYKPoR2bwm+vaAl4b/uGNlOkSSbhZi8kZAz9 bR3nQ8lOwrHWwk8Zf8jamhyJ8cOPKMKxIcF7ramO5mSYBCiToS438PLO9FIkTCyuZcimw7RM5Wq r/XCKtnQgtN6gMceOLF4GwnYLZkoUMr+o7zn2Zo1/wOdABOkIfft10kEecl3ghUdrJ6SXC6/tAK m1nK+HFlsB3WJ6Pe0gm8elfqNIzhFIOKC90kmr+mmkxIiPeX X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 08 Dec 2023 08:09:23 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784730633203286185 X-GMAIL-MSGID: 1784730633203286185 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pcmcia/xxs1500_ss.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pcmcia/xxs1500_ss.c b/drivers/pcmcia/xxs1500_ss.c index b11c7abb1dc0..2a93fbbd128d 100644 --- a/drivers/pcmcia/xxs1500_ss.c +++ b/drivers/pcmcia/xxs1500_ss.c @@ -301,7 +301,7 @@ static int xxs1500_pcmcia_probe(struct platform_device *pdev) return ret; } -static int xxs1500_pcmcia_remove(struct platform_device *pdev) +static void xxs1500_pcmcia_remove(struct platform_device *pdev) { struct xxs1500_pcmcia_sock *sock = platform_get_drvdata(pdev); @@ -309,8 +309,6 @@ static int xxs1500_pcmcia_remove(struct platform_device *pdev) free_irq(gpio_to_irq(GPIO_CDA), sock); iounmap((void *)(sock->virt_io + (u32)mips_io_port_base)); kfree(sock); - - return 0; } static struct platform_driver xxs1500_pcmcia_socket_driver = { @@ -318,7 +316,7 @@ static struct platform_driver xxs1500_pcmcia_socket_driver = { .name = "xxs1500_pcmcia", }, .probe = xxs1500_pcmcia_probe, - .remove = xxs1500_pcmcia_remove, + .remove_new = xxs1500_pcmcia_remove, }; module_platform_driver(xxs1500_pcmcia_socket_driver);