From patchwork Sat Apr 15 16:27:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 83737 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1132174vqo; Sat, 15 Apr 2023 09:30:16 -0700 (PDT) X-Google-Smtp-Source: AKy350YF7GgCf2dDK8CR5ywF9OFeF1w4FJHX+BQfW9hA7qLzB/ji+kWN041jbQcU9U43d99Dro/0 X-Received: by 2002:a17:902:ceca:b0:1a6:5332:25b with SMTP id d10-20020a170902ceca00b001a65332025bmr8508197plg.42.1681576216519; Sat, 15 Apr 2023 09:30:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681576216; cv=none; d=google.com; s=arc-20160816; b=G0Kn6rEB1VUVmPRl2WFsxHPZSi9+j/uHKPLaWdzJeikm6pazoS9cH1IclLvM0vfJlL b5JHcgq6MEFAufP5Oc2BS+pWkx3pfo5LgXG+YvBDG/dPVAlm+hYYxyhxXtZs/UyuWbPE vIJxqQ3I0mCKii+yzyRQ7idqG5Bgj38zLFiVPdcL/2hcnDBMrZcdLdK9ZgXmInf+capR fo4b87rhXZbw4vnABSSCkmndu2LLMQSDBbg9XjKFyKVGTdRTL/d9NWew8shkdsSCzawJ 6z8WM1Ox4CB/48up+HG1d8hwMltl0t7J0wOb2il4uFgbQ1MMgLEVx4lbsstI5bkmyuII lLVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=+n1C546ZL1I+N6GOU5CwCojcyLanrdxNntqvU5Ovh+w=; b=mkCgj8ZrHRVRNc2rQbDkg909HCZv+Y03kH+GHv1wmeOaGNMNwKqI6BFgY6lmJHJ2Bm zYuD8ar+10CqMLB6tljeBeSpF9AbPhAyuZVxwDKaEEutBkbltS5SDy1BBUzYqNhwQ7k2 lbu0YM/U7L3+mslIfAoa/4FZEqPZZnj7apx9qvLEREjK+wB0PeN9WKn20VjhfQFGeZCR i+DS9cpzvN0PsMWuzSvPTFLvgFoX4UsnD+TxC/DyCqUM2pABAHha59da0+Dm80Rv8zpu YD63KwA64rLfk1duwbnnvNA13VFkGQldVkDssDQX66TX06g9Cn6DzxsApGbx/kbVi61t 0B9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@orange.fr header.s=t20230301 header.b=DatsQjS0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m13-20020a170902db0d00b001a64541624asi7835388plx.484.2023.04.15.09.30.00; Sat, 15 Apr 2023 09:30:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@orange.fr header.s=t20230301 header.b=DatsQjS0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229774AbjDOQ1T (ORCPT + 99 others); Sat, 15 Apr 2023 12:27:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229670AbjDOQ1R (ORCPT ); Sat, 15 Apr 2023 12:27:17 -0400 Received: from smtp.smtpout.orange.fr (smtp-28.smtpout.orange.fr [80.12.242.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD9092689 for ; Sat, 15 Apr 2023 09:27:15 -0700 (PDT) Received: from pop-os.home ([86.243.2.178]) by smtp.orange.fr with ESMTPA id nik4pY6QZ7Jnhnik5pkskN; Sat, 15 Apr 2023 18:27:14 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1681576034; bh=+n1C546ZL1I+N6GOU5CwCojcyLanrdxNntqvU5Ovh+w=; h=From:To:Cc:Subject:Date; b=DatsQjS0WO4wXEuyF1xcv86k8biX9DF3YSgHQKyK4UTZId+aYhwjlFTAYHgfYnVry OccGmeR7LgMputnJ427Wkh+193HDfPlui8DCprBU6ZrNNZC2AOuQD8Oquqmal4hZfl 53MTEmEKRNzVGvatqbxL6Y2maUruuZwB6k/RJ1+o62X/+cnmAKqOAz5e/WRyn1ffLg i6uG+Ara6FW6pyWAcI2hFdYYajrUyIfmObDAEmwz6DKcCYXiHDottyYiAKS/nX6Wy1 3wWeKhVKN+nQINRXBBebhTx0hyFuePAYmUuprPjKXMpNmfuSwIRObR4ch9yg4QtwrZ s5M9LVjSt6Efw== X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 15 Apr 2023 18:27:14 +0200 X-ME-IP: 86.243.2.178 From: Christophe JAILLET To: Pavel Machek , Lee Jones Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , linux-leds@vger.kernel.org Subject: [PATCH] leds: pwm-multicolor: Simplify an error message Date: Sat, 15 Apr 2023 18:27:11 +0200 Message-Id: <07d35e221faaa380fd11cd4597e42354c8eb350c.1681576017.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763260462475668046?= X-GMAIL-MSGID: =?utf-8?q?1763260462475668046?= dev_err_probe() already display the error code. There is no need to duplicate it explicitly in the error message. While at it, add a missing \n at the end of the message. Signed-off-by: Christophe JAILLET --- drivers/leds/rgb/leds-pwm-multicolor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/leds/rgb/leds-pwm-multicolor.c b/drivers/leds/rgb/leds-pwm-multicolor.c index da9d2218ae18..46cd062b8b24 100644 --- a/drivers/leds/rgb/leds-pwm-multicolor.c +++ b/drivers/leds/rgb/leds-pwm-multicolor.c @@ -158,8 +158,8 @@ static int led_pwm_mc_probe(struct platform_device *pdev) ret = led_pwm_mc_set(cdev, cdev->brightness); if (ret) return dev_err_probe(&pdev->dev, ret, - "failed to set led PWM value for %s: %d", - cdev->name, ret); + "failed to set led PWM value for %s\n", + cdev->name); platform_set_drvdata(pdev, priv); return 0;