diff mbox series

smb: delete an unnecessary statement

Message ID 077d93ae-adbf-4425-9cc4-eea5163b050c@kili.mountain
State New
Headers
Series smb: delete an unnecessary statement |

Commit Message

Dan Carpenter May 26, 2023, 12:01 p.m. UTC 
  We don't need to set the list iterators to NULL before a
list_for_each_entry() loop because they are assigned inside the
macro.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 fs/smb/client/smb2ops.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Mukesh Ojha May 26, 2023, 3:36 p.m. UTC | #1 
On 5/26/2023 5:31 PM, Dan Carpenter wrote:
> We don't need to set the list iterators to NULL before a
> list_for_each_entry() loop because they are assigned inside the
> macro.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>


Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>

-Mukesh

> ---
>   fs/smb/client/smb2ops.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
> index 5065398665f1..6e3be58cfe49 100644
> --- a/fs/smb/client/smb2ops.c
> +++ b/fs/smb/client/smb2ops.c
> @@ -618,7 +618,6 @@ parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf,
>   		 * Add a new one instead
>   		 */
>   		spin_lock(&ses->iface_lock);
> -		iface = niface = NULL;
>   		list_for_each_entry_safe(iface, niface, &ses->iface_list,
>   					 iface_head) {
>   			ret = iface_cmp(iface, &tmp_iface);
diff mbox series

Patch

diff --git a/fs/smb/client/smb2ops.c b/fs/smb/client/smb2ops.c
index 5065398665f1..6e3be58cfe49 100644
--- a/fs/smb/client/smb2ops.c
+++ b/fs/smb/client/smb2ops.c
@@ -618,7 +618,6 @@  parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf,
 		 * Add a new one instead
 		 */
 		spin_lock(&ses->iface_lock);
-		iface = niface = NULL;
 		list_for_each_entry_safe(iface, niface, &ses->iface_list,
 					 iface_head) {
 			ret = iface_cmp(iface, &tmp_iface);