From patchwork Fri Dec 22 22:50:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 182789 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp1371153dyi; Fri, 22 Dec 2023 14:52:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IFQ2QUZcOIKZjM4fIsr3RGmMaB8vaMnM7wTc7XeugBOGMCJxYFIxQxj2Fu3+JpDphiRvG0e X-Received: by 2002:a17:902:cec4:b0:1d4:1c46:a9b3 with SMTP id d4-20020a170902cec400b001d41c46a9b3mr1717912plg.43.1703285532067; Fri, 22 Dec 2023 14:52:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703285532; cv=none; d=google.com; s=arc-20160816; b=mrcIq4sk0FtQ/rlpNdjkSKbgL6NYvwBDEK7Lz0ZbkAHPXuKyAXlwpWzXFgIa5FhALb uulSfoYLqGmaQFXH2z2vHS1h+V8HXdS5nDqZD9SY9JJLkL39VXtyt34Zs09GUmlCrABV mKoPO4PP5a6WVZpu3AxcHQPoOJ1d4LyBp1U/grGiKdu01nPFMsFhP5rUcSbUJgLkAMwQ L0e4IT50s7OMqN1n74plDZ5a92oqhgatB1JuqTqzvQ6C604T9+ssghzssvvnTDp+WNMz rJ0reMxVoxrg305hSXnq8GW4rG+3hGhhAQWHq0ZFG+gAP2eCy0FhAkq+BTPWf25judwO kBvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=yaamO1kcRxzseVjTX3QsDBaDIh/FKYr+2VV9+eGWh2k=; fh=pRhPfQLlVYfHlKr8jnvugZHZivgJvP42cwXk4G+Q8Nc=; b=DueD0+NatuDwYhJVRPEfMKcL7e8RuPhnxWX5i937zjJph4niHA1H8f0eRpUbNV22bC Q3+7mI+NUKtAdQorUSG/cWKtb3dXGi6p/oTgdSaFDJkPeryc1WIJ+s7iCb7ZLl73mUMY Z5uKo86V19ByxkZfqc+Yo97XihHkzM/NXZ31rQoNTes+VzCL+trntnRNQY3lg6teqEJl mKTFgraSZpdN+EQ6bh1bl2LGUa+NqlUxksProoMUDV2FQrDyxwEWgBXngpWXQdcSPBo8 ELPta8heIAZjeTjV2NF2MyFQVTwJqYxwTVZel4W2Fbfn2hDZweErN+e5uxEwSispNaNb ufsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-10092-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10092-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id ix22-20020a170902f81600b001d3c00acddbsi3641809plb.652.2023.12.22.14.52.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 14:52:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-10092-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-10092-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10092-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9E4ED283E39 for ; Fri, 22 Dec 2023 22:52:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1519F3175D; Fri, 22 Dec 2023 22:51:20 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 930282F503 for ; Fri, 22 Dec 2023 22:51:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rGoMM-0005cR-8Y; Fri, 22 Dec 2023 23:51:14 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rGoMK-000qvL-PB; Fri, 22 Dec 2023 23:51:13 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rGoML-000FfW-2Y; Fri, 22 Dec 2023 23:51:13 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 08/13] irqchip/pruss-intc: Convert to platform remove callback returning void Date: Fri, 22 Dec 2023 23:50:39 +0100 Message-ID: <071057cfdc0bc52c574f74156b410c0337adb69c.1703284359.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1947; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=zqHuEaXEImwnlCY9D26ACfYfCkuRPJSjdQSURwFRoRw=; b=owGbwMvMwMXY3/A7olbonx/jabUkhtQ2oQOndrv++VI/M4H9w4wjfYf+qlmx3z0/zTJTOSrA/ JHM2ZTYTkZjFgZGLgZZMUUW+8Y1mVZVcpGda/9dhhnEygQyhYGLUwAmkt7H/oej4u+LBMdiBTGt taGZh1Q+6npnKR2q0xM/8rryX8CFqKd3U3pSDufzVPZenBRauOL3nczPNotFi6pKpytkOtW8Cbh dXRvrcPlJi9h2Xhat01NCdXySb8paZ5mmeabeufOp/aiKp5zILcUpfi1sNb8+P7577uKnrxcS69 9/Xj9lsY5BzNe0syKb196s8fyavO3QWakftxftqnbz/Zykfv5EEu/DlwuNH+XnRUbNtbTT7v0dn Z5ooVQek9KnX8H8zeugl4p6gKfv/UTJ8xmCZ5e7nflYkMh8nz2sqna1mP0+s5XbPn2ymr5btWCz 7xaDbxcdZputDmiNZP5REsTR2e+y/nCE2Ywo10Nu9Zn7AA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786024329669664448 X-GMAIL-MSGID: 1786024329669664448 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/irqchip/irq-pruss-intc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/irqchip/irq-pruss-intc.c b/drivers/irqchip/irq-pruss-intc.c index 0f64ecb9b1f4..6daefa7c87bf 100644 --- a/drivers/irqchip/irq-pruss-intc.c +++ b/drivers/irqchip/irq-pruss-intc.c @@ -599,7 +599,7 @@ static int pruss_intc_probe(struct platform_device *pdev) return ret; } -static int pruss_intc_remove(struct platform_device *pdev) +static void pruss_intc_remove(struct platform_device *pdev) { struct pruss_intc *intc = platform_get_drvdata(pdev); u8 max_system_events = intc->soc_config->num_system_events; @@ -616,8 +616,6 @@ static int pruss_intc_remove(struct platform_device *pdev) irq_dispose_mapping(irq_find_mapping(intc->domain, hwirq)); irq_domain_remove(intc->domain); - - return 0; } static const struct pruss_intc_match_data pruss_intc_data = { @@ -650,7 +648,7 @@ static struct platform_driver pruss_intc_driver = { .suppress_bind_attrs = true, }, .probe = pruss_intc_probe, - .remove = pruss_intc_remove, + .remove_new = pruss_intc_remove, }; module_platform_driver(pruss_intc_driver);