From patchwork Fri Dec 15 13:59:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 179307 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp9295060dys; Fri, 15 Dec 2023 06:02:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IEzVI/wn6H4MyPMxsufvFSd29WHcNEBNYxNiUodkgXZ3YtJcxknVzIPUes56xn/en4i9j1v X-Received: by 2002:a17:902:ee95:b0:1d3:41b6:6d80 with SMTP id a21-20020a170902ee9500b001d341b66d80mr3539516pld.9.1702648930476; Fri, 15 Dec 2023 06:02:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702648930; cv=none; d=google.com; s=arc-20160816; b=IacErqmIPj2UrG7oYX6ITdOCIiZzzqb7OhJTcfmjq4kDXbfKY8VY0FGFflP6bvWjzw ekD7ogIr5cCWEwqA1i4UBc358+foo/oNuNVs3ZVjBDQmL2h5FJ25M+UkqaMA/x36fqds NTsFIiuSZRQtH6UnVZvnN/fCMDeYXsz/NxAxiR7rk+32y/xijLmSn/5/wLWYqPGUU4T3 0UtedQi5M4ApWgv9VhXSYvX5KCzs9m0GV313aL2BmDZaX2znRM7Jw9Ey7H9QPgqtEL2M v9WNMuql6tLeNLngaJibguLFL7bsIldyMbkOx+64Fvx1TU5WJosW16e50Hx0yF4bldiY L6jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=jfE2SIIk/5VkQxdwey4BhLBSLAJabxdxt8eL5h+vqJE=; fh=WBAvDUdZQ65Hx9170m7xg5JkwQLI0WSCirM0+e+PVtk=; b=KLx9NyrQ8HloMjiM5737Dooy/DqlqzAlnwX5ogan3C4VTpzxfmRdxaw0BdbS0PCfNv Db+u0IjugIh5A2Y683fsLmnzAW8tLMkcBb0wivZDSzjDM9nglSPNwlsBYLfF8TYLOn9c OZbbdd/x+5axa7gPW3QSMfTJGoMS0NFobKUZWJeN+5wcGlsz+eU0730s1uKD9a2LfXdy MAL13nJCr+S8ifvuLIlo2qym42LtbdR/GT0ThTOuj0j3riWqU61QdAJG7n2D+Rsm7dc2 FN8vwCaGAkH8hq37Tx49Iw+1VDUC3P/+hPD5WR2KyJb7e1/1ZZWcVezvuy1CdFn8UsMl bG6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-1061-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1061-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id k9-20020a170902c40900b001d0bcb62f98si13749690plk.368.2023.12.15.06.02.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 06:02:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1061-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-1061-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1061-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9DF5C285FEB for ; Fri, 15 Dec 2023 14:01:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C33DB34CFA; Fri, 15 Dec 2023 13:59:40 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC32130CFA for ; Fri, 15 Dec 2023 13:59:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rE8iz-0002pb-9k; Fri, 15 Dec 2023 14:59:33 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rE8iy-00G2aA-R8; Fri, 15 Dec 2023 14:59:32 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rE8iy-003cD1-Hr; Fri, 15 Dec 2023 14:59:32 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Will Deacon , Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 15/18] perf: marvell_cn10k_tad: Convert to platform remove callback returning void Date: Fri, 15 Dec 2023 14:59:15 +0100 Message-ID: <055656e474208b0fb583e249530fa211fa3be57c.1702648125.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1823; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=I1t5aJb11RWvKIbnkVtIejhEjKmdBG1m6FZj4F8ZzMY=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfFu2lEYp/dB1CWftEjB+6ZuPTaGjyNucTK5gu xt4aJPN/KOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXxbtgAKCRCPgPtYfRL+ TuDdB/kBymw7MNfXHM14jMTwT9lo4YG/rKEingqeCW6Fo0lo6/bvV3CO0nPSK2ER6RKINJQ1Br/ Fqk/85IWBL/L+MJNehclZ9NelvYivNs03ii3VXli7l/4gGJC9De3FGL6hOyAAEl9VGDJg38l9U8 LUEL0JuVui6u5eYK96P+kSHlr6N9jaajO1A4A3TEM2RwkFbyouqCMCMGxOs+UmD8o1gR8GxpBaE XKeeICZ0eW3hqicJKgJSTULFpSPR4xal0MI/wX6VwCcrtXtqL9nLWyGNlM9kKHV9FMgIqMkXA2N eSh5kMww8MrmaEbCsE8bouGhT7atXwxJAJtUPBjYlqN7n8vR X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785356804829498696 X-GMAIL-MSGID: 1785356804829498696 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/perf/marvell_cn10k_tad_pmu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/perf/marvell_cn10k_tad_pmu.c b/drivers/perf/marvell_cn10k_tad_pmu.c index fec8e82edb95..9e635f355470 100644 --- a/drivers/perf/marvell_cn10k_tad_pmu.c +++ b/drivers/perf/marvell_cn10k_tad_pmu.c @@ -351,15 +351,13 @@ static int tad_pmu_probe(struct platform_device *pdev) return ret; } -static int tad_pmu_remove(struct platform_device *pdev) +static void tad_pmu_remove(struct platform_device *pdev) { struct tad_pmu *pmu = platform_get_drvdata(pdev); cpuhp_state_remove_instance_nocalls(tad_pmu_cpuhp_state, &pmu->node); perf_pmu_unregister(&pmu->pmu); - - return 0; } #ifdef CONFIG_OF @@ -385,7 +383,7 @@ static struct platform_driver tad_pmu_driver = { .suppress_bind_attrs = true, }, .probe = tad_pmu_probe, - .remove = tad_pmu_remove, + .remove_new = tad_pmu_remove, }; static int tad_pmu_offline_cpu(unsigned int cpu, struct hlist_node *node)