From patchwork Tue Jul 18 16:54:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 122140 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp1884649vqt; Tue, 18 Jul 2023 10:02:58 -0700 (PDT) X-Google-Smtp-Source: APBJJlFVhSaFz7KD5jmubi9VPFMBUihj7g1aHZnXJW8IkSU0lOMkBXQdKUfW4k2dVWpXW/VS9hPO X-Received: by 2002:a19:9102:0:b0:4f8:75ac:c4e8 with SMTP id t2-20020a199102000000b004f875acc4e8mr21510lfd.43.1689699778306; Tue, 18 Jul 2023 10:02:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689699778; cv=none; d=google.com; s=arc-20160816; b=WCun4r97SVmkD5ITj0kyATzy/uIFSR9RBvWuUJgPky2MbaI/Q/Pg51/EQ46a81AQR9 rifLoO+4GPuWOi63Fpj3dS8ytWbMz2CdcGM4P+/XZU6r+G1JVD1VQGkLkR5lLV76AQfF V5smqZVNxQRQ2/vtOP+ogBQCeoqlRAl3OEKLytkMDqQN177LoJISrxxK81ehJmIzo4mE whN0PP39v+5mzHwZLItEhwkdssqdM9OzsfEoBfVMYXUiPp9Aab4oKdI0mQmPDaUY6lK8 vMGnU6EuIr1It5UJX2aBt10OPVGK1GcszT2g+OC6wcys21ImA3URwFFi8tljAwfQi7Wy mduA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=9p5TpKzE8e83PeIfxy/2DxBgGQDzfgiCwiNADfWvYA0=; fh=QQV/8rttw5pdNFbK+EYJoxxq6mGqHmTQlICtN+TBwWE=; b=Nb1qK1ZFV1pV/bEpwRrxhK8efz7RzMhabHTHyJk4vTu75NW4l3fZjTX0s0848ZwQIK B2j96vi1nGSRPAkrELWx7L9NsjLOQlLOhnhxFzfh15OpNkXTiV2YBfapCiMQlQLArnjy JHmG7DzIIWKxZzaF/FxQUT/X5DxppTAard9u5adJwIkzNAVhOQeO5HOpf61I8Kptf4Jc rD8sVgbd8CuSBkuYzF/hrrzNUoqq7UTFoHS0X/rzgaXtoMFcQfwj2LkEteVG7Z1AaS69 K6xLv+zueHfKtqUHKU0/XoHw2TVQ4Id2Q5hX/LRQLiw8uIphrbslJ0eyQe2Kcoe79CJN y03w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q18-20020a056402033200b0051e0591969dsi1541245edw.345.2023.07.18.10.02.32; Tue, 18 Jul 2023 10:02:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233506AbjGRQzd (ORCPT + 99 others); Tue, 18 Jul 2023 12:55:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232279AbjGRQy7 (ORCPT ); Tue, 18 Jul 2023 12:54:59 -0400 Received: from laurent.telenet-ops.be (laurent.telenet-ops.be [IPv6:2a02:1800:110:4::f00:19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C7011BE8 for ; Tue, 18 Jul 2023 09:54:56 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:5803:2d6d:5bbc:e252]) by laurent.telenet-ops.be with bizsmtp id Ngur2A0060ucMBo01gurj6; Tue, 18 Jul 2023 18:54:54 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qLnyD-001nYH-8w; Tue, 18 Jul 2023 18:54:51 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qLnyN-000gc8-A3; Tue, 18 Jul 2023 18:54:51 +0200 From: Geert Uytterhoeven To: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Thomas Zimmermann , Magnus Damm Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Geert Uytterhoeven , Sui Jingfeng Subject: [PATCH v2 13/41] drm: renesas: shmobile: Don't set display info width and height twice Date: Tue, 18 Jul 2023 18:54:18 +0200 Message-Id: <050d3eae881e47496c87ac323bd20376a292b627.1689698048.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771778634687319524 X-GMAIL-MSGID: 1771778634687319524 From: Laurent Pinchart The display info width_mm and height_mm fields are set at init time and never overwritten, don't set them a second time when getting modes. Signed-off-by: Laurent Pinchart Signed-off-by: Geert Uytterhoeven Reviewed-by: Sui Jingfeng --- v2: - Add Reviewed-by. --- drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c index db9d8d440144db36..2ccb2fbfea26b5bf 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c @@ -585,9 +585,6 @@ static int shmob_drm_connector_get_modes(struct drm_connector *connector) drm_mode_set_name(mode); drm_mode_probed_add(connector, mode); - connector->display_info.width_mm = sdev->pdata->panel.width_mm; - connector->display_info.height_mm = sdev->pdata->panel.height_mm; - return 1; }