From patchwork Wed Dec 27 21:02:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183562 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1666057dyb; Wed, 27 Dec 2023 13:04:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IEhWD/EMPtxk7mqhskaKLJV5QzoehvU97w16GG+t9Km8/y9RchpYvelJgh7qlXR6zsJVoxF X-Received: by 2002:a05:6a20:1592:b0:196:4680:5de9 with SMTP id h18-20020a056a20159200b0019646805de9mr126546pzj.84.1703711075249; Wed, 27 Dec 2023 13:04:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703711075; cv=none; d=google.com; s=arc-20160816; b=qJG7VmU5AiDaQ/fijAHRyQYyG0/6J0hhiq5IfKKDOovPTTDEAj32dH+tkJeJLU6+5J TtwNqCEJeI/2S7LkY9hevmcN+NLAGk6d+R7V4Zgdh9CERqjl8laIvoAdFVL/jwuM9wG0 3N+Lo1kKjvWhhuk/5S7j2Viskqcbxv/HByxVGvHEuoMnVW+y8KkEBaGIzHypxcJw7kPQ +Lvx3vyeRAsu0CeOQ122Yb1wzFkrxAlvU3DwJ8UDBl+y7WH4Fx5hPMZiwwbALIdPWtQv bBD5JV4+aZbolsb3ZlpC3ueY1PhdzWbD7+W13Pc3+mvy7SL3psZXyeQMOP+qlQ49vOMA Ct3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=Slb4A2s7t32EWnQ+QxsWp6pCdhuqWr8djZdjXRe0I5k=; fh=9apTFCoTOjehv4Wznv2mb2xpDvZrq4o37EMnyVq2a9A=; b=vOqohOQtaCeU2lK/wr+dk4FAZsLFgnDPhe61yQ/OzQTF7pTfFbRdSvJbyagNec0oEG Q1C50Vy3lUD58GOv0VthOgggzQWkW010HL+1GxC48h7l+r4qpeR25t9myIbiJd9bsJD+ DLda/dsv0pEDbcFv0/+ZjMuMCH9lEGDBGxGuLdk/ZD+ej7pC9Z6HC+J5tTfy/HmSIHMc YBG4lr+yHEbWhtKEaKJVmQ06dLHT9d6HlB2mAN+l8k2i7SwZibf//4eH5lrbv9CRSwyL EQ3uXfmLfs2FZQ0lUk9jccNPy/TNYqMACXVKof8rCFkZloKACTN8FF+ZvI+iQVIHt7OZ ErxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12262-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12262-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id il4-20020a17090b164400b0028c40644383si7167075pjb.68.2023.12.27.13.04.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 13:04:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12262-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12262-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12262-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id E8C83B22943 for ; Wed, 27 Dec 2023 21:04:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 23F7349880; Wed, 27 Dec 2023 21:03:04 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5681147F53 for ; Wed, 27 Dec 2023 21:02:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIb3I-0000m3-U9; Wed, 27 Dec 2023 22:02:56 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIb3H-001wEl-Dx; Wed, 27 Dec 2023 22:02:56 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIb3I-001ZVH-1S; Wed, 27 Dec 2023 22:02:56 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Jassi Brar Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 01/12] mailbox: bcm-flexrm: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 22:02:29 +0100 Message-ID: <0350a37650c27dddd81514627f51ce8278979428.1703710628.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1940; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=FFehYL1Gn3qYjpBCEFKip15UQ3w2S8PSDK17hMiB7oo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljJDmW5WaRVDaTExhDJ2dHaJ0e/+Dtkte2R0Sk UcrLi9+EYeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYyQ5gAKCRCPgPtYfRL+ TgTTB/sF8nPHGkF89/EAWpe4KhSmfHU92qIjexhsoHCpltQJKdVDYAWXYP1cLRYgyM8FBlGuSDy pgTiX/bzMpQpWvlafPN6DdE0nDqA0ix7J5HFh3V4IPNDCriCjDG2l19h3IBz80p+poBdNgpXmuA 69mz/ep4fooRJRQVLdmOI4WnyEktgWjdpf3mYij6lIdCWFXYZvKuRjCfpnUeDLjjUOKneVkQ5gc 8sJe/aIFhWSfTrS5dChE9W4MTSHD0FvJw/K2Cmh/oJIkUSCjP/qTQ0RDzXpAv5wQkkwU3hwOErQ F+dNjjSzrJfg5dhJtcadg8SySzyYwx73I3ZO2hm1V8jT+zxE X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786470544133967146 X-GMAIL-MSGID: 1786470544133967146 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mailbox/bcm-flexrm-mailbox.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c index a2b8839d4e7c..e3e28a4f7d01 100644 --- a/drivers/mailbox/bcm-flexrm-mailbox.c +++ b/drivers/mailbox/bcm-flexrm-mailbox.c @@ -1650,7 +1650,7 @@ static int flexrm_mbox_probe(struct platform_device *pdev) return ret; } -static int flexrm_mbox_remove(struct platform_device *pdev) +static void flexrm_mbox_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct flexrm_mbox *mbox = platform_get_drvdata(pdev); @@ -1661,8 +1661,6 @@ static int flexrm_mbox_remove(struct platform_device *pdev) dma_pool_destroy(mbox->cmpl_pool); dma_pool_destroy(mbox->bd_pool); - - return 0; } static const struct of_device_id flexrm_mbox_of_match[] = { @@ -1677,7 +1675,7 @@ static struct platform_driver flexrm_mbox_driver = { .of_match_table = flexrm_mbox_of_match, }, .probe = flexrm_mbox_probe, - .remove = flexrm_mbox_remove, + .remove_new = flexrm_mbox_remove, }; module_platform_driver(flexrm_mbox_driver);