From patchwork Wed Mar 8 13:04:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 66234 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp331916wrd; Wed, 8 Mar 2023 05:31:21 -0800 (PST) X-Google-Smtp-Source: AK7set9YxTDnQ+ewV3teVuO3K5O0QXlRQuTA4LdBKdY+pqkVGiL96Yeh2gD+B9eVbuYC/AhmUglE X-Received: by 2002:aa7:da15:0:b0:4ac:c72b:5eb5 with SMTP id r21-20020aa7da15000000b004acc72b5eb5mr16102964eds.40.1678282281509; Wed, 08 Mar 2023 05:31:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678282281; cv=none; d=google.com; s=arc-20160816; b=qhDfKWPU7l77jZYVgO6xK1W5Hd+61fXKtywd+KNWMFECQT/kbwLOy921N9sLGV1YuR 3Mg2ZTpqU7+vr4sX4tQ80xma7UvHtt1mMUOkecl0FaiVX12PJ5VFMKizWPYIolASTOPh EOyDZN4NhyStoLwne6DHbmqtMhnHkjGNKvHi+4D/CUnvqq2tXlouYSJ6QvbKwy98FrPJ gLpdaDi3xGozdnqIoQBgZgiqUxFzUwxfCpAZ///Ys3yOSMuh4Npcej/gV7/5V6zbJGOL vD6bwiVwpjfNvKsoQxSC7IpYfI8bJs+R8Th1SpSvG3G+8r4viByPPZ6tVOGtR7QX9qVn 43Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=2p7ZM2eOnR9la3080eGbg5YxuhS0ye848kfWb14+aq4=; b=yc+xOVajcMucsxUISYOZxSAr4vGaMe3FcYfATFc08bMG0j2NrYE2oq2AJ5k/SOYJUd MipWRlk1i8W3tzS9heVaoIWkFol8UVg+XIaQadtAaMHoU5HvnaPPpNw7znU+6TIWrL65 4Ko3JS/zu0WDImEOuZaSh4p0hgb0OiyFtK5VMQthnNwfFQ2DINVvdPY1PUCXJeLfMiLu 3hZEMD4nmnujdyARBYaeuPqQ7FtTu5F9YBJiAm4KDuS2lT3ypmE/7I0J4cffH4/5D9S5 rouAMYVuEkAcldwJuuKYbE0CHAZUqpNDVVc/6Xw/bUOaEw9yYCpKjSuWk2um0i0OYIAm Xdvw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n5-20020a170906118500b008eb28e2cd53si2876379eja.894.2023.03.08.05.30.58; Wed, 08 Mar 2023 05:31:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231738AbjCHNTf (ORCPT + 99 others); Wed, 8 Mar 2023 08:19:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231265AbjCHNSm (ORCPT ); Wed, 8 Mar 2023 08:18:42 -0500 Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7A61D1610 for ; Wed, 8 Mar 2023 05:15:28 -0800 (PST) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed50:614d:21b0:703:d0f9]) by andre.telenet-ops.be with bizsmtp id VpFL2900M3mNwr401pFLRT; Wed, 08 Mar 2023 14:15:21 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1pZtd0-00BF13-Ah; Wed, 08 Mar 2023 14:15:20 +0100 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1pZtTX-00FVfK-Uu; Wed, 08 Mar 2023 14:04:59 +0100 From: Geert Uytterhoeven To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Siddharth Vadapalli Subject: [PATCH v3] net: ethernet: ti: am65-cpsw: Convert to devm_of_phy_optional_get() Date: Wed, 8 Mar 2023 14:04:52 +0100 Message-Id: <01605ea233ff7fc09bb0ea34fc8126af73db83f9.1678280599.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759806521821428898?= X-GMAIL-MSGID: =?utf-8?q?1759806521821428898?= Use the new devm_of_phy_optional_get() helper instead of open-coding the same operation. Signed-off-by: Geert Uytterhoeven Reviewed-by: Siddharth Vadapalli Reviewed-by: Simon Horman --- v3: - Add Reviewed-by, v2: - Rebase on top of commit 854617f52ab42418 ("net: ethernet: ti: am65-cpsw: Handle -EPROBE_DEFER for Serdes PHY") in net-next (next-20230123 and later). --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c index 4e3861c47708c9e2..25996826edabc019 100644 --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c @@ -1470,11 +1470,9 @@ static int am65_cpsw_init_serdes_phy(struct device *dev, struct device_node *por struct phy *phy; int ret; - phy = devm_of_phy_get(dev, port_np, name); - if (PTR_ERR(phy) == -ENODEV) - return 0; - if (IS_ERR(phy)) - return PTR_ERR(phy); + phy = devm_of_phy_optional_get(dev, port_np, name); + if (IS_ERR_OR_NULL(phy)) + return PTR_ERR_OR_ZERO(phy); /* Serdes PHY exists. Store it. */ port->slave.serdes_phy = phy;