Message ID | e6817d30-b443-1a73-efae-84415604b19f@redhat.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp3352738vqu; Thu, 28 Sep 2023 07:26:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHlZ1MBSKaTfv2jdaB05Oy1rLxBM0Y0rCF3JPefWV5igXxakCXDDUbR1YOFAvzHtkcSbS3U X-Received: by 2002:a17:90b:83:b0:274:8951:b5ed with SMTP id bb3-20020a17090b008300b002748951b5edmr2264621pjb.20.1695911189826; Thu, 28 Sep 2023 07:26:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695911189; cv=none; d=google.com; s=arc-20160816; b=S5MGDkMA+elZDYmf6zVpSuJOPWHZi9O2t70CZD1K7uCEcMsyC06qCh3ILRIB58sDx/ KdgBUBKEu5h/Y9pGZBiF3LjmVCye9h6MUGD4ri4l+/44mDnbXw4luZlaqFIxq4huP4ZO a1TvdKorjI67gMxaykXRNijl9GUucKQLQfmk9+JSx7y7MT+yBC5D12xwg046FryrzyA5 lxZdACqg3RJGpkEL8dlYAR1n8GinnLyb8gbTg2DATN1hSnRztWPmSZclPh/6G/jX/6Td GSzf/EoOAN89nwRJRlUigH/jrMF8bAk7dWNaj+G9HK8dw1k1/Y2lrVheVFD1Nv/J3y5u 8mTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:subject :from:references:cc:to:content-language:user-agent:mime-version:date :message-id:dkim-signature; bh=0hFRSmhC1yPSbB9D3RIWwpqfVPBnoWuA9Kbk89H68FA=; fh=+J1tU8mYRS0tAzYCer2u4MwX4DmdoEjH6cAcxs8XMyc=; b=SxtEILTEuvvikKgZhq8oPYt5IXUyW0FVZS51Owh5hW0aQERr69uFjnAAP3w4W61+4p 2/gAhEflpDWTGd31qS+gPerDwg7FHz6gPpMpYeRBouLObqGyqYyuo3Lk1jh9QTeFQuvy xzI/ki+ID04OCviuMoy1QwgRk1Dy9u7Sk2g8+B2unnpSVsb3k2s4eFb2XxVbgDfwVXSS fPkO9tDjpdT76rmy+fl5FbsxP4HML95eyhUAYPBvFhUpoxuv2LtvdNotuNWgvwuXDmjf 81qZMxuZbpRWv3oC4MtA5a3KH0o+65ptJ1IKdyKC2K+PU929ZKZIcXQpEumZEa0EwPRZ OCYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dPR3MpKX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id w9-20020a17090aaf8900b00258996c09e4si19655663pjq.22.2023.09.28.07.26.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 07:26:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dPR3MpKX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 3637E808E0D9; Thu, 28 Sep 2023 05:41:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232494AbjI1Mk6 (ORCPT <rfc822;pwkd43@gmail.com> + 21 others); Thu, 28 Sep 2023 08:40:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232462AbjI1Mk4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 28 Sep 2023 08:40:56 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9C23180 for <linux-kernel@vger.kernel.org>; Thu, 28 Sep 2023 05:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695904809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0hFRSmhC1yPSbB9D3RIWwpqfVPBnoWuA9Kbk89H68FA=; b=dPR3MpKXYU2jh/XHlITpGolXpvOp7nMNlFvC4Gbs5DkJ1MADet4vM+Svi80JCleiex2kqb t1bb5QswJ8C5NDJMj3+o/wWgvRbeOYI46D76g3yPc1FtZY2tYMIU/4/S2iyLE3+IODE67e lDrlbVX60402T2R6V5xe2GSfvx8UqCM= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-536-RF_pUnaqO8GJwQZDBOAVCw-1; Thu, 28 Sep 2023 08:40:07 -0400 X-MC-Unique: RF_pUnaqO8GJwQZDBOAVCw-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-99388334de6so1124098166b.0 for <linux-kernel@vger.kernel.org>; Thu, 28 Sep 2023 05:40:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695904806; x=1696509606; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0hFRSmhC1yPSbB9D3RIWwpqfVPBnoWuA9Kbk89H68FA=; b=WKaf1vUoFEwGF9Vk9Pwm1lA9V9ZzEMPDAhJNFsfoHPiiraWRx96WH+WHPopmyePa8q 9Q9+O8SZFDVB51Bpcvzk5dgfNaeKTGB+ZwR/KzSQp9cI7VT7OWhRXFaKTblrfmdXACyT B3FutEv8RmaIXAlXMK9obWNcObkEMAcUi9pCeIpFTCt3CN6YaFGCoJ9rooUtWKfLJpof 5RapZ097j5244Nxuf6syKDXBZhR3byKX/txI2rs5Ki43Ha68qj3EqAEHEykR/rKKww+9 3OyJT6HBGiRbxGwismjNw2mhDeXDiavKTR0FmiiN7Dcy8HmSVBKsMKAjZcBN4fM36dJO mEkg== X-Gm-Message-State: AOJu0YxTwoBXAmy+wzdTOa5aj2K953QXKL/eQmqVZwgVqEFSlM3Ml7uW vIrOKQu4N3DBwyi12lpMjySRx/ih1zN7pw55rhZHG2CnX1LM4lL9p7HT0A8S89bYi1be1g0E2BD YJIMhPfxFJuGhkazNm34seG4O X-Received: by 2002:a17:907:7712:b0:9ae:82b4:e309 with SMTP id kw18-20020a170907771200b009ae82b4e309mr1192192ejc.0.1695904806729; Thu, 28 Sep 2023 05:40:06 -0700 (PDT) X-Received: by 2002:a17:907:7712:b0:9ae:82b4:e309 with SMTP id kw18-20020a170907771200b009ae82b4e309mr1192176ejc.0.1695904806392; Thu, 28 Sep 2023 05:40:06 -0700 (PDT) Received: from [192.168.1.217] ([109.36.138.103]) by smtp.gmail.com with ESMTPSA id e8-20020a170906374800b0099cf840527csm10843051ejc.153.2023.09.28.05.40.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Sep 2023 05:40:05 -0700 (PDT) Message-ID: <e6817d30-b443-1a73-efae-84415604b19f@redhat.com> Date: Thu, 28 Sep 2023 14:40:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Bartosz Golaszewski <brgl@bgdev.pl>, Mika Westerberg <mika.westerberg@linux.intel.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Linus Walleij <linus.walleij@linaro.org>, Daniel Scally <djrscally@gmail.com>, Mark Gross <markgross@kernel.org> Cc: linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Bartosz Golaszewski <bartosz.golaszewski@linaro.org> References: <20230926145943.42814-1-brgl@bgdev.pl> From: Hans de Goede <hdegoede@redhat.com> Subject: [PATCH v2 0/5] platform/x86: int3472: don't use gpiod_toggle_active_low() In-Reply-To: <20230926145943.42814-1-brgl@bgdev.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 28 Sep 2023 05:41:05 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778129045664521669 X-GMAIL-MSGID: 1778291771513480737 |
Series |
platform/x86: int3472: don't use gpiod_toggle_active_low()
|
|
Message
Hans de Goede
Sept. 28, 2023, 12:40 p.m. UTC
Hi All, Here is a v2 of Bartosz' "don't use gpiod_toggle_active_low()" series. New in v2: - Rework to deal with ACPI path vs gpiod_lookup.key differences: acpi_get_handle(path) -> acpi_fetch_acpi_dev(handle) -> acpi_dev_name(adev) Regards, Hans Bartosz Golaszewski (2): platform/x86: int3472: Add new skl_int3472_gpiod_get_from_temp_lookup() helper gpio: acpi: remove acpi_get_and_request_gpiod() Hans de Goede (3): platform/x86: int3472: Add new skl_int3472_fill_gpiod_lookup() helper platform/x86: int3472: Stop using gpiod_toggle_active_low() platform/x86: int3472: Switch to devm_get_gpiod() drivers/gpio/gpiolib-acpi.c | 28 ----- .../x86/intel/int3472/clk_and_regulator.c | 54 ++-------- drivers/platform/x86/intel/int3472/common.h | 7 +- drivers/platform/x86/intel/int3472/discrete.c | 101 ++++++++++++++---- drivers/platform/x86/intel/int3472/led.c | 24 +---- include/linux/gpio/consumer.h | 8 -- 6 files changed, 93 insertions(+), 129 deletions(-)
Comments
On Thu, 28 Sept 2023 at 14:40, Hans de Goede <hdegoede@redhat.com> wrote: > > Hi All, > > Here is a v2 of Bartosz' "don't use gpiod_toggle_active_low()" series. > > New in v2: > - Rework to deal with ACPI path vs gpiod_lookup.key differences: > acpi_get_handle(path) -> acpi_fetch_acpi_dev(handle) -> acpi_dev_name(adev) > > Regards, > > Hans > > > Bartosz Golaszewski (2): > platform/x86: int3472: Add new > skl_int3472_gpiod_get_from_temp_lookup() helper > gpio: acpi: remove acpi_get_and_request_gpiod() > > Hans de Goede (3): > platform/x86: int3472: Add new skl_int3472_fill_gpiod_lookup() helper > platform/x86: int3472: Stop using gpiod_toggle_active_low() > platform/x86: int3472: Switch to devm_get_gpiod() > > drivers/gpio/gpiolib-acpi.c | 28 ----- > .../x86/intel/int3472/clk_and_regulator.c | 54 ++-------- > drivers/platform/x86/intel/int3472/common.h | 7 +- > drivers/platform/x86/intel/int3472/discrete.c | 101 ++++++++++++++---- > drivers/platform/x86/intel/int3472/led.c | 24 +---- > include/linux/gpio/consumer.h | 8 -- > 6 files changed, 93 insertions(+), 129 deletions(-) > > -- > 2.41.0 > Thanks Hans, this looks good to me. I'd let it sit on the list for a week. After that, do you want to take patches 1-4 and provide me with another tag? Bart
Hi, On 9/28/23 20:40, Bartosz Golaszewski wrote: > On Thu, 28 Sept 2023 at 14:40, Hans de Goede <hdegoede@redhat.com> wrote: >> >> Hi All, >> >> Here is a v2 of Bartosz' "don't use gpiod_toggle_active_low()" series. >> >> New in v2: >> - Rework to deal with ACPI path vs gpiod_lookup.key differences: >> acpi_get_handle(path) -> acpi_fetch_acpi_dev(handle) -> acpi_dev_name(adev) >> >> Regards, >> >> Hans >> >> >> Bartosz Golaszewski (2): >> platform/x86: int3472: Add new >> skl_int3472_gpiod_get_from_temp_lookup() helper >> gpio: acpi: remove acpi_get_and_request_gpiod() >> >> Hans de Goede (3): >> platform/x86: int3472: Add new skl_int3472_fill_gpiod_lookup() helper >> platform/x86: int3472: Stop using gpiod_toggle_active_low() >> platform/x86: int3472: Switch to devm_get_gpiod() >> >> drivers/gpio/gpiolib-acpi.c | 28 ----- >> .../x86/intel/int3472/clk_and_regulator.c | 54 ++-------- >> drivers/platform/x86/intel/int3472/common.h | 7 +- >> drivers/platform/x86/intel/int3472/discrete.c | 101 ++++++++++++++---- >> drivers/platform/x86/intel/int3472/led.c | 24 +---- >> include/linux/gpio/consumer.h | 8 -- >> 6 files changed, 93 insertions(+), 129 deletions(-) >> >> -- >> 2.41.0 >> > > Thanks Hans, this looks good to me. I'd let it sit on the list for a > week. After that, do you want to take patches 1-4 and provide me with > another tag? That sounds like a good plan to me, will do. Regards, Hans
On Thu, Sep 28, 2023 at 02:40:03PM +0200, Hans de Goede wrote: > Hi All, > > Here is a v2 of Bartosz' "don't use gpiod_toggle_active_low()" series. > > New in v2: > - Rework to deal with ACPI path vs gpiod_lookup.key differences: > acpi_get_handle(path) -> acpi_fetch_acpi_dev(handle) -> acpi_dev_name(adev) Code-wise LGTM, Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> But please fix tags here and there...
Hi Bart, On 9/28/23 20:40, Bartosz Golaszewski wrote: > On Thu, 28 Sept 2023 at 14:40, Hans de Goede <hdegoede@redhat.com> wrote: >> >> Hi All, >> >> Here is a v2 of Bartosz' "don't use gpiod_toggle_active_low()" series. >> >> New in v2: >> - Rework to deal with ACPI path vs gpiod_lookup.key differences: >> acpi_get_handle(path) -> acpi_fetch_acpi_dev(handle) -> acpi_dev_name(adev) >> >> Regards, >> >> Hans >> >> >> Bartosz Golaszewski (2): >> platform/x86: int3472: Add new >> skl_int3472_gpiod_get_from_temp_lookup() helper >> gpio: acpi: remove acpi_get_and_request_gpiod() >> >> Hans de Goede (3): >> platform/x86: int3472: Add new skl_int3472_fill_gpiod_lookup() helper >> platform/x86: int3472: Stop using gpiod_toggle_active_low() >> platform/x86: int3472: Switch to devm_get_gpiod() >> >> drivers/gpio/gpiolib-acpi.c | 28 ----- >> .../x86/intel/int3472/clk_and_regulator.c | 54 ++-------- >> drivers/platform/x86/intel/int3472/common.h | 7 +- >> drivers/platform/x86/intel/int3472/discrete.c | 101 ++++++++++++++---- >> drivers/platform/x86/intel/int3472/led.c | 24 +---- >> include/linux/gpio/consumer.h | 8 -- >> 6 files changed, 93 insertions(+), 129 deletions(-) >> >> -- >> 2.41.0 >> > > Thanks Hans, this looks good to me. I'd let it sit on the list for a > week. After that, do you want to take patches 1-4 and provide me with > another tag? I have just send out a v3 to address Andy's remark about me somehow resetting the authorship to me on 2 patches from Bartosz. While working on this I noticed (and fixed) a bug in: [RFT PATCH 1/4] platform/x86: int3472: provide a helper for getting GPIOs from lookups https://lore.kernel.org/all/20230926145943.42814-2-brgl@bgdev.pl/ struct gpiod_lookup_table *lookup __free(kfree) = kzalloc(struct_size(lookup, table, 1), GFP_KERNEL); You are allocating an entry for the temp lookup, but the gpiolib core expects lookup tables to be terminated with an entry lookup, so this should alloc space for 2 entries: struct gpiod_lookup_table *lookup __free(kfree) = kzalloc(struct_size(lookup, table, 2), GFP_KERNEL); Despite this already being fixed now I wanted to explicitly point this out in case you have used the same construct elsewhere during your recent gpiolib cleanup efforts ? As for your request for a tag for the 4st 4 patches for you to merge into gpiolib. I'll go and work work on that. I need to coordinate this with Ilpo, with whom I now co-maintain pdx86 . Regards, Hans
On Wed, Oct 4, 2023 at 6:30 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Hi Bart, > > On 9/28/23 20:40, Bartosz Golaszewski wrote: > > On Thu, 28 Sept 2023 at 14:40, Hans de Goede <hdegoede@redhat.com> wrote: > >> > >> Hi All, > >> > >> Here is a v2 of Bartosz' "don't use gpiod_toggle_active_low()" series. > >> > >> New in v2: > >> - Rework to deal with ACPI path vs gpiod_lookup.key differences: > >> acpi_get_handle(path) -> acpi_fetch_acpi_dev(handle) -> acpi_dev_name(adev) > >> > >> Regards, > >> > >> Hans > >> > >> > >> Bartosz Golaszewski (2): > >> platform/x86: int3472: Add new > >> skl_int3472_gpiod_get_from_temp_lookup() helper > >> gpio: acpi: remove acpi_get_and_request_gpiod() > >> > >> Hans de Goede (3): > >> platform/x86: int3472: Add new skl_int3472_fill_gpiod_lookup() helper > >> platform/x86: int3472: Stop using gpiod_toggle_active_low() > >> platform/x86: int3472: Switch to devm_get_gpiod() > >> > >> drivers/gpio/gpiolib-acpi.c | 28 ----- > >> .../x86/intel/int3472/clk_and_regulator.c | 54 ++-------- > >> drivers/platform/x86/intel/int3472/common.h | 7 +- > >> drivers/platform/x86/intel/int3472/discrete.c | 101 ++++++++++++++---- > >> drivers/platform/x86/intel/int3472/led.c | 24 +---- > >> include/linux/gpio/consumer.h | 8 -- > >> 6 files changed, 93 insertions(+), 129 deletions(-) > >> > >> -- > >> 2.41.0 > >> > > > > Thanks Hans, this looks good to me. I'd let it sit on the list for a > > week. After that, do you want to take patches 1-4 and provide me with > > another tag? > > I have just send out a v3 to address Andy's remark about me > somehow resetting the authorship to me on 2 patches from Bartosz. > > While working on this I noticed (and fixed) a bug in: > > [RFT PATCH 1/4] platform/x86: int3472: provide a helper for getting GPIOs from lookups > https://lore.kernel.org/all/20230926145943.42814-2-brgl@bgdev.pl/ > > struct gpiod_lookup_table *lookup __free(kfree) = > kzalloc(struct_size(lookup, table, 1), GFP_KERNEL); > > You are allocating an entry for the temp lookup, but the gpiolib > core expects lookup tables to be terminated with an entry lookup, > so this should alloc space for 2 entries: > > struct gpiod_lookup_table *lookup __free(kfree) = > kzalloc(struct_size(lookup, table, 2), GFP_KERNEL); > > Despite this already being fixed now I wanted to explicitly point > this out in case you have used the same construct elsewhere during > your recent gpiolib cleanup efforts ? > > As for your request for a tag for the 4st 4 patches for you to merge > into gpiolib. I'll go and work work on that. I need to coordinate > this with Ilpo, with whom I now co-maintain pdx86 . > > Regards, > > Hans > > Gah, thank you for bringing this up, I need one fix for a SPI driver. Bart
On Wed, 4 Oct 2023, Hans de Goede wrote: > Hi Bart, > > On 9/28/23 20:40, Bartosz Golaszewski wrote: > > On Thu, 28 Sept 2023 at 14:40, Hans de Goede <hdegoede@redhat.com> wrote: > >> > >> Hi All, > >> > >> Here is a v2 of Bartosz' "don't use gpiod_toggle_active_low()" series. > >> > >> New in v2: > >> - Rework to deal with ACPI path vs gpiod_lookup.key differences: > >> acpi_get_handle(path) -> acpi_fetch_acpi_dev(handle) -> acpi_dev_name(adev) > >> > >> Regards, > >> > >> Hans > >> > >> > >> Bartosz Golaszewski (2): > >> platform/x86: int3472: Add new > >> skl_int3472_gpiod_get_from_temp_lookup() helper > >> gpio: acpi: remove acpi_get_and_request_gpiod() > >> > >> Hans de Goede (3): > >> platform/x86: int3472: Add new skl_int3472_fill_gpiod_lookup() helper > >> platform/x86: int3472: Stop using gpiod_toggle_active_low() > >> platform/x86: int3472: Switch to devm_get_gpiod() > >> > >> drivers/gpio/gpiolib-acpi.c | 28 ----- > >> .../x86/intel/int3472/clk_and_regulator.c | 54 ++-------- > >> drivers/platform/x86/intel/int3472/common.h | 7 +- > >> drivers/platform/x86/intel/int3472/discrete.c | 101 ++++++++++++++---- > >> drivers/platform/x86/intel/int3472/led.c | 24 +---- > >> include/linux/gpio/consumer.h | 8 -- > >> 6 files changed, 93 insertions(+), 129 deletions(-) > >> > >> -- > >> 2.41.0 > >> > > > > Thanks Hans, this looks good to me. I'd let it sit on the list for a > > week. After that, do you want to take patches 1-4 and provide me with > > another tag? > > I have just send out a v3 to address Andy's remark about me > somehow resetting the authorship to me on 2 patches from Bartosz. > As for your request for a tag for the 4st 4 patches for you to merge > into gpiolib. I'll go and work work on that. I need to coordinate > this with Ilpo, with whom I now co-maintain pdx86 . Thanks all. I've applied patches 1-4 into platform-drivers-x86-int3472 and merged that into review-ilpo. I'll send the IB PR once LKP has done its thing for the branch.