mbox series

[0/3] memory: emif: ifdefs and platform_driver_probe()

Message ID cover.1702829744.git.u.kleine-koenig@pengutronix.de
Headers
Series memory: emif: ifdefs and platform_driver_probe() |

Message

Uwe Kleine-König Dec. 17, 2023, 7:31 p.m. UTC 
  Hello,

while preparing the series to convert the platform drivers below
drivers/memory to use .remove_new()[1], I noticed that the emif driver
unnecessarily uses some #ifdefs and doesn't use platform_driver_probe()
correctly. Note there is a conflict between these series. Tell me if you
need support to resolve this.

The alternative to the third patch is to do s/__init_or_module/__init/
in the driver and mark emif_driver with __refdata.

Best regards
Uwe

[1] https://lore.kernel.org/r/cover.1702822744.git.u.kleine-koenig@pengutronix.de 

Uwe Kleine-König (3):
  memory: emif: Simplify code handling CONFIG_DEBUG_FS
  memory: emif: Simplify code handling CONFIG_OF
  memory: emif: Drop usage of platform_driver_probe()

 drivers/memory/emif.c | 63 ++++++++++++++++---------------------------
 1 file changed, 23 insertions(+), 40 deletions(-)

base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240

Comments

Krzysztof Kozlowski Dec. 21, 2023, 8:46 p.m. UTC | #1 
On 17/12/2023 20:31, Uwe Kleine-König wrote:
> Hello,
> 
> while preparing the series to convert the platform drivers below
> drivers/memory to use .remove_new()[1], I noticed that the emif driver
> unnecessarily uses some #ifdefs and doesn't use platform_driver_probe()
> correctly. Note there is a conflict between these series. Tell me if you
> need support to resolve this.
> 

I was waiting here for some Reviews or Tested-by. Time passed, reviews
did not happen but it is too late for me to take it for the next merge
window. I will take it after the merge window.


Best regards,
Krzysztof
Uwe Kleine-König Dec. 21, 2023, 9:25 p.m. UTC | #2 
Hello Krzysztof,

On Thu, Dec 21, 2023 at 09:46:29PM +0100, Krzysztof Kozlowski wrote:
> On 17/12/2023 20:31, Uwe Kleine-König wrote:
> > while preparing the series to convert the platform drivers below
> > drivers/memory to use .remove_new()[1], I noticed that the emif driver
> > unnecessarily uses some #ifdefs and doesn't use platform_driver_probe()
> > correctly. Note there is a conflict between these series. Tell me if you
> > need support to resolve this.
> 
> I was waiting here for some Reviews or Tested-by. Time passed, reviews
> did not happen but it is too late for me to take it for the next merge
> window. I will take it after the merge window.

Thanks for the status update. That's very appreciated. (And taking it
for the next development cycle is entirely fine, that's just a drive-by
series, nothing on my side depends on it.)

Best regards
Uwe