Message ID | cover.1702648124.git.u.kleine-koenig@pengutronix.de |
---|---|
Headers |
Return-Path: <linux-kernel+bounces-1071-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp9297688dys; Fri, 15 Dec 2023 06:04:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8RHIuH1MUFZzHUBjMNHUUj9RndrKyEVkD7zcIYAwfKmDwINRikzKDJDG5FoYx+7DllopU X-Received: by 2002:a05:6a21:3e04:b0:193:fd81:9523 with SMTP id bk4-20020a056a213e0400b00193fd819523mr59522pzc.47.1702649082257; Fri, 15 Dec 2023 06:04:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702649082; cv=none; d=google.com; s=arc-20160816; b=Yd+ccTP6IeRgLRtiW+VAlduWasnTZ9iA6zJ0F4sdDyLPfrbvQhw0U6+4K+pDs4o357 VzElvVYTEiAuEN5qPMyfItBfxbBSjkN+XIRCs7s0IbCsxVGLdWdGjlxQw5CgGroQRitF puZIJTz/Cgg2RiJwvWrFJSOQtWBKNujxW1p+ZzN0q8KS8ii9UBuEv21pn7yBX5zt1MIC xzfFsEybMgAOGpzZILpIz+P3rAUfuaw29h/Ox7gW9z7kwgGSqBMfy8EJAfLnmyccwJ/R WQ6mbLH8nmwzH1EU0s0x7HVgsYsGvZnALDKKLoJ1Uad6Zxu6bD1IiGo0/o7eZTtFuxCU 7nUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=1m3Q/6wZn78j3Q79L/Mx7ee13JSSDIR3fG+PaGRCkok=; fh=jqX4AZhbE9BEqpSEJU/M34leR8eiUKJyT4Wezlzqh9Y=; b=NCIoyxbUIeKfPniqylzStdp9KFNDfD1WgUqzANBK21/GCtx37m1vHC63cOulYXxrmm xJJLm9oT4ixhJlp5woab72xnD2f7Hx/AB64hMr0ad2HeOsOeTpklXxuoNukcYF03hWES AM5OQ1UoJ08pNX/tzU/542N+zAa62QdiOMYb/7xfRir/8I4JiELKieNiargQhYH5TslJ /k8VYgCmpOWir3/YnxWufmACfPCUZ7Zm4X+2nwctdOapRi4H6pLkhi26MSjRtb9QSIOP 7ayE/zs+YjMl9fDxv6TeOAyvS/gpkS/+vXhT7VQYZ2mTBtUn8N4TqAtq4qTgLz1gNBAW 6q1A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-1071-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1071-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id u6-20020a6540c6000000b005c6b96d142dsi13054233pgp.813.2023.12.15.06.04.42 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 06:04:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1071-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-1071-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1071-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6B64D2858B2 for <ouuuleilei@gmail.com>; Fri, 15 Dec 2023 14:04:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7C21A3EA6D; Fri, 15 Dec 2023 14:00:05 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C5173DBAF for <linux-kernel@vger.kernel.org>; Fri, 15 Dec 2023 14:00:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ukl@pengutronix.de>) id 1rE8iy-0002lK-KK; Fri, 15 Dec 2023 14:59:32 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1rE8it-00G2ZD-Fu; Fri, 15 Dec 2023 14:59:27 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from <ukl@pengutronix.de>) id 1rE8it-003cBz-4n; Fri, 15 Dec 2023 14:59:27 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> To: Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com> Cc: Shuai Xue <xueshuai@linux.alibaba.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jiucheng Xu <jiucheng.xu@amlogic.com>, Neil Armstrong <neil.armstrong@linaro.org>, Kevin Hilman <khilman@baylibre.com>, Jerome Brunet <jbrunet@baylibre.com>, Martin Blumenstingl <martin.blumenstingl@googlemail.com>, linux-amlogic@lists.infradead.org, Ilkka Koskinen <ilkka@os.amperecomputing.com>, Suzuki K Poulose <suzuki.poulose@arm.com>, Besar Wicaksono <bwicaksono@nvidia.com>, Robin Murphy <robin.murphy@arm.com>, Raag Jadav <raag.jadav@intel.com>, Frank Li <Frank.li@nxp.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Yicong Yang <yangyicong@hisilicon.com>, Jonathan Cameron <jonathan.cameron@huawei.com>, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, linux-arm-msm@vger.kernel.org, Khuong Dinh <khuong@os.amperecomputing.com> Subject: [PATCH 00/18] perf: Convert to platform remove callback returning void Date: Fri, 15 Dec 2023 14:59:00 +0100 Message-ID: <cover.1702648124.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=3618; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=QIF36TPLiswSJ7BGiTaGhS7zuJ523QsVTA+4ETPdeHY=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfFukmiA7JF09OlxcCekWHX8K7N+brb2dL8yu1 L79tE8736eJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXxbpAAKCRCPgPtYfRL+ Thd3B/9bi37yHbyCmxtoBnTyzghErF03a3MQ2kLvT2WmB6Vq6D8LnRwzOn4qBxY8ZfeDwdwKqld VmyWYR4z12b2U0+t6+ECIYcIjWxvDKcBiUJSS79pIL6fT0UeHQ4H2od/hSZnok7vIJ6fJa6XtqM Zl+rLWPBfpQmhBkomYlmL8hSpsWm+NSe3gKOlCV6mjshMhP9BUbBTKxrfHgYWlBrvaBZMZ2pLPL ZqQvKMYTRYvzctEkxL+nfaZrX+/Hd3Z2fsxNMGprvpEDQQcQJjPId5k36TG+jic7RZVP3M93Oh2 /DnXMSYbdraUhMvDc20qEUTd8vLV2/RzXtBaIw/o0ZZplz3k X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785356964032444598 X-GMAIL-MSGID: 1785356964032444598 |
Series |
perf: Convert to platform remove callback returning void
|
|
Message
Uwe Kleine-König
Dec. 15, 2023, 1:59 p.m. UTC
Hello, this series converts all drivers below drivers/perf to use .remove_new(). See commit 5c5a7680e67b ("platform: Provide a remove callback that returns no value") for an extended explanation and the eventual goal. The TL;DR; is to make it harder for driver authors to leak resources without noticing. I based the patches on today's next, I had to revert commits 3115ee021bfb ("arm64: perf: Include threshold control fields in PMEVTYPER mask") and 816c26754447 ("arm64: perf: Add support for event counting threshold") to compile test on ARCH=arm (this is a problem in next, not in my patch series). This is merge window material. All patches are pairwise independent of each other so they can be applied individually. Still it would be great to let them go in all together. Best regards Uwe Uwe Kleine-König (18): perf: alibaba_uncore_drw: Convert to platform remove callback returning void perf: amlogic: Convert to platform remove callback returning void perf: arm-cci: Convert to platform remove callback returning void perf: arm-ccn: Convert to platform remove callback returning void perf: arm-cmn: Convert to platform remove callback returning void perf: arm_cspmu: Convert to platform remove callback returning void perf: arm_dmc620: Convert to platform remove callback returning void perf: arm_dsu: Convert to platform remove callback returning void perf: arm_smmuv3: Convert to platform remove callback returning void perf: arm_spe: Convert to platform remove callback returning void perf: fsl_imx8_ddr: Convert to platform remove callback returning void perf: fsl_imx9_ddr: Convert to platform remove callback returning void perf: hisilicon: Convert to platform remove callback returning void perf: marvell_cn10k_ddr: Convert to platform remove callback returning void perf: marvell_cn10k_tad: Convert to platform remove callback returning void perf: qcom_l2: Convert to platform remove callback returning void perf: thunderx2: Convert to platform remove callback returning void perf: xgene: Convert to platform remove callback returning void drivers/perf/alibaba_uncore_drw_pmu.c | 6 ++---- drivers/perf/amlogic/meson_g12_ddr_pmu.c | 6 ++---- drivers/perf/arm-cci.c | 8 +++----- drivers/perf/arm-ccn.c | 6 ++---- drivers/perf/arm-cmn.c | 5 ++--- drivers/perf/arm_cspmu/arm_cspmu.c | 6 ++---- drivers/perf/arm_dmc620_pmu.c | 6 ++---- drivers/perf/arm_dsu_pmu.c | 6 ++---- drivers/perf/arm_smmuv3_pmu.c | 6 ++---- drivers/perf/arm_spe_pmu.c | 5 ++--- drivers/perf/fsl_imx8_ddr_perf.c | 5 ++--- drivers/perf/fsl_imx9_ddr_perf.c | 6 ++---- drivers/perf/hisilicon/hisi_uncore_cpa_pmu.c | 5 ++--- drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c | 5 ++--- drivers/perf/hisilicon/hisi_uncore_hha_pmu.c | 5 ++--- drivers/perf/hisilicon/hisi_uncore_l3c_pmu.c | 5 ++--- drivers/perf/hisilicon/hisi_uncore_pa_pmu.c | 5 ++--- drivers/perf/hisilicon/hisi_uncore_sllc_pmu.c | 5 ++--- drivers/perf/marvell_cn10k_ddr_pmu.c | 5 ++--- drivers/perf/marvell_cn10k_tad_pmu.c | 6 ++---- drivers/perf/qcom_l2_pmu.c | 5 ++--- drivers/perf/thunderx2_pmu.c | 5 ++--- drivers/perf/xgene_pmu.c | 6 ++---- 23 files changed, 47 insertions(+), 81 deletions(-) base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240
Comments
Hello, On Fri, Dec 15, 2023 at 02:59:00PM +0100, Uwe Kleine-König wrote: > this series converts all drivers below drivers/perf to use > .remove_new(). See commit 5c5a7680e67b ("platform: Provide a remove > callback that returns no value") for an extended explanation and the > eventual goal. The TL;DR; is to make it harder for driver authors to > leak resources without noticing. > > I based the patches on today's next, I had to revert commits > 3115ee021bfb ("arm64: perf: Include threshold control fields in > PMEVTYPER mask") and 816c26754447 ("arm64: perf: Add support for event > counting threshold") to compile test on ARCH=arm (this is a problem in > next, not in my patch series). > > This is merge window material. All patches are pairwise independent of > each other so they can be applied individually. Still it would be great > to let them go in all together. I wonder if this series is still on someone's radar. It didn't appear in next up to now, so I guess it's too late for 6.8-rc1?! Best regards Uwe
Hi Uwe, On Wed, Jan 10, 2024 at 09:56:26AM +0100, Uwe Kleine-König wrote: > On Fri, Dec 15, 2023 at 02:59:00PM +0100, Uwe Kleine-König wrote: > > this series converts all drivers below drivers/perf to use > > .remove_new(). See commit 5c5a7680e67b ("platform: Provide a remove > > callback that returns no value") for an extended explanation and the > > eventual goal. The TL;DR; is to make it harder for driver authors to > > leak resources without noticing. > > > > I based the patches on today's next, I had to revert commits > > 3115ee021bfb ("arm64: perf: Include threshold control fields in > > PMEVTYPER mask") and 816c26754447 ("arm64: perf: Add support for event > > counting threshold") to compile test on ARCH=arm (this is a problem in > > next, not in my patch series). > > > > This is merge window material. All patches are pairwise independent of > > each other so they can be applied individually. Still it would be great > > to let them go in all together. > > I wonder if this series is still on someone's radar. It didn't appear in > next up to now, so I guess it's too late for 6.8-rc1?! This came in during the holiday period so, by the time I saw it, it was too late to land for this merge window. I can pick it up for 6.9 in a few weeks, though. I usually start queueing stuff at -rc3. Will
Hey Will, On Fri, Jan 12, 2024 at 01:50:09PM +0000, Will Deacon wrote: > On Wed, Jan 10, 2024 at 09:56:26AM +0100, Uwe Kleine-König wrote: > > On Fri, Dec 15, 2023 at 02:59:00PM +0100, Uwe Kleine-König wrote: > > > this series converts all drivers below drivers/perf to use > > > .remove_new(). See commit 5c5a7680e67b ("platform: Provide a remove > > > callback that returns no value") for an extended explanation and the > > > eventual goal. The TL;DR; is to make it harder for driver authors to > > > leak resources without noticing. > > > > > > I based the patches on today's next, I had to revert commits > > > 3115ee021bfb ("arm64: perf: Include threshold control fields in > > > PMEVTYPER mask") and 816c26754447 ("arm64: perf: Add support for event > > > counting threshold") to compile test on ARCH=arm (this is a problem in > > > next, not in my patch series). > > > > > > This is merge window material. All patches are pairwise independent of > > > each other so they can be applied individually. Still it would be great > > > to let them go in all together. > > > > I wonder if this series is still on someone's radar. It didn't appear in > > next up to now, so I guess it's too late for 6.8-rc1?! > > This came in during the holiday period so, by the time I saw it, it was > too late to land for this merge window. I can pick it up for 6.9 in a few > weeks, though. I usually start queueing stuff at -rc3. If it's not lost I'm happy. There are still quite a few more such changes necessary for other subsystems, so no time pressure from my side; 6.9 is great. Cheers Uwe
On Fri, 15 Dec 2023 14:59:00 +0100, Uwe Kleine-König wrote: > this series converts all drivers below drivers/perf to use > .remove_new(). See commit 5c5a7680e67b ("platform: Provide a remove > callback that returns no value") for an extended explanation and the > eventual goal. The TL;DR; is to make it harder for driver authors to > leak resources without noticing. > > I based the patches on today's next, I had to revert commits > 3115ee021bfb ("arm64: perf: Include threshold control fields in > PMEVTYPER mask") and 816c26754447 ("arm64: perf: Add support for event > counting threshold") to compile test on ARCH=arm (this is a problem in > next, not in my patch series). > > [...] Applied to will (for-next/perf), thanks! [01/18] perf: alibaba_uncore_drw: Convert to platform remove callback returning void https://git.kernel.org/will/c/3bc9d71775ee [02/18] perf: amlogic: Convert to platform remove callback returning void https://git.kernel.org/will/c/94843f269abd [03/18] perf: arm-cci: Convert to platform remove callback returning void https://git.kernel.org/will/c/4df3bddf8707 [04/18] perf: arm-ccn: Convert to platform remove callback returning void https://git.kernel.org/will/c/0767f1a48532 [05/18] perf: arm-cmn: Convert to platform remove callback returning void https://git.kernel.org/will/c/3909cb3b5f8d [06/18] perf: arm_cspmu: Convert to platform remove callback returning void https://git.kernel.org/will/c/79dc1570b322 [07/18] perf: arm_dmc620: Convert to platform remove callback returning void https://git.kernel.org/will/c/ca1e01c8d34a [08/18] perf: arm_dsu: Convert to platform remove callback returning void https://git.kernel.org/will/c/02d77ac1ac7e [09/18] perf: arm_smmuv3: Convert to platform remove callback returning void https://git.kernel.org/will/c/d67c3a61f063 [10/18] perf: arm_spe: Convert to platform remove callback returning void https://git.kernel.org/will/c/e63b3aef186b [11/18] perf: fsl_imx8_ddr: Convert to platform remove callback returning void https://git.kernel.org/will/c/1bb639382d3f [12/18] perf: fsl_imx9_ddr: Convert to platform remove callback returning void https://git.kernel.org/will/c/78da2a93b55b [13/18] perf: hisilicon: Convert to platform remove callback returning void https://git.kernel.org/will/c/e07486a832bb [14/18] perf: marvell_cn10k_ddr: Convert to platform remove callback returning void https://git.kernel.org/will/c/c802bd9e354f [15/18] perf: marvell_cn10k_tad: Convert to platform remove callback returning void https://git.kernel.org/will/c/86e8963f9dba [16/18] perf: qcom_l2: Convert to platform remove callback returning void https://git.kernel.org/will/c/8a2e438e710c [17/18] perf: thunderx2: Convert to platform remove callback returning void https://git.kernel.org/will/c/d4c5cef73b25 [18/18] perf: xgene: Convert to platform remove callback returning void https://git.kernel.org/will/c/b07ebe8f1428 Cheers,