mbox series

[0/7] pcmcia: Convert to platform remove callback returning void

Message ID cover.1702051073.git.u.kleine-koenig@pengutronix.de
Headers
Series pcmcia: Convert to platform remove callback returning void |

Message

Uwe Kleine-König Dec. 8, 2023, 4:08 p.m. UTC 
  Hello,

this series changes all platform drivers in drivers/pcmcia to use the
.remove_new() callback. See commit 5c5a7680e67b ("platform: Provide a
remove callback that returns no value") for an extended explanation and
the eventual goal.

All conversations are trivial, because all .remove() callbacks returned
zero unconditionally already.

There are no interdependencies between these patches, so they could be
picked up individually. However I'd expect them to go in all together.
It's unclrear to me though, who will pick them up. Dominik? Greg?

Best regards
Uwe

Uwe Kleine-König (7):
  pcmcia: bcm63xx: Convert to platform remove callback returning void
  pcmcia: db1xxx_ss: Convert to platform remove callback returning void
  pcmcia: electra_cf: Convert to platform remove callback returning void
  pcmcia: omap_cf: Convert to platform remove callback returning void
  pcmcia: pxa2xx: Convert to platform remove callback returning void
  pcmcia: sa1100: Convert to platform remove callback returning void
  pcmcia: xxs1500_ss: Convert to platform remove callback returning void

 drivers/pcmcia/bcm63xx_pcmcia.c | 5 ++---
 drivers/pcmcia/db1xxx_ss.c      | 6 ++----
 drivers/pcmcia/electra_cf.c     | 6 ++----
 drivers/pcmcia/omap_cf.c        | 5 ++---
 drivers/pcmcia/pxa2xx_base.c    | 6 ++----
 drivers/pcmcia/sa1100_generic.c | 8 +++-----
 drivers/pcmcia/xxs1500_ss.c     | 6 ++----
 7 files changed, 15 insertions(+), 27 deletions(-)

base-commit: 8e00ce02066e8f6f1ad5eab49a2ede7bf7a5ef64

Comments

Dominik Brodowski Dec. 8, 2023, 7:19 p.m. UTC | #1 
Am Fri, Dec 08, 2023 at 05:08:05PM +0100 schrieb Uwe Kleine-König:
> Hello,
> 
> this series changes all platform drivers in drivers/pcmcia to use the
> .remove_new() callback. See commit 5c5a7680e67b ("platform: Provide a
> remove callback that returns no value") for an extended explanation and
> the eventual goal.
> 
> All conversations are trivial, because all .remove() callbacks returned
> zero unconditionally already.
> 
> There are no interdependencies between these patches, so they could be
> picked up individually. However I'd expect them to go in all together.
> It's unclrear to me though, who will pick them up. Dominik? Greg?

Both options are fine with me. In the latter case:

	Acked-by: Dominik Brodowski <linux@dominikbrodowski.net>

Best
	Dominik
Greg KH Dec. 9, 2023, 9:28 a.m. UTC | #2 
On Fri, Dec 08, 2023 at 08:19:08PM +0100, Dominik Brodowski wrote:
> Am Fri, Dec 08, 2023 at 05:08:05PM +0100 schrieb Uwe Kleine-König:
> > Hello,
> > 
> > this series changes all platform drivers in drivers/pcmcia to use the
> > .remove_new() callback. See commit 5c5a7680e67b ("platform: Provide a
> > remove callback that returns no value") for an extended explanation and
> > the eventual goal.
> > 
> > All conversations are trivial, because all .remove() callbacks returned
> > zero unconditionally already.
> > 
> > There are no interdependencies between these patches, so they could be
> > picked up individually. However I'd expect them to go in all together.
> > It's unclrear to me though, who will pick them up. Dominik? Greg?
> 
> Both options are fine with me. In the latter case:
> 
> 	Acked-by: Dominik Brodowski <linux@dominikbrodowski.net>

I can take these, thanks!

greg k-h
Uwe Kleine-König Dec. 9, 2023, 1:56 p.m. UTC | #3 
Hello Dominik,

On Fri, Dec 08, 2023 at 08:19:08PM +0100, Dominik Brodowski wrote:
> Am Fri, Dec 08, 2023 at 05:08:05PM +0100 schrieb Uwe Kleine-König:
> > Hello,
> > 
> > this series changes all platform drivers in drivers/pcmcia to use the
> > .remove_new() callback. See commit 5c5a7680e67b ("platform: Provide a
> > remove callback that returns no value") for an extended explanation and
> > the eventual goal.
> > 
> > All conversations are trivial, because all .remove() callbacks returned
> > zero unconditionally already.
> > 
> > There are no interdependencies between these patches, so they could be
> > picked up individually. However I'd expect them to go in all together.
> > It's unclrear to me though, who will pick them up. Dominik? Greg?
> 
> Both options are fine with me. In the latter case:
> 
> 	Acked-by: Dominik Brodowski <linux@dominikbrodowski.net>

Then I suggest you to take them. I only suggested Greg as a fallback
because I was unsure how active you are given the PCMCIA entry in
MAINTAINERS has status "Odd Fixes".

Best regards and a calm pre-Christmas period,
Uwe
Uwe Kleine-König Dec. 9, 2023, 2:05 p.m. UTC | #4 
Hello,

On Sat, Dec 09, 2023 at 10:28:36AM +0100, Greg Kroah-Hartman wrote:
> On Fri, Dec 08, 2023 at 08:19:08PM +0100, Dominik Brodowski wrote:
> > Both options are fine with me. In the latter case:
> > 
> > 	Acked-by: Dominik Brodowski <linux@dominikbrodowski.net>
> 
> I can take these, thanks!

I missed Greg's reply when I just suggested that Dominik should take
these. Either way is fine for me.

Best regards
Uwe