From patchwork Sun Oct 22 20:59:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 15729 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp942918vqx; Sun, 22 Oct 2023 14:00:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGsf3H7pwmwdmpyL/bVsHKhrFufgsves2SF4Gdi1963vqxfM0DMjKMKVEjIeEN109YJufwH X-Received: by 2002:a81:6055:0:b0:5a1:d63f:5371 with SMTP id u82-20020a816055000000b005a1d63f5371mr8374350ywb.20.1698008416543; Sun, 22 Oct 2023 14:00:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698008416; cv=none; d=google.com; s=arc-20160816; b=SJlN+F7JIjNIMHxGglQIPaN55FADL8G1n97lkb8oPimKSFxQFbtSDOrQBWod16bByt f8rpklyZDjvupjGgb9ebi0zzO/cXP1BKVc+3iyVoxG+qeb9Cw3PvUeAPL/ziYFaZwfo+ VtFZdB7/XM23iJxU2gtTQC8RcsovdbHuLRVEswDSSM7KC+kkr4aoIDbJmZd0ZBVGDlnn Z51mM3c25TjZAfV4N32twj+bk1aKIGMy9nNPTdGKdmoIVNbuKgJ5mM0nJQnYH7hJzkQI TSjCQsC4knBzUYe9S5SRbAJPjw5Dt1fDj2XabxqavAEsYmsA/lJHt33GD/IAoz7QVxeM wong== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=73cQQIxO45qz3cOFWQdWJSGSNfMmo4mVxgrZWMonIWY=; fh=YiX7ZcaVtj3M2tXkFquBaNQ3ZfkMNtB7gv9cu9mmu04=; b=GIwbrt9owsqnw7E30Y4YfBpXLZ84x4Jncac3LtBskRbxH+hap/EDloniR+6AQiIrlf Ai8S/jbf9LGgOUdIcO/oC6ZEotYqaBZ+pDAD8abyOdl8tcKxzK3n9avv+NrWJ5RQt7D2 wiOMpV57TUacE9K6WLr6TjFFxQWKL3+MhXIQBoqHpG44oaHgr+9y6DIIxbWH4LNn41uC bSFGPl+ToRbU8PDoB/YUspkMqkYonax++aBLNcH3VGBRG0YAdpExQCwlKV9aLPM0Y9UQ 6adfvCy+s63ogR5KsEFdoCYnHh9fFOcypSp6MVXWuPdM6FGFp8SAR9cFBxV3EouSeFz3 UrIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=W0jDMP76; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wanadoo.fr Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id om3-20020a17090b3a8300b002792440fc3bsi8325508pjb.185.2023.10.22.14.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Oct 2023 14:00:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=W0jDMP76; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wanadoo.fr Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id A10BE8098191; Sun, 22 Oct 2023 14:00:15 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232739AbjJVVAI (ORCPT + 27 others); Sun, 22 Oct 2023 17:00:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbjJVVAH (ORCPT ); Sun, 22 Oct 2023 17:00:07 -0400 Received: from smtp.smtpout.orange.fr (smtp-16.smtpout.orange.fr [80.12.242.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71E3AE9 for ; Sun, 22 Oct 2023 14:00:04 -0700 (PDT) Received: from pop-os.home ([86.243.2.178]) by smtp.orange.fr with ESMTPA id ufYFqwcwpG6boufYFqoC7e; Sun, 22 Oct 2023 23:00:02 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1698008402; bh=73cQQIxO45qz3cOFWQdWJSGSNfMmo4mVxgrZWMonIWY=; h=From:To:Cc:Subject:Date; b=W0jDMP76iQYbOVkh8s0a7nAGBI9/PsvZpt5OmcjtevMyXpYOxcpRCJivVzH6a+8/b JHWcrTT2HHXpXLixt0PdiPc6KyDxglR4iVrjsHnHfa6aiz1fy0tPnAA7w2JWivP4pm u3CPtXZUYgbL9dzQ7ZSp64O5e5n50XKGz8K5UeNhlO1M2MUG1kKYgcXa4P0rVlfBfm rJTXzrq5Dt497JsQuAeJ3W4+SJEFRCk2C2D0q+A2/eZbnwocU0knlXpk7xjIiyGTHv 3gM7JzerLUSCATt/C1dx0NNp+mCNhTerUQK1RbwiMQQmOMb25D4txUe+b8lFpbaANP XZfxbwnQZL+Wg== X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sun, 22 Oct 2023 23:00:02 +0200 X-ME-IP: 86.243.2.178 From: Christophe JAILLET To: dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, veerasenareddy.burru@cavium.com Cc: felix.manlunas@cavium.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH net 0/2] liquidio: Fix an off by one in octeon_download_firmware() Date: Sun, 22 Oct 2023 22:59:45 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 22 Oct 2023 14:00:15 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780490873473909822 X-GMAIL-MSGID: 1780490873473909822 This serie fixes an off by one related to the usage of strncat() in octeon_download_firmware(). The first patch is a minimal fix. The 2nd one is an attempt to remove strncat() which is used in a wrong way most of the time. It removes the need of an intermediate buffer but may need further discussions. (i.e. is it a good idea to update h->bootcmd directly?) Both patches are compile tested only. Christophe JAILLET (2): liquidio: Fix an off by one in octeon_download_firmware() liquidio: Simplify octeon_download_firmware() .../net/ethernet/cavium/liquidio/octeon_console.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)