From patchwork Wed Sep 13 14:07:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 13914 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp1117042vqx; Wed, 13 Sep 2023 07:15:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IETwt90r+Sh4QQT4+IdqFzDaj0YOrKxI+wmJWhM5fr8C1wvzwaXpOHpV4h5TrOObdhqWdyD X-Received: by 2002:a17:90b:17d2:b0:268:14d7:bc34 with SMTP id me18-20020a17090b17d200b0026814d7bc34mr2266229pjb.20.1694614521699; Wed, 13 Sep 2023 07:15:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694614521; cv=none; d=google.com; s=arc-20160816; b=LhzP5/HqrfgqS4HIJqc+uONjWtAQA8O3DoTpxlaYPvgT0Euiz60QXPZG5+zTyvBM+Z 3sSjag0hKjrGMLJ2u8Q/cTP/4ygp3MFqbD0R3TRBbKzwSUV2DBDo2hg/3QJ4SWIjo8cr xAkZU+qWOW6vLrIu9JgXtTEGli4+0KcnamKhOG7x4qQ1Pivl84WRJejtqzqaBeDPJxH4 vQpYUd++13YVDNTzRtxmnHcw6WOmtXSb/xieWJx1aGRtnaLw3aTmI07pDwpq1or+9BEo xJfvGKmhz22eFP6eu82rxd3kqLQKM+mX3+fUlqgCUK+GAByBnrDP65Y+nZQLfZZDLCeL reFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=e3NcRF1l6IAiJUS6SrOlTCKgBtsFxVZstiqUIxL9Cyg=; fh=fKMC3BTGjlLXl5EvEhzqt3WHCynqYJKK7wAqLAOkWUw=; b=uuWre8N1RFEC2SC0CY4Fh49oOVi4T24nDwElz1mH5uxm8KXitxRVdFbSpAzwRJXHqi rS95fL4et+fKbrtiP6eR/zzytUHvao1QTVvjWRxpfqmfxRXv5sDDW62DbRaJ9b+Cziaw Sp1X12LeP5c5G+FQVuUHFjw6n/WscwGdz+dtbBPDGSmetL6PI6Gp3BbsVnVLfrQbD8J3 PP84uf0vRHHM0PR+IjWivSDMNtQQPHVq9OugnScCVHSpNOAbMN+SBEPcmTLZJ+Y4Qpno 3mRjmi44wPsVIKm3SHkWep9RlcJVQZDx7EvMxKpFJHCHeb+mQr+tQOTMnj02ad7lVihX Yhcg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id g8-20020a17090a128800b0025c219a68e3si1641121pja.45.2023.09.13.07.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 07:15:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id EFAAC8022593; Wed, 13 Sep 2023 07:09:16 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241256AbjIMOJK (ORCPT + 36 others); Wed, 13 Sep 2023 10:09:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241247AbjIMOIz (ORCPT ); Wed, 13 Sep 2023 10:08:55 -0400 Received: from xavier.telenet-ops.be (xavier.telenet-ops.be [IPv6:2a02:1800:120:4::f00:14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57CB01BD1 for ; Wed, 13 Sep 2023 07:08:50 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:f674:9611:cd05:f25a]) by xavier.telenet-ops.be with bizsmtp id lS8m2A00W3fvA4V01S8m2W; Wed, 13 Sep 2023 16:08:48 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1qgQXd-003cqx-7A; Wed, 13 Sep 2023 16:08:46 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1qgQXu-00FV3Q-HI; Wed, 13 Sep 2023 16:08:46 +0200 From: Geert Uytterhoeven To: linux-m68k@lists.linux-m68k.org Cc: Arnd Bergmann , Finn Thain , Michael Schmitz , Philip Blundell , Greg Ungerer , Joshua Thompson , Sam Creasey , Laurent Vivier , linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH v2 00/52] m68k: W=1 fixes Date: Wed, 13 Sep 2023 16:07:50 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 13 Sep 2023 07:09:17 -0700 (PDT) X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776932116614884370 X-GMAIL-MSGID: 1776932116614884370 Hi all, This patch series addresses the remaining (after [1]) warnings seen when building arch/m68k/ with W=1. Perhaps surprisingly, this work has identified and fixes a genuine bug in the Sun-3 TLB handling (see [PATCH 39/52]). Most of the patches in these series are fairly trivial changes with a very low risk of introducing any regressions. For the less trivial patches, I did look at the assembler output before and after. As Arnd is working actively on enabling W=1 rather sooner than later, and if no one objects, I'm queueing these as fixes for v6.6. Changes compared to v1[2]: - Rebase against v6.6-rc1, - Add Acked-by, - Include "process.h" instead of , to fix in-tree builds, - Drop prefix from compiler output, - Remove volatile and dedup casts, as suggested by Finn. Note that this series does not address warnings on Coldfire or MMU-less systems, but Greg is already taking care of those. Thanks for your comments! [1] "[PATCH 0/6] m68k: math-emu: Miscellaneous esthetical improvements" https://lore.kernel.org/r/cover.1692283195.git.geert@linux-m68k.org [2] "[PATCH 00/52] m68k: W=1 fixes" https://lore.kernel.org/r/cover.1694093327.git.geert@linux-m68k.org/ Geert Uytterhoeven (52): m68k: kernel: Add missing asmlinkage to do_notify_resume() m68k: kernel: Include for trap_init() m68k: kernel: Make bad_super_trap() static m68k: kernel: Add and use m68k: kernel: Add and use "ints.h" m68k: kernel: Add and use "process.h" m68k: kernel: Add and use "ptrace.h" m68k: kernel: Add and use "signal.h" m68k: kernel: Add and use "traps.h" m68k: kernel: Add and use "vectors.h" m68k: mm: Include for hwreg_() m68k: mm: Move paging_init() to common m68k: mm: Add and use "fault.h" m68k: emu: Remove unused vsnprintf() return value in nfprint() m68k: emu: Mark version[] __maybe_unused m68k: amiga: pcmcia: Replace set but not used variable by READ_ONCE() m68k: amiga: Add and use "amiga.h" m68k: atari: Document data parameter of stdma_try_lock() m68k: atari: Make ikbd_reset() static m68k: atari: Make atari_platform_init() static m68k: atari: Make atari_stram_map_pages() static m68k: atari: Add and use "atari.h" m68k: apollo: Remove unused debug console functions m68k: apollo: Make local reset, serial, and irq functions static m68k: apollo: Replace set but not used variable by READ_ONCE() m68k: apollo: Add and use "apollo.h" m68k: bvme6000: Make bvme6000_abort_int() static m68k: hp300: Include "time.h" for hp300_sched_init() m68k: mac: Remove unused sine_data[] m68k: mac: Remove unused yday in unmktime() m68k: mac: Make mac_platform_init() static m68k: mac: Add and use "mac.h" m68k: mvme147: Make mvme147_init_IRQ() static m68k: mvme16x: Remove unused sink in mvme16x_cons_write() m68k: mvme16x: Add and use "mvme16x.h" m68k: q40: Add and use "q40.h" m68k: sun3/3x: Include for config_sun3*() m68k: sun3: Improve Sun3/3x DVMA abstraction in m68k: sun3: Fix context restore in flush_tlb_range() m68k: sun3: Fix signature of sun3_get_model() m68k: sun3: Add missing asmlinkage to sun3_init() m68k: sun3: Remove unused orig_baddr in free_baddr() m68k: sun3: Remove unused start_page in sun3_bootmem_alloc() m68k: sun3: Remove unused vsprintf() return value in prom_printf() m68k: sun3: Annotate prom_printf() with __printf() m68k: sun3: Make print_pte() static m68k: sun3: Make sun3_platform_init() static m68k: sun3x: Fix signature of sun3_leds() m68k: sun3x: Do not mark dvma_map_iommu() inline m68k: sun3x: Make sun3x_halt() static m68k: sun3x: Make dvma_print() static m68k: sun3/3x: Add and use "sun3.h" arch/m68k/amiga/amiga.h | 5 ++++ arch/m68k/amiga/amisound.c | 2 ++ arch/m68k/amiga/config.c | 4 +-- arch/m68k/amiga/pcmcia.c | 3 +- arch/m68k/apollo/apollo.h | 4 +++ arch/m68k/apollo/config.c | 45 ++++++------------------------ arch/m68k/apollo/dn_ints.c | 8 ++++-- arch/m68k/atari/ataints.c | 3 +- arch/m68k/atari/atakeyb.c | 2 +- arch/m68k/atari/atari.h | 15 ++++++++++ arch/m68k/atari/atasound.c | 1 + arch/m68k/atari/config.c | 13 ++------- arch/m68k/atari/stdma.c | 1 + arch/m68k/atari/stram.c | 2 +- arch/m68k/atari/time.c | 2 ++ arch/m68k/bvme6000/config.c | 2 +- arch/m68k/emu/natfeat.c | 3 +- arch/m68k/emu/nfeth.c | 2 +- arch/m68k/hp300/time.c | 2 ++ arch/m68k/include/asm/dvma.h | 8 +++++- arch/m68k/include/asm/oplib.h | 4 ++- arch/m68k/include/asm/pgtable.h | 9 ++++++ arch/m68k/include/asm/pgtable_no.h | 1 - arch/m68k/include/asm/syscalls.h | 20 +++++++++++++ arch/m68k/include/asm/tlbflush.h | 1 + arch/m68k/kernel/early_printk.c | 4 +-- arch/m68k/kernel/ints.c | 2 ++ arch/m68k/kernel/ints.h | 7 +++++ arch/m68k/kernel/process.c | 1 + arch/m68k/kernel/process.h | 8 ++++++ arch/m68k/kernel/ptrace.c | 2 ++ arch/m68k/kernel/ptrace.h | 6 ++++ arch/m68k/kernel/setup_mm.c | 2 -- arch/m68k/kernel/signal.c | 4 ++- arch/m68k/kernel/signal.h | 7 +++++ arch/m68k/kernel/sys_m68k.c | 4 +-- arch/m68k/kernel/traps.c | 11 ++++---- arch/m68k/kernel/traps.h | 10 +++++++ arch/m68k/kernel/vectors.c | 3 ++ arch/m68k/kernel/vectors.h | 3 ++ arch/m68k/mac/baboon.c | 2 ++ arch/m68k/mac/config.c | 14 ++-------- arch/m68k/mac/iop.c | 2 ++ arch/m68k/mac/mac.h | 25 +++++++++++++++++ arch/m68k/mac/macboing.c | 11 ++------ arch/m68k/mac/misc.c | 5 ++-- arch/m68k/mac/oss.c | 2 ++ arch/m68k/mac/psc.c | 2 ++ arch/m68k/mac/via.c | 2 ++ arch/m68k/mm/fault.c | 2 ++ arch/m68k/mm/fault.h | 7 +++++ arch/m68k/mm/hwtest.c | 2 ++ arch/m68k/mm/sun3kmap.c | 6 ++-- arch/m68k/mm/sun3mmu.c | 2 +- arch/m68k/mvme147/config.c | 2 +- arch/m68k/mvme16x/config.c | 5 ++-- arch/m68k/mvme16x/mvme16x.h | 6 ++++ arch/m68k/q40/config.c | 6 ++-- arch/m68k/q40/q40.h | 6 ++++ arch/m68k/q40/q40ints.c | 2 ++ arch/m68k/sun3/config.c | 13 ++++----- arch/m68k/sun3/idprom.c | 4 ++- arch/m68k/sun3/intersil.c | 1 + arch/m68k/sun3/leds.c | 2 ++ arch/m68k/sun3/mmu_emu.c | 3 +- arch/m68k/sun3/prom/printf.c | 5 ++-- arch/m68k/sun3/sun3.h | 22 +++++++++++++++ arch/m68k/sun3/sun3dvma.c | 17 ----------- arch/m68k/sun3/sun3ints.c | 2 +- arch/m68k/sun3x/config.c | 6 ++-- arch/m68k/sun3x/dvma.c | 5 ++-- arch/m68k/sun3x/prom.c | 2 +- 72 files changed, 281 insertions(+), 148 deletions(-) create mode 100644 arch/m68k/amiga/amiga.h create mode 100644 arch/m68k/apollo/apollo.h create mode 100644 arch/m68k/atari/atari.h create mode 100644 arch/m68k/include/asm/syscalls.h create mode 100644 arch/m68k/kernel/ints.h create mode 100644 arch/m68k/kernel/process.h create mode 100644 arch/m68k/kernel/ptrace.h create mode 100644 arch/m68k/kernel/signal.h create mode 100644 arch/m68k/kernel/traps.h create mode 100644 arch/m68k/kernel/vectors.h create mode 100644 arch/m68k/mac/mac.h create mode 100644 arch/m68k/mm/fault.h create mode 100644 arch/m68k/mvme16x/mvme16x.h create mode 100644 arch/m68k/q40/q40.h create mode 100644 arch/m68k/sun3/sun3.h