From patchwork Tue Aug 8 12:28:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Souradeep Chowdhury X-Patchwork-Id: 13312 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp2332154vqr; Tue, 8 Aug 2023 12:01:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFHvMdyMPcAb9WWxciZTpM16MMplZpoq4uoOZl4KatrzXcj8uAT8pAGR4UlyV8DKYReGbJM X-Received: by 2002:aa7:d590:0:b0:522:ae79:3ee8 with SMTP id r16-20020aa7d590000000b00522ae793ee8mr675638edq.5.1691521302804; Tue, 08 Aug 2023 12:01:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691521302; cv=none; d=google.com; s=arc-20160816; b=UsTvjCzKc7ZLzWhuutMhMA6UEE7tEcYTqqUr2zns0K/uUxl5zLNMNyb62CHpI42eba JQMH6dCZuLPf4YC+8u1mfMnsXt2Ik8AXGI0evNoY00PIDzKCS1TGFS/qJ5e+B2XXp5bC zcp7dr2/jlZYcnjMPEustnVsmt9fbHDF+/ne8FZ1ellNBesaqt/oKikMhyAmF/6yJB1I q1VM8yENGvZfXd99asFEFMROOEFc8I0DbmKHPXI+Vo9vluOUVyy/bNiDKO7WKq5qE3Xx yb0MjiMoVMwu0xAUzgm0SY00BI/7OYL39veF2f6vKOrnMZ3tBeBLHXDWbNGt6h0r39id ya6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=J1KrTbBjRFPX0zeBgpkIIL6UB3TcXV+VgwKPXyOQKqM=; fh=QAmfkNnzreZhS4z3kSBhge4Qldvl29SZIFJcrCU0O18=; b=Ouf2R1AfZpeu8n5BxNhqYyx7iS005gctlp56ctcPWVWa0RAxqa+ytrrJBpIrTFcYPS 26XauWsSzR80tqRbpWARgWfQAdgJAlOUKcPPHlQ6+f/vBg44ceDzqelYkNwCSFIwxTwG uT9cOrAW8zufZ7MiPG+edId453FgQ/BBvNBw69ydoOseb9XfPrYj5EjErxRWnm6J5NQu P3hQUqaG1lpmYlt6impsIC0jQ4Wy8To7YT3er7fZMXwrG3uMahfCUWpqz/80eD4D/fkH pc/yd3LS01iUGZDaOoknahahWnFF3oww/0m0FVGwW9ONJg/abJzRDktLTk1snzzLb5Xk Ohmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=bpxYJZqy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r25-20020aa7c159000000b0051e16fd4d9asi7525619edp.223.2023.08.08.12.01.06; Tue, 08 Aug 2023 12:01:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=bpxYJZqy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233951AbjHHRO4 (ORCPT + 99 others); Tue, 8 Aug 2023 13:14:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233798AbjHHROR (ORCPT ); Tue, 8 Aug 2023 13:14:17 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 678371C136; Tue, 8 Aug 2023 09:05:56 -0700 (PDT) Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 378AvYmD011177; Tue, 8 Aug 2023 12:29:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=qcppdkim1; bh=J1KrTbBjRFPX0zeBgpkIIL6UB3TcXV+VgwKPXyOQKqM=; b=bpxYJZqyQ7Qvc38PQmEipF/v2co1gyOqKBhmIMlv1w4/BVpYQUIasBBzHwmIkELW96cr zai3sciYtmoIoGmrEqfeqyYvgnoZRq9YefzjzmhM60g6VEuRoM+q2Q+ss0Gp+Wadh7lq 1bqShwZep/bt6i7mLT5CaEVbR41JjiumWjvoXfOUOS3XaX2zDpRnio/sTNkcNgmRH2vj GfM0GCM9+puRrIU+7CGw+vpXef1blKwnuUjq+v13wq0ogJ03fFKAiCZK/7XTkWPiKCXl 7ArVlJ1MlPtBIGGiQDtnp1N7nKyhwoqpS1HnFcMaCjcSKUHs6GOsdp1t1jRRhArG2kDT Sg== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3sb6pqhmkd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Aug 2023 12:29:59 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 378CTw4F015064 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 8 Aug 2023 12:29:58 GMT Received: from hu-schowdhu-blr.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Tue, 8 Aug 2023 05:29:54 -0700 From: Souradeep Chowdhury To: Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Bjorn Andersson , Rob Herring , Alex Elder , Arnd Bergmann , Greg Kroah-Hartman CC: , , , , Sibi Sankar , Rajendra Nayak , Souradeep Chowdhury Subject: [PATCH V26 0/3] misc: Add driver support for Data Capture and Compare unit(DCC) Date: Tue, 8 Aug 2023 17:58:24 +0530 Message-ID: X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 7yRWYq7IIaK6b1WfK53MjEy2_k4_hlzz X-Proofpoint-ORIG-GUID: 7yRWYq7IIaK6b1WfK53MjEy2_k4_hlzz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-08_10,2023-08-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 adultscore=0 malwarescore=0 suspectscore=0 spamscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 mlxlogscore=999 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308080111 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773688232607609282 X-GMAIL-MSGID: 1773688641445165283 DCC(Data Capture and Compare) is a DMA engine designed for debugging purposes. In case of a system crash or manual software triggers by the user the DCC hardware stores the value at the register addresses which can be used for debugging purposes. The DCC driver provides the user with debugfs interface to configure the register addresses. The options that the DCC hardware provides include reading from registers, writing to registers, first reading and then writing to registers and looping through the values of the same register. In certain cases a register write needs to be executed for accessing the rest of the registers, also the user might want to record the changing values of a register with time for which he has the option to use the loop feature. The options mentioned above are exposed to the user by debugfs files once the driver is probed. The details and usage of this debugfs files are documented in Documentation/ABI/testing/debugfs-driver-dcc. As an example let us consider a couple of debug scenarios where DCC has been proved to be effective for debugging purposes:- i)TimeStamp Related Issue On SC7180, there was a coresight timestamp issue where it would occasionally be all 0 instead of proper timestamp values. Proper timestamp: Idx:3373; ID:10; I_TIMESTAMP : Timestamp.; Updated val = 0x13004d8f5b7aa; CC=0x9e Zero timestamp: Idx:3387; ID:10; I_TIMESTAMP : Timestamp.; Updated val = 0x0; CC=0xa2 Now this is a non-fatal issue and doesn't need a system reset, but still needs to be rootcaused and fixed for those who do care about coresight etm traces. Since this is a timestamp issue, we would be looking for any timestamp related clocks and such. We get all the clk register details from IP documentation and configure it via DCC config_read debugfs node. Before that we set the current linked list. /* Program the linked list with the addresses */ echo R 0x10c004 > /sys/kernel/debug/qcom-dcc/../3/config echo R 0x10c008 > /sys/kernel/debug/qcom-dcc/../3/config echo R 0x10c00c > /sys/kernel/debug/qcom-dcc/../3/config echo R 0x10c010 > /sys/kernel/debug/qcom-dcc/../3/config ..... and so on for other timestamp related clk registers /* Other way of specifying is in "addr len" pair, in below case it specifies to capture 4 words starting 0x10C004 */ echo R 0x10C004 4 > /sys/kernel/debug/qcom-dcc/../3/config_read /* Enable DCC */ echo 1 > /sys/kernel/debug/qcom-dcc/../3/enable /* Run the timestamp test for working case */ /* Send SW trigger */ echo 1 > /sys/kernel/debug/qcom-dcc/../trigger /* Read SRAM */ cat /dev/dcc_sram > dcc_sram1.bin /* Run the timestamp test for non-working case */ /* Send SW trigger */ echo 1 > /sys/kernel/debug/qcom-dcc/../trigger /* Read SRAM */ cat /dev/dcc_sram > dcc_sram2.bin Get the parser from [1] and checkout the latest branch. /* Parse the SRAM bin */ python dcc_parser.py -s dcc_sram1.bin --v2 -o output/ python dcc_parser.py -s dcc_sram2.bin --v2 -o output/ Sample parsed output of dcc_sram1.bin: 03/14/21 Linux DCC Parser next_ll_offset : 0x1c ii)NOC register errors A particular class of registers called NOC which are functional registers was reporting errors while logging the values.To trace these errors the DCC has been used effectively. The steps followed were similar to the ones mentioned above. In addition to NOC registers a few other dependent registers were configured in DCC to monitor it's values during a crash. A look at the dependent register values revealed that the crash was happening due to a secured access to one of these dependent registers. All these debugging activity and finding the root cause was achieved using DCC. DCC parser is available at the following open source location https://git.codelinaro.org/clo/le/platform/vendor/qcom-opensource/tools/-/tree/opensource-tools.lnx.1.0.r176-rel/dcc_parser Changes in v26 * Fixed the build error in V25 of the patch series Changes in v25 * Updated the documentation of the structure dcc_config_entry as per the comments in V23 * Updated the documentation of the dcc Kconfig definition as per comment in V24 * Used u64 where applicable * Removed the mutex locks where it is not needed * Removed the use of unlikely keyword Souradeep Chowdhury (3): dt-bindings: misc: qcom,dcc: Add the dtschema misc: dcc: Add driver support for Data Capture and Compare unit(DCC) MAINTAINERS: Add the entry for DCC(Data Capture and Compare) driver support Documentation/ABI/testing/debugfs-driver-dcc | 10 +- .../devicetree/bindings/misc/qcom,dcc.yaml | 44 + MAINTAINERS | 8 + drivers/misc/Kconfig | 8 + drivers/misc/Makefile | 1 + drivers/misc/qcom-dcc.c | 1310 +++++++++++++++++ 6 files changed, 1376 insertions(+), 5 deletions(-) create mode 100644 Documentation/devicetree/bindings/misc/qcom,dcc.yaml create mode 100644 drivers/misc/qcom-dcc.c --- 2.17.1